@internetarchive/ia-menu-slider - npm Package Compare versions

Comparing version 0.1.3-alpha4 to 0.1.3-alpha5

package.json

 {
   "name": "@internetarchive/ia-menu-slider",
-  "version": "0.1.3-alpha4",
+  "version": "0.1.3-alpha5",
   "description": "Menu slider used in ia-topnav",
@@ -5,0 +5,0 @@ "author": "ia-menu-slider",

src/menu-button.js

@@ -62,3 +62,3 @@ import { html, LitElement } from 'lit-element';
 
-  render() {
+  get linkButton() {
     return html`
@@ -69,9 +69,22 @@ <a
         @click=${this.followable ? undefined : this.onClick}
+      >${this.menuItem}</a>
+    `;
+  }
+
+  get clickButton() {
+    return html`
+      <button
+        class="menu-item ${this.buttonClass}"
+        @click=${this.onClick}
       >
         ${this.menuItem}
-      </a>
-    `;
+      </button>
+  `;
   }
+
+  render() {
+    return this.href ? this.linkButton : this.clickButton;
+  }
 }
 
 customElements.define('menu-button', MenuButton);

src/styles/menu-button.js

@@ -21,2 +21,6 @@ import { css } from 'lit-element';
 
+  button.menu-item {
+    border: none;
+  }
+
   .menu-item:focus {
@@ -23,0 +27,0 @@ outline: none;

test/ia-menu-slider.test.js

@@ -87,3 +87,3 @@ import { html, fixture, expect } from '@open-wc/testing';
       .shadowRoot
-      .querySelector('a')
+      .querySelector('button')
       .click();
@@ -118,3 +118,3 @@
       .shadowRoot
-      .querySelector('a')
+      .querySelector('button')
       .click();
@@ -121,0 +121,0 @@ await el.updateComplete;

No alert changes

Improved metrics

Total package byte prevSize

63335

increased by0.5%

Lines of code

699

increased by2.04%

No dependency changes