@ionic/react - npm Package Compare versions

Comparing version 4.12.0-dev.201910281628.f70e71a to 4.12.0-dev.201910301839.70fefb5

dist/index.esm.js

@@ -408,13 +408,7 @@ import React, { useContext } from 'react';
             const _a = this.props, { isOpen, onDidDismiss } = _a, cProps = __rest(_a, ["isOpen", "onDidDismiss"]);
-            let overlay = this.overlay;
-            if (!overlay) {
-                overlay = this.overlay = await controller.create(Object.assign({}, cProps));
-            }
+            const overlay = this.overlay = await controller.create(Object.assign({}, cProps));
             attachProps(overlay, {
                 [dismissEventName]: onDidDismiss
             }, prevProps);
-            // Check isOpen again since the value could of changed during the async call to controller.create
-            if (this.props.isOpen === true) {
-                await overlay.present();
-            }
+            await overlay.present();
         }
@@ -421,0 +415,0 @@ render() {

dist/index.js

@@ -414,13 +414,7 @@ 'use strict';
             const _a = this.props, { isOpen, onDidDismiss } = _a, cProps = tslib_1.__rest(_a, ["isOpen", "onDidDismiss"]);
-            let overlay = this.overlay;
-            if (!overlay) {
-                overlay = this.overlay = await controller.create(Object.assign({}, cProps));
-            }
+            const overlay = this.overlay = await controller.create(Object.assign({}, cProps));
             attachProps(overlay, {
                 [dismissEventName]: onDidDismiss
             }, prevProps);
-            // Check isOpen again since the value could of changed during the async call to controller.create
-            if (this.props.isOpen === true) {
-                await overlay.present();
-            }
+            await overlay.present();
         }
@@ -427,0 +421,0 @@ render() {

package.json

 {
   "name": "@ionic/react",
-  "version": "4.12.0-dev.201910281628.f70e71a",
+  "version": "4.12.0-dev.201910301839.70fefb5",
   "description": "React specific wrapper for @ionic/core",
@@ -42,3 +42,3 @@ "keywords": [
   "dependencies": {
-    "@ionic/core": "4.12.0-dev.201910281628.f70e71a",
+    "@ionic/core": "4.12.0-dev.201910301839.70fefb5",
     "tslib": "*"
@@ -45,0 +45,0 @@ },

No alert changes

Worsened metrics

Total package byte prevSize

688677

decreased by-0.17%

Lines of code

5310

decreased by-0.23%

Dependency changes

• + Added@ionic/core@4.12.0-dev.201910301839.70fefb5(transitive)

• - Removed@ionic/core@4.12.0-dev.201910281628.f70e71a(transitive)

• Updated@ionic/core@4.12.0-dev.201910301839.70fefb5