@journeyapps/cloudcode-build-legacy - npm Package Compare versions

Comparing version 0.0.0-dev.a6261c7 to 0.0.0-dev.a832f00

dist/build.d.ts

 /**
  * @param src - path to the task. Must contain a cloudcode folder.
  * @param dest - destination folder. Will contain an `app/cloudcode` folder after building.
- * @param [zipPath] - path to use for creating a zip of dest. No zip created if this is null.
+ * @param zipPath - path to use for creating a zip of dest.
  * @param config - task config, written to config.json.
+ * @param options - build options.
  */
-export declare function build(src: string, dest: string, zipPath: string | null, config: any): Promise<string>;
+export declare function build(src: string, dest: string, zipPath: string, config: any, options: {
+    yarnHome: string;
+}): Promise<string>;

dist/build.js

 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.build = void 0;
+exports.build = build;
 const babel = require("@babel/core");
@@ -9,7 +9,6 @@ const jetpack = require("fs-jetpack");
 const path = require("path");
-const glob = require("glob-promise");
+const glob_1 = require("glob");
 const cloudcodeBuild = require("@journeyapps/cloudcode-build");
 const yarn_1 = require("./yarn");
 const error_1 = require("./error");
-const { YARN_HOME } = require('./config');
 const debug = require('debug')('build');
@@ -40,3 +39,3 @@ // Babel config for tasks that don't have a defined "build" step.
     const fullSrc = path.join(root, src);
-    var files = await glob(fullSrc + '/**/*.js');
+    var files = await (0, glob_1.glob)(fullSrc + '/**/*.js');
     debug('building files in', fullSrc, ':', files);
@@ -112,9 +111,9 @@ for (let file of files) {
  * @param dest - destination folder. Will contain an `app/cloudcode` folder after building.
- * @param [zipPath] - path to use for creating a zip of dest. No zip created if this is null.
+ * @param zipPath - path to use for creating a zip of dest.
  * @param config - task config, written to config.json.
+ * @param options - build options.
  */
-async function build(src, dest, zipPath, config) {
+async function build(src, dest, zipPath, config, options) {
     const taskName = config.task;
-    // true if safe to run user- or package-defined scripts as part of the install process.
-    const runInstallScripts = config.runInstallScripts;
+    const yarnHome = options.yarnHome;
     await jetpack.dir(dest, { empty: true });
@@ -146,3 +145,3 @@ debug('copy app');
     }
-    else if (!runInstallScripts && !isCloudCodeBuild) {
+    else if (!isCloudCodeBuild) {
         throw new error_1.BuildError(`Custom build scripts not allowed. Use \`"build": "cloudcode-build"\` in package.json.`, {
@@ -156,3 +155,3 @@ error: 'CLOUDCODE/BUILD/BUILD_FAILED'
     }
-    const cacheOptions = ['--cache-folder', path.join(YARN_HOME, 'yarn-cache')];
+    const cacheOptions = ['--cache-folder', path.join(yarnHome, 'yarn-cache')];
     let args = [
@@ -169,19 +168,6 @@ 'install',
     ];
-    if (!runInstallScripts) {
-        // runInstallScripts is behind a hidden feature flag,
-        // Don't run lifecycle scripts when installing, which could be a security issue, unless it's
-        // authorized by the feature flag.
-        //
-        // The security issue is that this Lambda process may be re-used when rebuilding the next app,
-        // and lifecycle scripts could theoretically spawn a long-running process that can then read
-        // the source of the next app.
-        //
-        // Disabling scripts prevents certain packages from being installed correctly, especially packages using
-        // native extensions, or downloading external resources.
-        args.push('--ignore-scripts');
-    }
     let env = {
         // Yarn is hardcoded to store configuration in the user's home dir.
-        // Since our home dir is read-only, we override it for yarn.
-        HOME: YARN_HOME
+        // Since our home dir might be read-only, we override it for yarn.
+        HOME: yarnHome
     };
@@ -207,3 +193,3 @@ try {
         }
-        else if (hasBuild && runInstallScripts) {
+        else if (hasBuild) {
             // Custom build script.
@@ -268,12 +254,6 @@ await (0, yarn_1.runScript)(taskPath, ['run', '--quiet', 'build'], { env });
     await createEntry(dest, destTaskPath);
-    if (zipPath) {
-        debug('zip');
-        await zip(dest, zipPath);
-        return zipPath;
-    }
-    else {
-        return dest;
-    }
+    debug('zip');
+    await zip(dest, zipPath);
+    return zipPath;
 }
-exports.build = build;
 //# sourceMappingURL=build.js.map

dist/BuildParameters.d.ts

@@ -6,3 +6,4 @@ export interface BuildParameters {
     outPath: string;
-    zipPath?: string;
+    zipPath: string;
+    yarnHome?: string;
 }

dist/cli.js

@@ -12,5 +12,5 @@ #!/usr/bin/env node
         .option('out', { string: true, demandOption: true })
-        .option('zip', { string: true })
+        .option('zip', { string: true, demandOption: true })
         .option('task', { string: true, demandOption: true })
-        .option('runInstallScripts', { default: false })
+        .option('yarnHome', { string: true })
         // TODO: investigate yargs.config() for reading task config blob from a file. But how to ensure required args?
@@ -31,5 +31,5 @@ .option('appId', { string: true, demandOption: true, describe: "CloudCode's reference id" })
             appInstanceIds: [argv.backendId],
-            backendUrl: argv.backendUrl,
-            runInstallScripts: argv.runInstallScripts
-        }
+            backendUrl: argv.backendUrl
+        },
+        yarnHome: argv.yarnHome
     });
@@ -36,0 +36,0 @@ }))

dist/config.d.ts

 declare const TMP_PATH = "/tmp/cloudcode-build";
-declare const WORKING_PATH: string;
-declare const APP_PATH: string;
-declare const OUTPUT_PATH: string;
-declare const ZIP_PATH: string;
 declare const YARN_HOME: string;
-export { TMP_PATH, WORKING_PATH, APP_PATH, OUTPUT_PATH, ZIP_PATH, YARN_HOME };
+export { TMP_PATH, YARN_HOME };

dist/config.js

 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.YARN_HOME = exports.ZIP_PATH = exports.OUTPUT_PATH = exports.APP_PATH = exports.WORKING_PATH = exports.TMP_PATH = void 0;
-const TMP_PATH = '/tmp/cloudcode-build'; // FIXME: maybe use mktemp or other task-specific workdir?
+exports.YARN_HOME = exports.TMP_PATH = void 0;
+const TMP_PATH = '/tmp/cloudcode-build';
 exports.TMP_PATH = TMP_PATH;
-const WORKING_PATH = TMP_PATH + '/extract';
-exports.WORKING_PATH = WORKING_PATH;
-const APP_PATH = WORKING_PATH + '/app';
-exports.APP_PATH = APP_PATH;
-const OUTPUT_PATH = TMP_PATH + '/dist';
-exports.OUTPUT_PATH = OUTPUT_PATH;
-const ZIP_PATH = TMP_PATH + '/build.zip';
-exports.ZIP_PATH = ZIP_PATH;
 const YARN_HOME = TMP_PATH + '/yarn';
 exports.YARN_HOME = YARN_HOME;
 //# sourceMappingURL=config.js.map

dist/index.js

 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.handle = void 0;
+exports.handle = handle;
 const jetpack = require("fs-jetpack");
@@ -8,14 +8,14 @@ const build_1 = require("./build");
 const debug = require('debug')('build');
-const { TMP_PATH, APP_PATH, ZIP_PATH, OUTPUT_PATH } = require('./config');
+const { TMP_PATH, YARN_HOME } = require('./config');
 async function handle(event) {
-    var _a, _b;
+    var _a;
     try {
-        await jetpack.dir(TMP_PATH, { empty: true });
-        await jetpack.dir(APP_PATH, { empty: true });
-        const outPath = (_a = event.outPath) !== null && _a !== void 0 ? _a : OUTPUT_PATH;
-        const zipPath = (_b = event.zipPath) !== null && _b !== void 0 ? _b : ZIP_PATH;
-        debug('copying...');
-        await jetpack.copy(event.appPath, APP_PATH, { overwrite: true }); // FIXME: this might cause copy-loops if outPath is inside event.appPath
+        // await jetpack.dir(TMP_PATH, { empty: true });
+        await jetpack.dir(TMP_PATH, {});
+        const appPath = event.appPath;
+        const outPath = event.outPath;
+        const zipPath = event.zipPath;
+        const yarnHome = (_a = event.yarnHome) !== null && _a !== void 0 ? _a : YARN_HOME;
         debug('building...');
-        var zipFile = await (0, build_1.build)(APP_PATH, outPath, zipPath, event.taskConfig);
+        var zipFile = await (0, build_1.build)(appPath, outPath, zipPath, event.taskConfig, { yarnHome });
         debug('built', outPath, zipFile);
@@ -28,7 +28,5 @@ debug('done.');
         console.error(wrappedError); // Includes error.stack
-        // return wrappedError;
         throw wrappedError;
     }
 }
-exports.handle = handle;
 //# sourceMappingURL=index.js.map

dist/yarn.js

 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.runScript = exports.runYarn = void 0;
+exports.runYarn = runYarn;
+exports.runScript = runScript;
 const child_process_promise_1 = require("child-process-promise");
@@ -11,3 +12,2 @@ const debug = require('debug')('build');
 }
-exports.runYarn = runYarn;
 async function runScript(dir, args, options) {
@@ -46,3 +46,2 @@ const yarnPath = require.resolve('yarn/bin/yarn.js');
 }
-exports.runScript = runScript;
 /**
@@ -49,0 +48,0 @@ * Run a yarn command and log the output.

package.json

 {
   "name": "@journeyapps/cloudcode-build-legacy",
-  "version": "0.0.0-dev.a6261c7",
+  "version": "0.0.0-dev.a832f00",
   "description": "Port of JourneyApps CloudCode's legacy build tooling.",
@@ -16,23 +16,22 @@ "publishConfig": {
   "dependencies": {
-    "@babel/core": "^7.14.6",
-    "@babel/plugin-transform-modules-commonjs": "^7.14.5",
+    "@babel/core": "^7.25.2",
+    "@babel/plugin-transform-modules-commonjs": "^7.24.8",
     "@journeyapps/cloudcode": "1.12.0",
     "@journeyapps/cloudcode-build": "1.12.0",
-    "archiver": "^1.0.1",
-    "aws-sdk": "^2.5.2",
-    "child-process-promise": "^2.2.0",
-    "concat-stream": "^1.6.0",
-    "debug": "^2.6.0",
-    "fs-jetpack": "^0.9.2",
-    "glob": "^7.0.5",
-    "glob-promise": "^3.1.0",
-    "lodash": "^4.17.2",
-    "mkdirp": "^0.5.1",
-    "source-map-support": "^0.4.2",
-    "yargs": "17.7.1",
-    "yarn": "^1.7.0"
+    "archiver": "^7.0.1",
+    "aws-sdk": "^2.1681.0",
+    "child-process-promise": "^2.2.1",
+    "concat-stream": "^2.0.0",
+    "debug": "^4.3.6",
+    "fs-jetpack": "^5.1.0",
+    "glob": "^11.0.0",
+    "lodash": "^4.17.21",
+    "mkdirp": "^3.0.1",
+    "source-map-support": "^0.5.21",
+    "yargs": "17.7.2",
+    "yarn": "^1.22.22"
   },
   "devDependencies": {
-    "@types/node": "14.18.36",
-    "@types/yargs": "17.0.22"
+    "@types/node": "22.5.0",
+    "@types/yargs": "17.0.33"
   },
@@ -39,0 +38,0 @@ "scripts": {

No alert changes

Improved metrics

Dependency count

16

decreased by-5.88%

Worsened metrics

Total package byte prevSize

37571

decreased by-5.3%

Lines of code

548

decreased by-5.35%

Dependency changes

• + Added@isaacs/cliui@8.0.2(transitive)

• + Added@pkgjs/parseargs@0.11.0(transitive)

• + Addedabort-controller@3.0.0(transitive)

• + Addedansi-regex@6.1.0(transitive)

• + Addedansi-styles@6.2.1(transitive)

• + Addedarchiver@7.0.1(transitive)

• + Addedarchiver-utils@5.0.2(transitive)

• + Addedasync@3.2.6(transitive)

• + Addedb4a@1.6.7(transitive)

• + Addedbare-events@2.5.4(transitive)

• + Addedbrace-expansion@2.0.1(transitive)

• + Addedbuffer@6.0.3(transitive)

• + Addedbuffer-crc32@1.0.0(transitive)

• + Addedcompress-commons@6.0.2(transitive)

• + Addedconcat-stream@2.0.0(transitive)

• + Addedcrc-32@1.2.2(transitive)

• + Addedcrc32-stream@6.0.0(transitive)

• + Addedcross-spawn@7.0.6(transitive)

• + Addedeastasianwidth@0.2.0(transitive)

• + Addedemoji-regex@9.2.2(transitive)

• + Addedevent-target-shim@5.0.1(transitive)

• + Addedevents@3.3.0(transitive)

• + Addedfast-fifo@1.3.2(transitive)

• + Addedforeground-child@3.3.0(transitive)

• + Addedfs-jetpack@5.1.0(transitive)

• + Addedglob@10.4.511.0.1(transitive)

• + Addedieee754@1.2.1(transitive)

• + Addedis-stream@2.0.1(transitive)

• + Addedjackspeak@3.4.34.0.2(transitive)

• + Addedlru-cache@10.4.311.0.2(transitive)

• + Addedminimatch@10.0.15.1.69.0.5(transitive)

• + Addedminipass@7.1.2(transitive)

• + Addedmkdirp@3.0.1(transitive)

• + Addednormalize-path@3.0.0(transitive)

• + Addedpackage-json-from-dist@1.0.1(transitive)

• + Addedpath-key@3.1.1(transitive)

• + Addedpath-scurry@1.11.12.0.0(transitive)

• + Addedprocess@0.11.10(transitive)

• + Addedreadable-stream@3.6.24.7.0(transitive)

• + Addedreaddir-glob@1.1.3(transitive)

• + Addedshebang-command@2.0.0(transitive)

• + Addedshebang-regex@3.0.0(transitive)

• + Addedsignal-exit@4.1.0(transitive)

• + Addedstreamx@2.22.0(transitive)

• + Addedstring-width@5.1.2(transitive)

• + Addedstring_decoder@1.3.0(transitive)

• + Addedstrip-ansi@7.1.0(transitive)

• + Addedtar-stream@3.1.7(transitive)

• + Addedtext-decoder@1.2.3(transitive)

• + Addedwhich@2.0.2(transitive)

• + Addedwrap-ansi@8.1.0(transitive)

• + Addedyargs@17.7.2(transitive)

• + Addedzip-stream@6.0.1(transitive)

• - Removedglob-promise@^3.1.0

• - Removed@types/glob@8.1.0(transitive)

• - Removed@types/minimatch@5.1.2(transitive)

• - Removedarchiver@1.3.0(transitive)

• - Removedarchiver-utils@1.3.0(transitive)

• - Removedasync@2.6.4(transitive)

• - Removedbl@1.2.3(transitive)

• - Removedbrace-expansion@1.1.11(transitive)

• - Removedbuffer@5.7.1(transitive)

• - Removedbuffer-alloc@1.2.0(transitive)

• - Removedbuffer-alloc-unsafe@1.1.0(transitive)

• - Removedbuffer-crc32@0.2.13(transitive)

• - Removedbuffer-fill@1.0.0(transitive)

• - Removedcompress-commons@1.2.2(transitive)

• - Removedconcat-map@0.0.1(transitive)

• - Removedconcat-stream@1.6.2(transitive)

• - Removedcrc@3.8.0(transitive)

• - Removedcrc32-stream@2.0.0(transitive)

• - Removeddebug@2.6.9(transitive)

• - Removedend-of-stream@1.4.4(transitive)

• - Removedfs-constants@1.0.0(transitive)

• - Removedfs-jetpack@0.9.2(transitive)

• - Removedfs.realpath@1.0.0(transitive)

• - Removedglob@7.2.3(transitive)

• - Removedglob-promise@3.4.0(transitive)

• - Removedinflight@1.0.6(transitive)

• - Removedminimatch@3.1.2(transitive)

• - Removedminimist@1.2.8(transitive)

• - Removedmkdirp@0.5.6(transitive)

• - Removedms@2.0.0(transitive)

• - Removednormalize-path@2.1.1(transitive)

• - Removedonce@1.4.0(transitive)

• - Removedpath-is-absolute@1.0.1(transitive)

• - Removedq@1.5.1(transitive)

• - Removedremove-trailing-separator@1.1.0(transitive)

• - Removedrimraf@2.7.1(transitive)

• - Removedsource-map@0.5.7(transitive)

• - Removedsource-map-support@0.4.18(transitive)

• - Removedtar-stream@1.6.2(transitive)

• - Removedto-buffer@1.1.1(transitive)

• - Removedwalkdir@0.0.11(transitive)

• - Removedwrappy@1.0.2(transitive)

• - Removedxtend@4.0.2(transitive)

• - Removedyargs@17.7.1(transitive)

• - Removedzip-stream@1.2.0(transitive)

• Updated@babel/core@^7.25.2

• Updated@babel/plugin-transform-modules-commonjs@^7.24.8

• Updatedarchiver@^7.0.1

• Updatedaws-sdk@^2.1681.0

• Updatedchild-process-promise@^2.2.1

• Updatedconcat-stream@^2.0.0

• Updateddebug@^4.3.6

• Updatedfs-jetpack@^5.1.0

• Updatedglob@^11.0.0

• Updatedlodash@^4.17.21

• Updatedmkdirp@^3.0.1

• Updatedsource-map-support@^0.5.21

• Updatedyargs@17.7.2

• Updatedyarn@^1.22.22