@jupyterlab/application-extension - npm Package Compare versions

Comparing version 0.17.1 to 0.17.2

lib/index.js

@@ -229,5 +229,18 @@ "use strict";
         app.busySignal.connect((_, isBusy) => {
-            const filename = isBusy ? 'favicon-busy-1.ico' : 'favicon.ico';
-            const favicon = document.querySelector('link[rel="shortcut icon"]');
-            favicon.href = `/static/base/images/${filename}`;
+            const favicon = document.querySelector(`link[rel="icon"]${isBusy ? '.idle.favicon' : '.busy.favicon'}`);
+            if (!favicon) {
+                return;
+            }
+            const newFavicon = document.querySelector(`link${isBusy ? '.busy.favicon' : '.idle.favicon'}`);
+            if (!newFavicon) {
+                return;
+            }
+            // If we have the two icons with the special classes, then toggle them.
+            if (favicon !== newFavicon) {
+                favicon.rel = '';
+                newFavicon.rel = 'icon';
+                // Firefox doesn't seem to recognize just changing rel, so we also
+                // reinsert the link into the DOM.
+                newFavicon.parentNode.replaceChild(newFavicon, newFavicon);
+            }
         });
@@ -234,0 +247,0 @@ }),

package.json

 {
   "name": "@jupyterlab/application-extension",
-  "version": "0.17.1",
+  "version": "0.17.2",
   "description": "JupyterLab - Application Extension",
@@ -5,0 +5,0 @@ "homepage": "https://github.com/jupyterlab/jupyterlab",

No alert changes

Improved metrics

Total package byte prevSize

37984

increased by3.9%

Lines of code

370

increased by3.64%

No dependency changes