@jupyterlab/documentsearch - npm Package Compare versions

Comparing version 4.0.9 to 4.0.10

lib/searchmodel.d.ts

@@ -131,2 +131,3 @@ import { VDomModel } from '@jupyterlab/ui-components';
     private _updateSearch;
+    private _onProviderStateChanged;
     private _caseSensitive;
@@ -139,2 +140,3 @@ private _disposed;
     private _replaceText;
+    private _searchActive;
     private _searchDebouncer;
@@ -141,0 +143,0 @@ private _searchExpression;

lib/searchmodel.js

@@ -25,2 +25,3 @@ // Copyright (c) Jupyter Development Team.
         this._replaceText = '';
+        this._searchActive = false;
         this._searchExpression = '';
@@ -36,3 +37,3 @@ this._useRegex = false;
         }
-        searchProvider.stateChanged.connect(this.refresh, this);
+        searchProvider.stateChanged.connect(this._onProviderStateChanged, this);
         this._searchDebouncer = new Debouncer(() => {
@@ -212,3 +213,3 @@ this._updateSearch().catch(reason => {
         }
-        this.searchProvider.stateChanged.disconnect(this.refresh, this);
+        this.searchProvider.stateChanged.disconnect(this._onProviderStateChanged, this);
         this._searchDebouncer.dispose();
@@ -221,2 +222,3 @@ super.dispose();
     async endQuery() {
+        this._searchActive = false;
         await this.searchProvider.endQuery();
@@ -304,2 +306,3 @@ this.stateChanged.emit();
             if (query) {
+                this._searchActive = true;
                 await this.searchProvider.startQuery(query, this._filters);
@@ -316,2 +319,7 @@ // Emit state change as the index needs to be updated
     }
+    _onProviderStateChanged() {
+        if (this._searchActive) {
+            this.refresh();
+        }
+    }
 }
@@ -318,0 +326,0 @@ var Private;

package.json

 {
   "name": "@jupyterlab/documentsearch",
-  "version": "4.0.9",
+  "version": "4.0.10",
   "description": "JupyterLab - Document Search",
@@ -41,5 +41,5 @@ "homepage": "https://github.com/jupyterlab/jupyterlab",
   "dependencies": {
-    "@jupyterlab/apputils": "^4.1.9",
-    "@jupyterlab/translation": "^4.0.9",
-    "@jupyterlab/ui-components": "^4.0.9",
+    "@jupyterlab/apputils": "^4.1.10",
+    "@jupyterlab/translation": "^4.0.10",
+    "@jupyterlab/ui-components": "^4.0.10",
     "@lumino/coreutils": "^2.1.2",
@@ -54,3 +54,3 @@ "@lumino/disposable": "^2.1.2",
   "devDependencies": {
-    "@jupyterlab/testing": "^4.0.9",
+    "@jupyterlab/testing": "^4.0.10",
     "@types/jest": "^29.2.0",
@@ -57,0 +57,0 @@ "jest": "^29.2.0",

src/searchmodel.ts

@@ -41,3 +41,3 @@ // Copyright (c) Jupyter Development Team.
 
-    searchProvider.stateChanged.connect(this.refresh, this);
+    searchProvider.stateChanged.connect(this._onProviderStateChanged, this);
 
@@ -239,3 +239,6 @@ this._searchDebouncer = new Debouncer(() => {
 
-    this.searchProvider.stateChanged.disconnect(this.refresh, this);
+    this.searchProvider.stateChanged.disconnect(
+      this._onProviderStateChanged,
+      this
+    );
 
@@ -250,2 +253,3 @@ this._searchDebouncer.dispose();
   async endQuery(): Promise<void> {
+    this._searchActive = false;
     await this.searchProvider.endQuery();
@@ -344,2 +348,3 @@ this.stateChanged.emit();
       if (query) {
+        this._searchActive = true;
         await this.searchProvider.startQuery(query, this._filters);
@@ -359,2 +364,8 @@ // Emit state change as the index needs to be updated
 
+  private _onProviderStateChanged() {
+    if (this._searchActive) {
+      this.refresh();
+    }
+  }
+
   private _caseSensitive = false;
@@ -367,2 +378,3 @@ private _disposed = new Signal<this, void>(this);
   private _replaceText: string = '';
+  private _searchActive = false;
   private _searchDebouncer: Debouncer;
@@ -369,0 +381,0 @@ private _searchExpression = '';

No alert changes

Improved metrics

Total package byte prevSize

192385

increased by0.4%

Lines of code

4723

increased by0.45%

Published versions last year

48

increased by2.13%

Worsened metrics

Number of downloads

26715

decreased by-20.11%

Dependency changes

• Updated@jupyterlab/apputils@^4.1.10

• Updated@jupyterlab/translation@^4.0.10

• Updated@jupyterlab/ui-components@^4.0.10