@jupyterlab/inspector - npm Package Compare versions

Comparing version 0.8.2 to 0.9.0

lib/handler.d.ts

@@ -34,3 +34,3 @@ import { IDisposable } from '@phosphor/disposable';
      */
-    editor: CodeEditor.IEditor;
+    editor: CodeEditor.IEditor | null;
     /**
@@ -69,2 +69,3 @@ * Indicates whether the handler makes API inspection requests or stands by.
     private _standby;
+    private _isDisposed;
 }
@@ -71,0 +72,0 @@ /**

lib/handler.js

@@ -21,4 +21,4 @@ "use strict";
         this._pending = 0;
-        this._rendermime = null;
         this._standby = true;
+        this._isDisposed = false;
         this.session = options.session;
@@ -106,3 +106,3 @@ this._rendermime = options.rendermime;
         get: function () {
-            return this._editor === null;
+            return this._isDisposed;
         },
@@ -116,7 +116,6 @@ enumerable: true,
     InspectionHandler.prototype.dispose = function () {
-        if (this._editor === null) {
+        if (this.isDisposed) {
             return;
         }
-        this._editor = null;
-        this._rendermime = null;
+        this._isDisposed = true;
         this._disposed.emit(void 0);
@@ -138,2 +137,5 @@ signaling_1.Signal.clearData(this);
         var editor = this.editor;
+        if (!editor) {
+            return;
+        }
         var code = editor.model.value.text;
@@ -140,0 +142,0 @@ var position = editor.getCursorPosition();

lib/inspector.d.ts

@@ -26,3 +26,3 @@ import { Token } from '@phosphor/coreutils';
      */
-    source: IInspector.IInspectable;
+    source: IInspector.IInspectable | null;
 }
@@ -93,3 +93,3 @@ /**
          */
-        content: Widget;
+        content: Widget | null;
         /**
@@ -112,3 +112,3 @@ * The type of the inspector being updated.
      */
-    source: IInspector.IInspectable;
+    source: IInspector.IInspectable | null;
     /**
@@ -115,0 +115,0 @@ * Create an inspector child item and return a disposable to remove it.

lib/inspector.js

@@ -83,5 +83,3 @@ "use strict";
             // Clear the inspector child items (but maintain history) if necessary.
-            if (this._items) {
-                Object.keys(this._items).forEach(function (i) { return _this._items[i].content = null; });
-            }
+            Object.keys(this._items).forEach(function (i) { return _this._items[i].content = null; });
             this._source = source;
@@ -141,12 +139,9 @@ // Connect new signal handler.
     InspectorPanel.prototype.dispose = function () {
-        if (this._items == null) {
+        if (this.isDisposed) {
             return;
         }
+        this.source = null;
         var items = this._items;
-        this._items = null;
-        this.source = null;
         // Dispose the inspector child items.
-        if (items) {
-            Object.keys(items).forEach(function (i) { items[i].dispose(); });
-        }
+        Object.keys(items).forEach(function (i) { items[i].dispose(); });
         _super.prototype.dispose.call(this);
@@ -192,3 +187,3 @@ };
         var lowest = Infinity;
-        widget = null;
+        var newWidget = null;
         for (var type in items) {
@@ -198,7 +193,7 @@ var inspector = this._items[type];
                 lowest = inspector.rank;
-                widget = inspector;
+                newWidget = inspector;
             }
         }
-        if (widget) {
-            this.currentWidget = widget;
+        if (newWidget) {
+            this.currentWidget = newWidget;
         }
@@ -226,7 +221,6 @@ };
         _this._content = null;
-        _this._history = null;
+        _this._history = [];
         _this._index = -1;
         _this._rank = Infinity;
         _this._remembers = false;
-        _this._toolbar = null;
         _this.layout = new widgets_1.PanelLayout();
@@ -258,5 +252,5 @@ _this.addClass(ITEM_CLASS);
             this._content = newValue;
-            if (this._content) {
-                this._content.addClass(CONTENT_CLASS);
-                this.layout.addWidget(this._content);
+            if (newValue) {
+                newValue.addClass(CONTENT_CLASS);
+                this.layout.addWidget(newValue);
                 if (this.remembers) {
@@ -282,6 +276,5 @@ this._history.push(newValue);
             }
-            this._clear();
             this._remembers = newValue;
-            if (!this._remembers) {
-                this._history = null;
+            if (!newValue) {
+                this._clear();
             }
@@ -310,13 +303,7 @@ this.update();
     InspectorItem.prototype.dispose = function () {
-        if (this._toolbar === null) {
+        if (this.isDisposed) {
             return;
         }
-        var toolbar = this._toolbar;
-        var history = this._history;
-        this._toolbar = null;
-        this._history = null;
-        if (history) {
-            history.forEach(function (widget) { return widget.dispose(); });
-        }
-        toolbar.dispose();
+        this._history.forEach(function (widget) { return widget.dispose(); });
+        this._toolbar.dispose();
         _super.prototype.dispose.call(this);
@@ -336,5 +323,3 @@ };
     InspectorItem.prototype._clear = function () {
-        if (this._history) {
-            this._history.forEach(function (widget) { return widget.dispose(); });
-        }
+        this._history.forEach(function (widget) { return widget.dispose(); });
         this._history = [];
@@ -341,0 +326,0 @@ this._index = -1;

package.json

 {
   "name": "@jupyterlab/inspector",
-  "version": "0.8.2",
+  "version": "0.9.0",
   "description": "JupyterLab - Code Inspector",
@@ -16,7 +16,7 @@ "main": "lib/index.js",
   "dependencies": {
-    "@jupyterlab/apputils": "^0.8.2",
-    "@jupyterlab/codeeditor": "^0.8.1",
-    "@jupyterlab/coreutils": "^0.8.1",
-    "@jupyterlab/rendermime": "^0.8.2",
-    "@jupyterlab/services": "^0.47.1",
+    "@jupyterlab/apputils": "^0.9.0",
+    "@jupyterlab/codeeditor": "^0.9.0",
+    "@jupyterlab/coreutils": "^0.9.0",
+    "@jupyterlab/rendermime": "^0.9.0",
+    "@jupyterlab/services": "^0.48.0",
     "@phosphor/coreutils": "^1.2.0",
@@ -23,0 +23,0 @@ "@phosphor/disposable": "^1.1.1",

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Worsened metrics

Total package byte prevSize

29096

decreased by-1.12%

Lines of code

876

decreased by-1.35%

Dependency changes

• + Added@jupyterlab/apputils@0.9.0(transitive)

• + Added@jupyterlab/codeeditor@0.9.0(transitive)

• + Added@jupyterlab/codemirror@0.9.0(transitive)

• + Added@jupyterlab/coreutils@0.9.0(transitive)

• + Added@jupyterlab/rendermime@0.9.0(transitive)

• + Added@jupyterlab/rendermime-interfaces@0.3.1(transitive)

• + Added@jupyterlab/services@0.48.0(transitive)

• - Removed@jupyterlab/apputils@0.8.2(transitive)

• - Removed@jupyterlab/codeeditor@0.8.1(transitive)

• - Removed@jupyterlab/codemirror@0.8.1(transitive)

• - Removed@jupyterlab/coreutils@0.8.1(transitive)

• - Removed@jupyterlab/rendermime@0.8.2(transitive)

• - Removed@jupyterlab/rendermime-interfaces@0.2.1(transitive)

• - Removed@jupyterlab/services@0.47.1(transitive)

• Updated@jupyterlab/apputils@^0.9.0

• Updated@jupyterlab/codeeditor@^0.9.0

• Updated@jupyterlab/coreutils@^0.9.0

• Updated@jupyterlab/rendermime@^0.9.0

• Updated@jupyterlab/services@^0.48.0