@justeat/f-footer - npm Package Compare versions

Comparing version 7.7.1 to 7.7.2

CHANGELOG.md

@@ -7,2 +7,13 @@ # Changelog
 
+v7.7.2
+------------------------------
+*Jun 6, 2022*
+
+### Changed
+- Refactor WebDriverIO tests to use async in order to support Node 16 using `codemod` utility.
+
+### Removed
+- DK & NO config + tests
+
+
 v7.7.1
@@ -9,0 +20,0 @@ ------------------------------

package.json

 {
   "name": "@justeat/f-footer",
-  "version": "7.7.1",
+  "version": "7.7.2",
   "main": "dist/f-footer.umd.min.js",
@@ -65,3 +65,3 @@ "maxBundleSize": "80kB",
   },
-  "gitHead": "0a90e4d79272cb00067ac77ec11d61ea2fc75a74"
+  "gitHead": "aad81e7d6cfe207369f5fa0922d91ad88835bc71"
 }

test-utils/component-objects/f-footer.component.js

 const Page = require('@justeat/f-wdio-utils/src/page.object');
 const {
     FOOTER_COMPONENT,
-    DOWNLOAD_ICONS,
-    SOCIAL_ICONS,
     COUNTRY_SELECTOR_BUTTON,
-    COUNTRY_LIST,
+    COUNTRY_LINK,
     FEEDBACK_BUTTON,
+    FOOTER_ICON,
     FOOTER_LINK_LIST
@@ -19,10 +18,2 @@ } = require('./f-footer.selectors');
 
-    get downloadIcons () { return $$(DOWNLOAD_ICONS); }
-
-    get socialIcons () { return $$(SOCIAL_ICONS); }
-
-    get downloadIcon () { return this.downloadIconValue; }
-
-    get socialIcon () { return this.socialIconValue; }
-
     get feedbackButton () { return $(FEEDBACK_BUTTON); }
@@ -32,51 +23,36 @@
 
-    get countries () { return $$(COUNTRY_LIST); }
-
     get footerLinkList () { return $(FOOTER_LINK_LIST); }
 
-    get countryLink () { return this.countryValue != null ? this.countryValue : 'Please set a country value'; }
-
-    set expectedDownloadIcon (icon) {
-        [this.downloadIconValue] = this.downloadIcons.filter(element => element.getAttribute('data-test-id').includes(icon));
+    async load () {
+        await super.load(this.component);
     }
 
-    set expectedSocialIcon (icon) {
-        [this.socialIconValue] = this.socialIcons.filter(element => element.getAttribute('data-test-id').includes(icon));
+    async waitForComponent () {
+        await super.waitForComponent(this.component);
     }
 
-    set expectedCountry (country) {
-        [this.countryValue] = this.countries.filter(element => element.getAttribute('data-test-id').includes(country));
-    }
-
-    load () {
-        super.load(this.component);
-    }
-
-    waitForComponent () {
-        super.waitForComponent(this.component);
-    }
-
-    isComponentDisplayed () {
+    async isComponentDisplayed () {
         return this.component.isDisplayed();
     }
 
-    clickDownloadIcon () {
-        return this.downloadIcon.click();
-    }
+    async clickIcon (icon) {
+        const footerIcon = await $(`[${FOOTER_ICON}${icon}"]`);
 
-    clickSocialIcon () {
-        return this.socialIcon.click();
+        return footerIcon.click();
     }
 
-    isFeedbackButtonClickable () {
+    async isFeedbackButtonClickable () {
         return this.feedbackButton.isClickable();
     }
 
-    clickCountrySelectorButton () {
-        return this.countrySelectorButton.click();
+    async clickCountrySelectorButton () {
+        const countrySelectorButton = await this.countrySelectorButton;
+        return countrySelectorButton.click();
     }
 
-    clickCountryLinkItem () {
-        return this.countryLink.click();
+    async clickCountryLinkItem (country) {
+        const countryLink = await $(`[${COUNTRY_LINK}${country}"]`);
+
+        return countryLink.click();
     }
 };

test-utils/component-objects/f-footer.selectors.js

 export const FOOTER_COMPONENT = '[data-test-id="footer-component"]';
-export const DOWNLOAD_ICONS = '[data-test-id="icon-list-apps"] a';
-export const SOCIAL_ICONS = '[data-test-id="icon-list-social"] a';
 export const FEEDBACK_BUTTON = '[data-test-id="feedback-button"]';
 export const COUNTRY_SELECTOR_BUTTON = '[data-test-id="countrySelector-button"]';
-export const COUNTRY_LIST = '[data-test-id="countrySelector-list"] li';
+export const COUNTRY_LINK = 'data-test-id="countrySelector-country-';
+export const FOOTER_ICON = 'data-test-id="footerIcon ';
 export const FOOTER_LINK_LIST = '[data-test-id="footer-link-list"]';

No alert changes

Worsened metrics

Total package byte prevSize

12966834

decreased by-0.18%

Lines of code

50136

decreased by-0.43%

No dependency changes