@justeattakeaway/pie-card - npm Package Compare versions

Comparing version 0.21.2 to 0.21.3

custom-elements.json

@@ -91,5 +91,2 @@ {
               "name": "tag",
-              "type": {
-                "text": "CardProps['tag']"
-              },
               "privacy": "public",
@@ -101,5 +98,2 @@ "attribute": "tag"
               "name": "variant",
-              "type": {
-                "text": "CardProps['variant']"
-              },
               "privacy": "public",
@@ -112,3 +106,3 @@ "attribute": "variant"
               "type": {
-                "text": "string | undefined"
+                "text": "CardProps['href']"
               },
@@ -123,3 +117,3 @@ "privacy": "public",
               "type": {
-                "text": "string | undefined"
+                "text": "CardProps['target']"
               },
@@ -134,3 +128,3 @@ "privacy": "public",
               "type": {
-                "text": "string | undefined"
+                "text": "CardProps['rel']"
               },
@@ -151,3 +145,3 @@ "privacy": "public",
               "type": {
-                "text": "CardProps['aria'] | undefined"
+                "text": "CardProps['aria']"
               },
@@ -167,3 +161,3 @@ "privacy": "public",
               "type": {
-                "text": "CardProps['padding'] | undefined"
+                "text": "CardProps['padding']"
               },
@@ -264,5 +258,2 @@ "privacy": "public",
               "name": "tag",
-              "type": {
-                "text": "CardProps['tag']"
-              },
               "fieldName": "tag"
@@ -272,5 +263,2 @@ },
               "name": "variant",
-              "type": {
-                "text": "CardProps['variant']"
-              },
               "fieldName": "variant"
@@ -281,3 +269,3 @@ },
               "type": {
-                "text": "string | undefined"
+                "text": "CardProps['href']"
               },
@@ -289,3 +277,3 @@ "fieldName": "href"
               "type": {
-                "text": "string | undefined"
+                "text": "CardProps['target']"
               },
@@ -297,3 +285,3 @@ "fieldName": "target"
               "type": {
-                "text": "string | undefined"
+                "text": "CardProps['rel']"
               },
@@ -309,3 +297,3 @@ "fieldName": "rel"
               "type": {
-                "text": "CardProps['aria'] | undefined"
+                "text": "CardProps['aria']"
               },
@@ -321,3 +309,3 @@ "fieldName": "aria"
               "type": {
-                "text": "CardProps['padding'] | undefined"
+                "text": "CardProps['padding']"
               },
@@ -324,0 +312,0 @@ "fieldName": "padding"

dist/index.d.ts

@@ -7,3 +7,3 @@ import { ComponentDefaultProps } from '@justeattakeaway/pie-webc-core';
 
-export declare type AriaProps = {
+declare type AriaProps = {
     label?: string;
@@ -65,11 +65,11 @@ };
 export declare class PieCard extends LitElement implements CardProps {
-    tag: CardProps['tag'];
-    variant: CardProps['variant'];
-    href?: string;
-    target?: string;
-    rel?: string;
+    tag: "a" | "button";
+    variant: "default" | "outline" | "inverse" | "outline-inverse";
+    href: CardProps['href'];
+    target: CardProps['target'];
+    rel: CardProps['rel'];
     disabled: boolean;
-    aria?: CardProps['aria'];
+    aria: CardProps['aria'];
     isDraggable: boolean;
-    padding?: CardProps['padding'];
+    padding: CardProps['padding'];
     private assignedElements?;
@@ -76,0 +76,0 @@ private onClickHandler;

dist/index.js

@@ -140,7 +140,7 @@ import { LitElement as S, html as u, nothing as g, unsafeCSS as $ } from "lit";
 c([
-  d(),
+  d({ type: String }),
   b(p, O, s.tag)
 ], t.prototype, "tag");
 c([
-  d(),
+  d({ type: String }),
   b(p, E, s.variant)
@@ -147,0 +147,0 @@ ], t.prototype, "variant");

dist/react.d.ts

@@ -8,3 +8,3 @@ import { ComponentDefaultProps } from '@justeattakeaway/pie-webc-core';
 
-export declare type AriaProps = {
+declare type AriaProps = {
     label?: string;
@@ -68,11 +68,11 @@ };
 declare class PieCard_2 extends LitElement implements CardProps {
-    tag: CardProps['tag'];
-    variant: CardProps['variant'];
-    href?: string;
-    target?: string;
-    rel?: string;
+    tag: "a" | "button";
+    variant: "default" | "outline" | "inverse" | "outline-inverse";
+    href: CardProps['href'];
+    target: CardProps['target'];
+    rel: CardProps['rel'];
     disabled: boolean;
-    aria?: CardProps['aria'];
+    aria: CardProps['aria'];
     isDraggable: boolean;
-    padding?: CardProps['padding'];
+    padding: CardProps['padding'];
     private assignedElements?;
@@ -79,0 +79,0 @@ private onClickHandler;

package.json

 {
   "name": "@justeattakeaway/pie-card",
-  "version": "0.21.2",
+  "version": "0.21.3",
   "description": "PIE Design System Card built using Web Components",
@@ -5,0 +5,0 @@ "type": "module",

src/defs.ts

@@ -11,3 +11,3 @@ import { type ComponentDefaultProps } from '@justeattakeaway/pie-webc-core';
 
-export type AriaProps = {
+type AriaProps = {
     label?: string;
@@ -14,0 +14,0 @@ };

src/index.ts

@@ -26,18 +26,18 @@ import {
 export class PieCard extends LitElement implements CardProps {
-    @property()
+    @property({ type: String })
     @validPropertyValues(componentSelector, tags, defaultProps.tag)
-    public tag: CardProps['tag'] = defaultProps.tag;
+    public tag = defaultProps.tag;
 
-    @property()
+    @property({ type: String })
     @validPropertyValues(componentSelector, variants, defaultProps.variant)
-    public variant: CardProps['variant'] = defaultProps.variant;
+    public variant = defaultProps.variant;
 
     @property({ type: String, reflect: true })
-    public href?: string;
+    public href: CardProps['href'];
 
     @property({ type: String, reflect: true })
-    public target?: string;
+    public target: CardProps['target'];
 
     @property({ type: String, reflect: true })
-    public rel?: string;
+    public rel: CardProps['rel'];
 
@@ -48,3 +48,3 @@ @property({ type: Boolean })
     @property({ type: Object })
-    public aria?: CardProps['aria'];
+    public aria: CardProps['aria'];
 
@@ -56,3 +56,3 @@ @property({ type: Boolean })
     @validPropertyValues(componentSelector, paddingValues, undefined)
-    public padding?: CardProps['padding'];
+    public padding: CardProps['padding'];
 
@@ -59,0 +59,0 @@ @queryAssignedElements({ flatten: true })

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Worsened metrics

Total package byte prevSize

42087

decreased by-0.58%

Lines of code

1048

decreased by-1.13%

No dependency changes