@knight-lab/timelinejs - npm Package Compare versions

Comparing version 3.9.1 to 3.9.2

CHANGELOG.md

@@ -0,1 +1,7 @@
+3.9.2 (2023-02-07)
+-------------------------
+* #796 support Wikipedia image page URLs
+* #808 Add support for en-GB locale (UK-style date formatting, eg 2 Dec 2022)
+* #814 Ensure that buttons are created with type="button"
+
 3.9.1 (2022-11-29)
@@ -2,0 +8,0 @@ -------------------------

CONTRIBUTING.md

@@ -29,2 +29,7 @@ # Contributing to TimelineJS
 
+### Building
+
+In order to "compile" TimelineJS for use in other contexts, after following the instructions above, run the command `npm run dist`. This will populate a directory, `dist/` in the rool of your checked-out repository, with the javascript and CSS necessary to self-host TimelineJS.
+
+
 ### Testing
@@ -31,0 +36,0 @@

dist/js/locale/es.json

@@ -57,3 +57,3 @@ {
         "return_to_title": "Volver al título",
-        "swipe_nav": "Desliza para ver",
+        "swipe_to_navigate": "Desliza para ver<br><span class='tl-button'>OK</span>",
         "wikipedia": "Desde Wikipedia, la enciclopedia libre",
@@ -60,0 +60,0 @@ "loading_content": "cargando",

dist/js/locale/hi.json

@@ -57,3 +57,2 @@ {
         "return_to_title": "शीर्षक पर लौटें",
-        "swipe_nav": "Swipe to Navigate",
         "read_more": "और पढ़ें",
@@ -60,0 +59,0 @@ "wikipedia": "विकिपीडिया, मुक्त विश्वकोश से",

package.json

 {
     "name": "@knight-lab/timelinejs",
-    "version": "3.9.1",
+    "version": "3.9.2",
     "license": "MPL-2.0",
@@ -62,3 +62,4 @@ "description": "TimelineJS v3: A Storytelling Timeline built in JavaScript, made by Northwestern University Knight Lab.",
     },
-    "contributors": [{
+    "contributors": [
+        {
             "name": "Zach Wise",
@@ -74,2 +75,2 @@ "email": "[e-mail]",
     ]
-}
+}

src/js/dom/DOM.js

@@ -22,2 +22,8 @@ import * as Browser from "../core/Browser"
 
+function createButton(className, container) {
+	var el = create('button', className, container);
+	el.type = 'button';
+	return el;
+}
+
 function createText(content, container) {
@@ -82,2 +88,2 @@ var el = document.createTextNode(content);
 
-export { get, create, getPosition }
+export { get, create, createButton, getPosition }

src/js/language/Language.js

@@ -321,2 +321,3 @@ import { mergeData, pad, trace } from "../core/Util"
             wikipedia_load_err: "Unable to load Wikipedia entry",
+            wikipedia_image_load_err: "Unable to load Wikipedia image data",
             spotify_invalid_url: "Invalid Spotify URL",
@@ -323,0 +324,0 @@ invalid_rgb_err: "Invalid RGB argument",

src/js/language/locale/es.json

@@ -57,3 +57,3 @@ {
         "return_to_title": "Volver al título",
-        "swipe_nav": "Desliza para ver",
+        "swipe_to_navigate": "Desliza para ver<br><span class='tl-button'>OK</span>",
         "wikipedia": "Desde Wikipedia, la enciclopedia libre",
@@ -60,0 +60,0 @@ "loading_content": "cargando",

src/js/language/locale/hi.json

@@ -57,3 +57,2 @@ {
         "return_to_title": "शीर्षक पर लौटें",
-        "swipe_nav": "Swipe to Navigate",
         "read_more": "और पढ़ें",
@@ -60,0 +59,0 @@ "wikipedia": "विकिपीडिया, मुक्त विश्वकोश से",

src/js/media/MediaType.js

@@ -18,2 +18,3 @@ /*
 import Wikipedia from "./types/Wikipedia"
+import WikipediaImage from "./types/WikipediaImage"
 import SoundCloud from "./types/SoundCloud"
@@ -138,2 +139,20 @@ import Vimeo from "./types/Vimeo"
             {
+                type: "wikipedia-image",
+                name: "WikipediaImage",
+                match_str: "^https:\/\/.+\.wiki[mp]edia\.org.+#/media/.+\.(jpg|jpeg|png|gif|svg|webp)",
+                cls: WikipediaImage
+            },
+            {
+                type: "wikipedia-image",
+                name: "WikipediaImage",
+                match_str: "^https:\/\/commons.wikimedia.org/wiki/File:.+\.(jpg|jpeg|png|gif|svg|webp)",
+                cls: WikipediaImage
+            },
+            {
+                type: "wikipedia",
+                name: "Wikipedia",
+                match_str: "^(https?:)?\/.+.wikipedia\.org",
+                cls: Wikipedia
+            },
+            {
                 type: "image",
@@ -163,8 +182,2 @@ name: "Image",
             {
-                type: "wikipedia",
-                name: "Wikipedia",
-                match_str: "^(https?:)?\/*(www.)?wikipedia\.org|^(https?:)?\/*([a-z][a-z].)?wikipedia\.org",
-                cls: Wikipedia
-            },
-            {
                 type: "spotify",
@@ -171,0 +184,0 @@ name: "spotify",

src/js/slider/SlideNav.js

@@ -42,3 +42,3 @@ import Events from "../core/Events";
 		
-		this._el.container = DOM.create("button", "tl-slidenav-" + this.options.direction);
+		this._el.container = DOM.createButton("tl-slidenav-" + this.options.direction);
 		
@@ -45,0 +45,0 @@ if (Browser.mobile) {

src/js/ui/MenuBar.js

@@ -157,6 +157,6 @@ import * as DOM from "../dom/DOM"
         // Create Layout
-        this._el.button_zoomin = DOM.create('button', 'tl-menubar-button', this._el.container);
-        this._el.button_zoomout = DOM.create('button', 'tl-menubar-button', this._el.container);
-        this._el.button_forwardtoend = DOM.create('button', 'tl-menubar-button', this._el.container);
-        this._el.button_backtostart = DOM.create('button', 'tl-menubar-button', this._el.container);
+        this._el.button_zoomin = DOM.createButton('tl-menubar-button', this._el.container);
+        this._el.button_zoomout = DOM.createButton('tl-menubar-button', this._el.container);
+        this._el.button_forwardtoend = DOM.createButton('tl-menubar-button', this._el.container);
+        this._el.button_backtostart = DOM.createButton('tl-menubar-button', this._el.container);
 
@@ -163,0 +163,0 @@ if (Browser.mobile) {

src/template/all-media-types.json

@@ -389,3 +389,2 @@ {
 
-
         {
@@ -565,5 +564,32 @@ "media": {
             "group": "Video"
+        },
+        {
+            "media": {
+                "url": "https://de.wikipedia.org/wiki/Beryllium#/media/Datei:Beryl-Quartz-Emerald-Zambia-33mm_0885.jpg",
+                "credit": "Wikipedia"
+            },
+            "start_date": {
+                "year": "1929"
+            },
+            "text": {
+                "headline": "Wikimedia Images",
+                "text": "Given a link to a wikipedia page about an image, extract best the Wikimedia image URL and use it for the media."
+            },
+            "group": "Image"
+        },
+        {
+            "media": {
+                "url": "https://commons.wikimedia.org/wiki/File:David-Bowie_Chicago_2002-08-08_photoby_Adam-Bielawski-cropped.jpg",
+                "credit": "Wikipedia"
+            },
+            "start_date": {
+                "year": "1930"
+            },
+            "text": {
+                "headline": "Wikimedia Commons Image links",
+                "text": "Given a link to a wikipedia page about an image, extract best the Wikimedia image URL and use it for the media."
+            },
+            "group": "Image"
         }
-
     ]
 }

No alert changes

Improved metrics

Total package byte prevSize

3393542

increased by0.92%

Number of package files

342

increased by1.48%

Lines of code

49477

increased by0.85%

No dependency changes