@koopjs/winnow - npm Package Compare versions

Comparing version 5.0.0 to 5.0.1

package.json

 {
   "name": "@koopjs/winnow",
-  "version": "5.0.0",
+  "version": "5.0.1",
   "description": "Apply sql-like filters to GeoJSON",
@@ -5,0 +5,0 @@ "main": "src/index.js",

src/filter-and-transform/transforms/to-esri-attributes.js

@@ -13,4 +13,6 @@ const _ = require('lodash');
     properties = injectObjectId({ properties, geometry });
-  } else if (requiresObjectId && shouldLogIdFieldWarning(properties[idField])) {
-    logManager.logger.debug(`Unique-identifier (\`${idField}\`) has a value (${properties[idField]}) that is not a valid integer (0 to ${Number.MAX_SAFE_INTEGER}); this may cause problems in some clients.`);
+  } else if (requiresObjectId && shouldLogIdFieldDataTypeWarning(properties[idField])) {
+    logManager.logger.debug(`Unique-identifier ("${idField}") has a value (${properties[idField]}) that is not an integer-type, it is a ${typeof properties[idField]}; this may cause problems in some clients.`);
+  } else if (requiresObjectId && shouldLogIdFieldRangeWarning(properties[idField])) {
+    logManager.logger.debug(`Unique-identifier ("${idField}") has a value (${properties[idField]}) that is not a valid integer range (0 to ${Number.MAX_SAFE_INTEGER}); this may cause problems in some clients.`);
   }
@@ -30,6 +32,10 @@
 
-function shouldLogIdFieldWarning (idFieldValue) {
-  return idFieldValue && (!Number.isInteger(idFieldValue) || idFieldValue > Number.MAX_SAFE_INTEGER);
+function shouldLogIdFieldDataTypeWarning (idFieldValue) {
+  return idFieldValue && !Number.isInteger(idFieldValue);
 }
 
+function shouldLogIdFieldRangeWarning (idFieldValue) {
+  return idFieldValue && (idFieldValue < 0 || idFieldValue > Number.MAX_SAFE_INTEGER);
+}
+
 function transformProperties (properties, dateFields) {
@@ -36,0 +42,0 @@ return Object.entries(properties).reduce((transformedProperties, [key, value]) => {

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

86878

increased by0.48%

Lines of code

2086

increased by0.24%

No dependency changes