@ledgerhq/hw-app-btc - npm Package Compare versions

Comparing version 3.1.0-beta.7e23155d to 3.1.0-beta.da8a3a7f

lib/Btc.js

@@ -451,3 +451,3 @@ "use strict";
      * @param segwit is a boolean indicating wether to use segwit or not
-     * @param initialTimestamp is the timestamp in ms when the function is called, not the one that the tx will include
+     * @param initialTimestamp is the timestamp when the function is called, not the one that the tx will include
      * @return the signed transaction ready to be broadcast
@@ -538,3 +538,3 @@ * @example
           targetTransaction.timestamp = Buffer.alloc(4);
-          targetTransaction.timestamp.writeUInt32LE(Math.floor((initialTimestamp + (Date.now() - startTime)) / 1000), 0);
+          targetTransaction.timestamp.writeUInt32LE(Math.floor(initialTimestamp + (Date.now() - startTime) / 1000), 0);
         }
@@ -582,2 +582,3 @@ }).then(function () {
           if (segwit) {
+            targetTransaction.witness = Buffer.alloc(0);
             targetTransaction.inputs[_i].script = Buffer.concat([Buffer.from("160014", "hex"), _this5.hashPublicKey(publicKeys[_i])]);
@@ -594,3 +595,2 @@ } else {
         }
-        targetTransaction.witness = Buffer.alloc(0);
 
@@ -597,0 +597,0 @@ var lockTimeBuffer = Buffer.alloc(4);

package.json

 {
   "name": "@ledgerhq/hw-app-btc",
-  "version": "3.1.0-beta.7e23155d",
+  "version": "3.1.0-beta.da8a3a7f",
   "description": "Ledger Hardware Wallet Bitcoin Application API",
@@ -28,3 +28,3 @@ "keywords": [
   "dependencies": {
-    "@ledgerhq/hw-transport": "^3.1.0-beta.7e23155d",
+    "@ledgerhq/hw-transport": "^3.1.0-beta.da8a3a7f",
     "create-hash": "^1.1.3"
@@ -31,0 +31,0 @@ },

src/Btc.js

@@ -464,3 +464,3 @@ //@flow
    * @param segwit is a boolean indicating wether to use segwit or not
-   * @param initialTimestamp is the timestamp in ms when the function is called, not the one that the tx will include
+   * @param initialTimestamp is the timestamp when the function is called, not the one that the tx will include
    * @return the signed transaction ready to be broadcast
@@ -562,3 +562,3 @@ * @example
           targetTransaction.timestamp.writeUInt32LE(
-            Math.floor((initialTimestamp + (Date.now() - startTime)) / 1000),
+            Math.floor(initialTimestamp + (Date.now() - startTime) / 1000),
             0
@@ -625,2 +625,3 @@ );
           if (segwit) {
+            targetTransaction.witness = Buffer.alloc(0);
             targetTransaction.inputs[i].script = Buffer.concat([
@@ -648,3 +649,2 @@ Buffer.from("160014", "hex"),
         }
-        targetTransaction.witness = Buffer.alloc(0);
 
@@ -651,0 +651,0 @@ const lockTimeBuffer = Buffer.alloc(4);

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Worsened metrics

Total package byte prevSize

192917

decreased by-0.01%

Dependency changes

• Updated@ledgerhq/hw-transport@^3.1.0-beta.da8a3a7f