@ledgerhq/hw-app-btc - npm Package Compare versions

Comparing version 4.33.5 to 4.33.6

lib/Btc.js

@@ -626,3 +626,6 @@ "use strict";
         return (0, _utils.doIf)(!!expiryHeight && !isDecred, function () {
-          return _this5.signTransaction("", undefined, SIGHASH_ALL, expiryHeight);
+          return (
+            // FIXME: I think we should always pass lockTime here.
+            _this5.signTransaction("", lockTime, SIGHASH_ALL, expiryHeight)
+          );
         });
@@ -691,2 +694,9 @@ }).then(function () {
         }
+
+        // FIXME: In ZEC or KMD sapling lockTime is serialized before expiryHeight.
+        // expiryHeight is used only in overwinter/sapling so I moved lockTimeBuffer here
+        // and it should not break other coins because expiryHeight is false for them.
+        // Don't know about Decred though.
+        result = Buffer.concat([result, lockTimeBuffer]);
+
         if (expiryHeight) {
@@ -696,4 +706,2 @@ result = Buffer.concat([result, targetTransaction.nExpiryHeight || Buffer.alloc(0), targetTransaction.extraData || Buffer.alloc(0)]);
 
-        result = Buffer.concat([result, lockTimeBuffer]);
-
         if (isDecred) {
@@ -700,0 +708,0 @@ var decredWitness = Buffer.from([targetTransaction.inputs.length]);

package.json

 {
   "name": "@ledgerhq/hw-app-btc",
-  "version": "4.33.5",
+  "version": "4.33.6",
   "description": "Ledger Hardware Wallet Bitcoin Application API",
@@ -5,0 +5,0 @@ "keywords": [

src/Btc.js

@@ -745,3 +745,4 @@ //@flow
         doIf(!!expiryHeight && !isDecred, () =>
-          this.signTransaction("", undefined, SIGHASH_ALL, expiryHeight)
+          // FIXME: I think we should always pass lockTime here.
+          this.signTransaction("", lockTime, SIGHASH_ALL, expiryHeight)
         )
@@ -860,2 +861,9 @@ )
         }
+
+        // FIXME: In ZEC or KMD sapling lockTime is serialized before expiryHeight.
+        // expiryHeight is used only in overwinter/sapling so I moved lockTimeBuffer here
+        // and it should not break other coins because expiryHeight is false for them.
+        // Don't know about Decred though.
+        result = Buffer.concat([result, lockTimeBuffer]);
+
         if (expiryHeight) {
@@ -869,4 +877,2 @@ result = Buffer.concat([
 
-        result = Buffer.concat([result, lockTimeBuffer]);
-
         if (isDecred) {
@@ -873,0 +879,0 @@ let decredWitness = Buffer.from([targetTransaction.inputs.length]);

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

235984

increased by0.65%

Lines of code

2469

increased by0.49%

No dependency changes