@lightningjs/solid - npm Package Compare versions

Comparing version 0.14.3 to 0.14.4

dist/esm/index.js

@@ -97,3 +97,4 @@ import { createSignal, mergeProps as mergeProps$1, createRoot, createRenderEffect, createMemo, createComponent as createComponent$1, untrack, splitProps } from 'solid-js';
       this.splice(nodeIndexToRemove, 1);
-      node.parent = undefined;
+      // Dont remove from parent as that causes extra work
+      node._queueDelete = true;
     }
@@ -634,11 +635,2 @@ }
         } = loadedPayload;
-        if (dimensions.width === this.width && dimensions.height === this.height) {
-          return;
-        }
-        if (this.contain === 'width') {
-          this.height = dimensions.height;
-        } else {
-          this.width = dimensions.width;
-          this.height = dimensions.height;
-        }
         this.parent.updateLayout(this, dimensions);
@@ -652,3 +644,3 @@ }
   destroy() {
-    if (this.lng && !this.parent) {
+    if (this.lng && this._queueDelete) {
       this.lng.destroy();
@@ -1208,2 +1200,3 @@ }
       parent.children.insert(node, anchor);
+      node._queueDelete = false;
       if (node.name === 'TextNode') {
@@ -1210,0 +1203,0 @@ // TextNodes can be placed outside of <text> nodes when <Show> is used as placeholder

dist/source/core/node/children.js

@@ -48,5 +48,6 @@ /*
             this.splice(nodeIndexToRemove, 1);
-            node.parent = undefined;
+            // Dont remove from parent as that causes extra work
+            node._queueDelete = true;
         }
     }
 }

dist/source/core/node/index.js

@@ -113,2 +113,3 @@ /*
     autofocus;
+    _queueDelete;
     forwardFocus;
@@ -318,13 +319,2 @@ _undoStyles;
                 const { dimensions } = loadedPayload;
-                if (dimensions.width === this.width &&
-                    dimensions.height === this.height) {
-                    return;
-                }
-                if (this.contain === 'width') {
-                    this.height = dimensions.height;
-                }
-                else {
-                    this.width = dimensions.width;
-                    this.height = dimensions.height;
-                }
                 this.parent.updateLayout(this, dimensions);
@@ -338,3 +328,3 @@ }
     destroy() {
-        if (this.lng && !this.parent) {
+        if (this.lng && this._queueDelete) {
             this.lng.destroy();
@@ -341,0 +331,0 @@ }

dist/source/core/universal/lightning.js

@@ -59,2 +59,3 @@ /*
             parent.children.insert(node, anchor);
+            node._queueDelete = false;
             if (node.name === 'TextNode') {
@@ -61,0 +62,0 @@ // TextNodes can be placed outside of <text> nodes when <Show> is used as placeholder

dist/types/core/node/index.d.ts

@@ -20,2 +20,3 @@ import { createShader } from '../renderer/index.js';
     marginBottom?: number;
+    _queueDelete?: boolean;
 }
@@ -35,2 +36,3 @@ export type SolidNode = ElementNode | TextNode;
     autofocus: boolean;
+    _queueDelete?: boolean;
     forwardFocus?: number | ((this: ElementNode, elm: ElementNode) => boolean | void);
@@ -37,0 +39,0 @@ private _undoStyles?;

package.json

 {
   "name": "@lightningjs/solid",
-  "version": "0.14.3",
+  "version": "0.14.4",
   "description": "Lightning renderer for solid universal",
@@ -32,3 +32,3 @@ "type": "module",
     "watch": "tsc -w",
-    "prepare": "husky install",
+    "prepare": "husky",
     "prepack": "npm run build"
@@ -67,3 +67,3 @@ },
   "dependencies": {
-    "@lightningjs/renderer": "^0.7.5",
+    "@lightningjs/renderer": "^0.7.6",
     "@lightningjs/solid": "file:"
@@ -70,0 +70,0 @@ },

src/core/node/children.ts

@@ -56,5 +56,6 @@ /*
       this.splice(nodeIndexToRemove, 1);
-      node.parent = undefined;
+      // Dont remove from parent as that causes extra work
+      node._queueDelete = true;
     }
   }
 }

src/core/node/index.ts

@@ -148,2 +148,3 @@ /*
   marginBottom?: number;
+  _queueDelete?: boolean;
 }
@@ -170,2 +171,3 @@
   autofocus: boolean;
+  _queueDelete?: boolean;
   forwardFocus?:
@@ -407,15 +409,2 @@ | number
         const { dimensions } = loadedPayload;
-        if (
-          dimensions.width === this.width &&
-          dimensions.height === this.height
-        ) {
-          return;
-        }
-
-        if (this.contain === 'width') {
-          this.height = dimensions.height;
-        } else {
-          this.width = dimensions.width;
-          this.height = dimensions.height;
-        }
         this.parent!.updateLayout(this, dimensions);
@@ -431,3 +420,3 @@ }
   destroy() {
-    if (this.lng && !this.parent) {
+    if (this.lng && this._queueDelete) {
       this.lng.destroy();
@@ -434,0 +423,0 @@ }

src/core/universal/lightning.ts

@@ -67,2 +67,3 @@ /*
       parent.children.insert(node, anchor);
+      node._queueDelete = false;
 
@@ -69,0 +70,0 @@ if (node.name === 'TextNode') {

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Worsened metrics

Total package byte prevSize

269548

decreased by-0.43%

Lines of code

4374

decreased by-0.48%

Dependency changes

• Updated@lightningjs/renderer@^0.7.6