@lightningjs/ui-components - npm Package Compare versions

Comparing version 2.4.2 to 2.5.0

package.json

 {
   "name": "@lightningjs/ui-components",
-  "version": "2.4.2",
+  "version": "2.5.0",
   "description": "A shared library of helpful LightningJS components utilizing theme files to easily customize for any LightningJS application.",
@@ -5,0 +5,0 @@ "repository": {

src/components/Base/Base.d.ts

@@ -66,6 +66,2 @@ /**
 
-  // TODO: flag for discussion
-  // internal stuff can be omitted --> `shouldSmooth` is internal?
-  shouldSmooth?: boolean;
-
   /**
@@ -77,3 +73,10 @@ * when true, plinko will use the previous item to determine the horizontal index of the next focused item
   /**
+   * used by `applySmooth` to track if a component should have values transitioned in, or patched without an animation
+   */
+  get shouldSmooth(): boolean;
+
+  /**
    * conditionally transitions in values based on the state of `shouldSmooth`
+   * if `true`, values will be applied using the [lng.Element.smooth](@link https://github.com/rdkcentral/Lightning/blob/8378d0e69752f476abedecc85568a27dbb63cbb0/src/tree/Element.d.mts#L1823C4-L1823C4)
+   * if `false`, values will be applied using [lng.Element.patch](@link https://github.com/rdkcentral/Lightning/blob/8378d0e69752f476abedecc85568a27dbb63cbb0/src/tree/Element.d.mts#L1746)
    */
@@ -80,0 +83,0 @@ // TODO took a stab at these types, could probably make this type-safe

src/components/Card/Card.js

@@ -46,3 +46,3 @@ /**
         signals: {
-          textBoxChanged: 'queueRequestUpdate'
+          textBoxChanged: '_updatePositions'
         }
@@ -56,2 +56,6 @@ }
     this._updateTitle();
+    this._updatePositions();
+  }
+
+  _updatePositions() {
     this._updateTitlePosition();
@@ -58,0 +62,0 @@ }

src/components/Card/CardSection.js

@@ -61,2 +61,3 @@ /**
   }
+
   _calculateTextWidth() {
@@ -63,0 +64,0 @@ const textWidth = this.w - this.style.paddingHorizontal * 2;

src/components/Card/CardTitle.js

@@ -46,3 +46,3 @@ /**
         signals: {
-          textBoxChanged: '_updateDescriptionPosition'
+          textBoxChanged: '_updatePositions'
         }
@@ -60,4 +60,9 @@ },
     this._updateDescription();
+    this._updateDetails();
+    this._updatePositions();
+  }
+
+  _updatePositions() {
+    super._updatePositions();
     this._updateDescriptionPosition();
-    this._updateDetails();
     this._updateDetailsPosition();
@@ -64,0 +69,0 @@ }

src/components/Card/index.d.ts

@@ -20,2 +20,3 @@ /**
 import Card, { CardStyle } from './Card';
+import CardRadio, { CardRadioStyle } from './CardRadio';
 import CardSection, { CardSectionStyle } from './CardSection';
@@ -27,2 +28,4 @@ import CardTitle, { CardTitleStyle } from './CardTitle';
   CardStyle,
+  CardRadio,
+  CardRadioStyle,
   CardSection,
@@ -29,0 +32,0 @@ CardSectionStyle,

src/components/Card/index.js

@@ -20,5 +20,6 @@ /**
 import Card from './Card';
+import CardRadio from './CardRadio';
 import CardSection from './CardSection';
 import CardTitle from './CardTitle';
 
-export { Card as default, CardSection, CardTitle };
+export { Card as default, CardRadio, CardSection, CardTitle };

src/components/index.d.ts

@@ -25,5 +25,7 @@ /**
   default as Card,
+  CardRadio,
   CardSection,
   CardTitle,
   CardStyle,
+  CardRadioStyle,
   CardSectionStyle,
@@ -30,0 +32,0 @@ CardTitleStyle

src/components/index.js

@@ -24,3 +24,3 @@ /**
 export { default as ButtonSmall } from './Button/ButtonSmall.js';
-export { default as Card, CardSection, CardTitle } from './Card';
+export { default as Card, CardRadio, CardSection, CardTitle } from './Card';
 export {
@@ -27,0 +27,0 @@ default as CardContent,

src/components/TextBox/TextBox.stories.js

@@ -140,2 +140,3 @@ /**
           type: TextBox,
+          x: 400,
           w: 400,
@@ -142,0 +143,0 @@ content:

src/components/Tile/Tile.js

@@ -123,3 +123,3 @@ /**
   get h() {
-    return this.metadataLocation !== 'inset'
+    return !this._isInsetMetadata
       ? super.h + ((this._Metadata && this._Metadata.h) || 0)
@@ -459,3 +459,3 @@ : super.h;
   get _isInsetMetadata() {
-    return this._metadataLocation === 'inset';
+    return this.metadataLocation === 'inset';
   }
@@ -521,7 +521,7 @@
 
-  _setMetadataLocation(newMetadataLocation) {
-    if (newMetadataLocation) {
-      this.style.metadataLocation = newMetadataLocation;
+  _setMetadataLocation(metadataLocation) {
+    if (metadataLocation) {
+      this.style = { metadataLocation };
     }
-    return newMetadataLocation;
+    return metadataLocation;
   }
@@ -574,3 +574,3 @@
     // Send event to columns/rows that the height has been updated since metadata will be displayed below the Tile
-    if (this.metadataLocation !== 'inset') {
+    if (!this._isInsetMetadata) {
       this.fireAncestors('$itemChanged');
@@ -577,0 +577,0 @@ }

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

11855987

increased by0.31%

Number of package files

623

increased by1.14%

Lines of code

51799

increased by0.75%

No dependency changes