@lightningtv/core - npm Package Compare versions

Comparing version 1.5.3 to 1.5.4

dist/src/elementNode.js

@@ -445,3 +445,14 @@ import { renderer, createShader } from './lightningInit.js';
         }
-        if (topNode && parent.requiresLayout()) {
+        // Need to come back to this. In order to do layout all the children nodes also need to have their defaults calculated
+        // and then flex can be done. So we'd need to render the parent, then calculate all the props for the children, run flex, then render.
+        // For now we'll go back to the old system.
+        // if (this.requiresLayout() && !this._containsTextNodes) {
+        //   // Since the element doesn't contain any text nodes, it's safe to do layout early since we know dimensions.
+        //   // This has the added benefit of laying out without animating the nodes
+        //   this.updateLayout();
+        // }
+        // if (topNode && parent.requiresLayout()) {
+        //   parent.queueLayout();
+        // }
+        if (parent.requiresLayout()) {
             parent.queueLayout();
@@ -537,7 +548,2 @@ }
         node.rendered = true;
-        if (this.requiresLayout() && !this._containsTextNodes) {
-            // Since the element doesn't contain any text nodes, it's safe to do layout early since we know dimensions.
-            // This has the added benefit of laying out without animating the nodes
-            this.updateLayout();
-        }
         if (node.autosize && parent.requiresLayout()) {
@@ -544,0 +550,0 @@ node._layoutOnLoad();

package.json

 {
   "name": "@lightningtv/core",
-  "version": "1.5.3",
+  "version": "1.5.4",
   "description": "Lightning TV Core for Universal Renderers",
@@ -5,0 +5,0 @@ "type": "module",

src/elementNode.ts

@@ -631,3 +631,17 @@ import { renderer, createShader } from './lightningInit.js';
 
-    if (topNode && parent.requiresLayout()) {
+    // Need to come back to this. In order to do layout all the children nodes also need to have their defaults calculated
+    // and then flex can be done. So we'd need to render the parent, then calculate all the props for the children, run flex, then render.
+    // For now we'll go back to the old system.
+
+    // if (this.requiresLayout() && !this._containsTextNodes) {
+    //   // Since the element doesn't contain any text nodes, it's safe to do layout early since we know dimensions.
+    //   // This has the added benefit of laying out without animating the nodes
+    //   this.updateLayout();
+    // }
+
+    // if (topNode && parent.requiresLayout()) {
+    //   parent.queueLayout();
+    // }
+
+    if (parent.requiresLayout()) {
       parent.queueLayout();
@@ -738,8 +752,2 @@ }
 
-    if (this.requiresLayout() && !this._containsTextNodes) {
-      // Since the element doesn't contain any text nodes, it's safe to do layout early since we know dimensions.
-      // This has the added benefit of laying out without animating the nodes
-      this.updateLayout();
-    }
-
     if (node.autosize && parent.requiresLayout()) {
@@ -746,0 +754,0 @@ node._layoutOnLoad();

No alert changes

Improved metrics

Total package byte prevSize

221769

increased by0.37%

Lines of code

3257

increased by0.37%

No dependency changes