@liskhq/lisk-bft - npm Package Compare versions

Comparing version 0.3.1 to 0.3.2

dist-node/bft.d.ts

@@ -37,5 +37,5 @@ /// <reference types="node" />
     isBFTProtocolCompliant(blockHeader: BlockHeader, stateStore: StateStore): Promise<boolean>;
-    getMaxHeightPrevoted(): Promise<number>;
+    getMaxHeightPrevoted(lastMaxHeightPrevoted: number): Promise<number>;
     get finalizedHeight(): number;
     private _initFinalityManager;
 }

dist-node/bft.js

@@ -107,4 +107,4 @@ "use strict";
     }
-    async getMaxHeightPrevoted() {
-        return this.finalityManager.getMaxHeightPrevoted();
+    async getMaxHeightPrevoted(lastMaxHeightPrevoted) {
+        return this.finalityManager.getMaxHeightPrevoted(lastMaxHeightPrevoted);
     }
@@ -122,2 +122,3 @@ get finalizedHeight() {
             finalizedHeight,
+            genesisHeight: this.constants.genesisHeight,
             threshold: this.constants.threshold,
@@ -124,0 +125,0 @@ });

dist-node/finality_manager.d.ts

@@ -79,4 +79,6 @@ /// <reference types="node" />
     private readonly _chain;
-    constructor({ chain, finalizedHeight, threshold, }: {
+    private readonly _genesisHeight;
+    constructor({ chain, genesisHeight, finalizedHeight, threshold, }: {
         readonly chain: Chain;
+        readonly genesisHeight: number;
         readonly finalizedHeight: number;
@@ -89,3 +91,3 @@ readonly threshold: number;
     verifyBlockHeaders(blockHeader: BlockHeader, stateStore: StateStore): Promise<boolean>;
-    getMaxHeightPrevoted(): Promise<number>;
+    getMaxHeightPrevoted(lastMaxHeightPrevoted?: number): Promise<number>;
     private _calculateMaxHeightPrevoted;
@@ -92,0 +94,0 @@ private _getMinValidHeightToPreCommit;

dist-node/finality_manager.js

@@ -71,6 +71,7 @@ "use strict";
 class FinalityManager extends events_1.EventEmitter {
-    constructor({ chain, finalizedHeight, threshold, }) {
+    constructor({ chain, genesisHeight, finalizedHeight, threshold, }) {
         super();
         assert(threshold > 0, 'Must provide a positive threshold');
         this._chain = chain;
+        this._genesisHeight = genesisHeight;
         this.preVoteThreshold = threshold;
@@ -181,3 +182,6 @@ this.preCommitThreshold = threshold;
         const { ledger } = await this._getVotingLedger(stateStore);
-        const chainMaxHeightPrevoted = this._calculateMaxHeightPrevoted(ledger);
+        const lastMaxHeightPrevoted = bftBlockHeaders.length > 0 && bftBlockHeaders[0].asset.maxHeightPrevoted
+            ? bftBlockHeaders[0].asset.maxHeightPrevoted
+            : this._genesisHeight;
+        const chainMaxHeightPrevoted = this._calculateMaxHeightPrevoted(ledger, lastMaxHeightPrevoted);
         if (bftBlockHeaders.length >= this.processingThreshold &&
@@ -196,8 +200,8 @@ blockHeader.asset.maxHeightPrevoted !== chainMaxHeightPrevoted) {
     }
-    async getMaxHeightPrevoted() {
+    async getMaxHeightPrevoted(lastMaxHeightPrevoted) {
         const bftState = await this._chain.dataAccess.getConsensusState(exports.CONSENSUS_STATE_VALIDATOR_LEDGER_KEY);
         const { ledger } = this._decodeVotingLedger(bftState);
-        return this._calculateMaxHeightPrevoted(ledger);
+        return this._calculateMaxHeightPrevoted(ledger, lastMaxHeightPrevoted !== null && lastMaxHeightPrevoted !== void 0 ? lastMaxHeightPrevoted : this._genesisHeight);
     }
-    _calculateMaxHeightPrevoted(ledger) {
+    _calculateMaxHeightPrevoted(ledger, lastMaxHeightPrevoted) {
         debug('updatePreVotedAndFinalizedHeight invoked');
@@ -207,3 +211,3 @@ const maxHeightPreVoted = Object.keys(ledger)
             .find(key => ledger[key].prevotes >= this.preVoteThreshold);
-        return maxHeightPreVoted ? parseInt(maxHeightPreVoted, 10) : this.finalizedHeight;
+        return maxHeightPreVoted ? parseInt(maxHeightPreVoted, 10) : lastMaxHeightPrevoted;
     }
@@ -210,0 +214,0 @@ _getMinValidHeightToPreCommit(header, bftApplicableBlocks) {

package.json

 {
 	"name": "@liskhq/lisk-bft",
-	"version": "0.3.1",
+	"version": "0.3.2",
 	"description": "Byzantine fault tolerance implementation according to the Lisk protocol",
@@ -39,3 +39,3 @@ "author": "Lisk Foundation <[e-mail]>, lightcurve GmbH <[e-mail]>",
 	"dependencies": {
-		"@liskhq/lisk-chain": "^0.3.1",
+		"@liskhq/lisk-chain": "^0.3.2",
 		"@liskhq/lisk-codec": "^0.2.0",
@@ -42,0 +42,0 @@ "@liskhq/lisk-cryptography": "^3.1.0",

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

53422

increased by2.07%

Lines of code

704

increased by1%

Dependency changes

• Updated@liskhq/lisk-chain@^0.3.2