@lo-fi/common - npm Package Compare versions

Comparing version 1.10.4 to 1.11.0

dist/cjs/EventSubscriber.d.ts

 export declare class EventSubscriber<Events extends {
     [key: string]: (...args: any[]) => void;
 }> {
+    private _onAllUnsubscribed?;
     protected subscribers: Record<string, Record<string, (...args: any[]) => void>>;
     protected counts: Record<string, number>;
     private _disabled;
+    constructor(_onAllUnsubscribed?: ((event: keyof Events) => void) | undefined);
     get disabled(): boolean;
@@ -8,0 +10,0 @@ subscriberCount: (event: Extract<keyof Events, string>) => number;

dist/cjs/EventSubscriber.js

@@ -6,3 +6,4 @@ "use strict";
 class EventSubscriber {
-    constructor() {
+    constructor(_onAllUnsubscribed) {
+        this._onAllUnsubscribed = _onAllUnsubscribed;
         this.subscribers = {};
@@ -27,4 +28,14 @@ this.counts = {};
             return () => {
+                // already removed
+                if (!this.subscribers[event])
+                    return;
                 delete this.subscribers[event][key];
                 this.counts[event]--;
+                if (this.counts[event] === 0) {
+                    delete this.subscribers[event];
+                    delete this.counts[event];
+                    if (this._onAllUnsubscribed) {
+                        this._onAllUnsubscribed(event);
+                    }
+                }
             };
@@ -40,4 +51,10 @@ };
         this.dispose = () => {
+            const events = Object.keys(this.subscribers);
             this.subscribers = {};
             this.counts = {};
+            events.forEach((event) => {
+                if (this._onAllUnsubscribed) {
+                    this._onAllUnsubscribed(event);
+                }
+            });
         };
@@ -44,0 +61,0 @@ this.disable = () => {

dist/cjs/oids.d.ts

@@ -45,3 +45,3 @@ import { ObjectRef } from './operation.js';
 export declare function ensureOid(obj: any, rootOid: ObjectIdentifier, key: string | number, createSubId?: () => string): string;
-export declare function createOid(collection: string, documentId: string, keyPath: KeyPath, subId?: string): string;
+export declare function createOid(collection: string, documentId: string, keyPath?: KeyPath, subId?: string): string;
 export declare function createSubOid(root: ObjectIdentifier, key: string | number, createSubId?: () => string): string;
@@ -48,0 +48,0 @@ export declare function decomposeOid(oid: ObjectIdentifier): {

dist/cjs/oids.js

@@ -86,3 +86,3 @@ "use strict";
 }
-function createOid(collection, documentId, keyPath, subId) {
+function createOid(collection, documentId, keyPath = [], subId) {
     let oid = sanitizeFragment(collection) +
@@ -89,0 +89,0 @@ COLLECTION_SEPARATOR +

dist/esm/EventSubscriber.d.ts

 export declare class EventSubscriber<Events extends {
     [key: string]: (...args: any[]) => void;
 }> {
+    private _onAllUnsubscribed?;
     protected subscribers: Record<string, Record<string, (...args: any[]) => void>>;
     protected counts: Record<string, number>;
     private _disabled;
+    constructor(_onAllUnsubscribed?: ((event: keyof Events) => void) | undefined);
     get disabled(): boolean;
@@ -8,0 +10,0 @@ subscriberCount: (event: Extract<keyof Events, string>) => number;

dist/esm/EventSubscriber.js

 import { generateId } from './utils.js';
 export class EventSubscriber {
-    constructor() {
+    constructor(_onAllUnsubscribed) {
+        this._onAllUnsubscribed = _onAllUnsubscribed;
         this.subscribers = {};
@@ -23,4 +24,14 @@ this.counts = {};
             return () => {
+                // already removed
+                if (!this.subscribers[event])
+                    return;
                 delete this.subscribers[event][key];
                 this.counts[event]--;
+                if (this.counts[event] === 0) {
+                    delete this.subscribers[event];
+                    delete this.counts[event];
+                    if (this._onAllUnsubscribed) {
+                        this._onAllUnsubscribed(event);
+                    }
+                }
             };
@@ -36,4 +47,10 @@ };
         this.dispose = () => {
+            const events = Object.keys(this.subscribers);
             this.subscribers = {};
             this.counts = {};
+            events.forEach((event) => {
+                if (this._onAllUnsubscribed) {
+                    this._onAllUnsubscribed(event);
+                }
+            });
         };
@@ -40,0 +57,0 @@ this.disable = () => {

dist/esm/oids.d.ts

@@ -45,3 +45,3 @@ import { ObjectRef } from './operation.js';
 export declare function ensureOid(obj: any, rootOid: ObjectIdentifier, key: string | number, createSubId?: () => string): string;
-export declare function createOid(collection: string, documentId: string, keyPath: KeyPath, subId?: string): string;
+export declare function createOid(collection: string, documentId: string, keyPath?: KeyPath, subId?: string): string;
 export declare function createSubOid(root: ObjectIdentifier, key: string | number, createSubId?: () => string): string;
@@ -48,0 +48,0 @@ export declare function decomposeOid(oid: ObjectIdentifier): {

dist/esm/oids.js

@@ -76,3 +76,3 @@ import { v4 } from 'uuid';
 }
-export function createOid(collection, documentId, keyPath, subId) {
+export function createOid(collection, documentId, keyPath = [], subId) {
     let oid = sanitizeFragment(collection) +
@@ -79,0 +79,0 @@ COLLECTION_SEPARATOR +

package.json

 {
   "name": "@lo-fi/common",
-  "version": "1.10.4",
+  "version": "1.11.0",
   "access": "public",
@@ -5,0 +5,0 @@ "type": "module",

src/EventSubscriber.ts

@@ -13,2 +13,4 @@ import { generateId } from './utils.js';
 
+	constructor(private _onAllUnsubscribed?: (event: keyof Events) => void) {}
+
 	get disabled() {
@@ -38,4 +40,14 @@ return this._disabled;
 		return () => {
+			// already removed
+			if (!this.subscribers[event]) return;
+
 			delete this.subscribers[event][key];
 			this.counts[event]--;
+			if (this.counts[event] === 0) {
+				delete this.subscribers[event];
+				delete this.counts[event];
+				if (this._onAllUnsubscribed) {
+					this._onAllUnsubscribed(event);
+				}
+			}
 		};
@@ -55,4 +67,10 @@ };
 	dispose = () => {
+		const events = Object.keys(this.subscribers);
 		this.subscribers = {} as any;
 		this.counts = {} as any;
+		events.forEach((event) => {
+			if (this._onAllUnsubscribed) {
+				this._onAllUnsubscribed(event);
+			}
+		});
 	};
@@ -59,0 +77,0 @@

src/oids.ts

@@ -132,3 +132,3 @@ import { v4 } from 'uuid';
 	documentId: string,
-	keyPath: KeyPath,
+	keyPath: KeyPath = [],
 	subId?: string,
@@ -135,0 +135,0 @@ ) {

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

765090

increased by0.44%

Lines of code

14367

increased by0.38%

No dependency changes