@lrnwebcomponents/simple-toast - npm Package Compare versions

Comparing version 2.4.0 to 2.4.1

analysis.json

@@ -108,7 +108,7 @@ {
             "start": {
-              "line": 83,
+              "line": 84,
               "column": 2
             },
             "end": {
-              "line": 87,
+              "line": 88,
               "column": 3
@@ -130,7 +130,7 @@ }
             "start": {
-              "line": 91,
+              "line": 92,
               "column": 2
             },
             "end": {
-              "line": 94,
+              "line": 95,
               "column": 3
@@ -152,7 +152,7 @@ }
             "start": {
-              "line": 98,
+              "line": 99,
               "column": 2
             },
             "end": {
-              "line": 102,
+              "line": 103,
               "column": 3
@@ -174,7 +174,7 @@ }
             "start": {
-              "line": 106,
+              "line": 107,
               "column": 2
             },
             "end": {
-              "line": 110,
+              "line": 111,
               "column": 3
@@ -196,7 +196,7 @@ }
             "start": {
-              "line": 114,
+              "line": 115,
               "column": 2
             },
             "end": {
-              "line": 117,
+              "line": 118,
               "column": 3
@@ -218,7 +218,7 @@ }
             "start": {
-              "line": 121,
+              "line": 122,
               "column": 2
             },
             "end": {
-              "line": 125,
+              "line": 126,
               "column": 3
@@ -240,7 +240,7 @@ }
             "start": {
-              "line": 129,
+              "line": 130,
               "column": 2
             },
             "end": {
-              "line": 134,
+              "line": 135,
               "column": 3
@@ -351,7 +351,7 @@ }
             "start": {
-              "line": 166,
+              "line": 167,
               "column": 2
             },
             "end": {
-              "line": 176,
+              "line": 177,
               "column": 3
@@ -755,7 +755,7 @@ }
             "start": {
-              "line": 65,
+              "line": 66,
               "column": 2
             },
             "end": {
-              "line": 72,
+              "line": 73,
               "column": 3
@@ -773,7 +773,7 @@ }
             "start": {
-              "line": 180,
+              "line": 181,
               "column": 2
             },
             "end": {
-              "line": 182,
+              "line": 183,
               "column": 3
@@ -798,7 +798,7 @@ }
             "start": {
-              "line": 183,
+              "line": 184,
               "column": 2
             },
             "end": {
-              "line": 185,
+              "line": 186,
               "column": 3
@@ -823,7 +823,7 @@ }
             "start": {
-              "line": 186,
+              "line": 187,
               "column": 2
             },
             "end": {
-              "line": 197,
+              "line": 198,
               "column": 3
@@ -844,7 +844,7 @@ }
             "start": {
-              "line": 201,
+              "line": 202,
               "column": 2
             },
             "end": {
-              "line": 229,
+              "line": 230,
               "column": 3
@@ -869,7 +869,7 @@ }
             "start": {
-              "line": 231,
+              "line": 232,
               "column": 2
             },
             "end": {
-              "line": 233,
+              "line": 234,
               "column": 3
@@ -894,7 +894,7 @@ }
             "start": {
-              "line": 234,
+              "line": 235,
               "column": 2
             },
             "end": {
-              "line": 245,
+              "line": 246,
               "column": 3
@@ -1130,3 +1130,3 @@ }
         "end": {
-          "line": 246,
+          "line": 247,
           "column": 1
@@ -1144,7 +1144,7 @@ }
             "start": {
-              "line": 83,
+              "line": 84,
               "column": 2
             },
             "end": {
-              "line": 87,
+              "line": 88,
               "column": 3
@@ -1161,7 +1161,7 @@ }
             "start": {
-              "line": 91,
+              "line": 92,
               "column": 2
             },
             "end": {
-              "line": 94,
+              "line": 95,
               "column": 3
@@ -1178,7 +1178,7 @@ }
             "start": {
-              "line": 98,
+              "line": 99,
               "column": 2
             },
             "end": {
-              "line": 102,
+              "line": 103,
               "column": 3
@@ -1195,7 +1195,7 @@ }
             "start": {
-              "line": 106,
+              "line": 107,
               "column": 2
             },
             "end": {
-              "line": 110,
+              "line": 111,
               "column": 3
@@ -1212,7 +1212,7 @@ }
             "start": {
-              "line": 114,
+              "line": 115,
               "column": 2
             },
             "end": {
-              "line": 117,
+              "line": 118,
               "column": 3
@@ -1229,7 +1229,7 @@ }
             "start": {
-              "line": 121,
+              "line": 122,
               "column": 2
             },
             "end": {
-              "line": 125,
+              "line": 126,
               "column": 3
@@ -1246,7 +1246,7 @@ }
             "start": {
-              "line": 129,
+              "line": 130,
               "column": 2
             },
             "end": {
-              "line": 134,
+              "line": 135,
               "column": 3
@@ -1253,0 +1253,0 @@ }

gulpfile.js

@@ -63,21 +63,3 @@ const gulp = require("gulp");
           }
-          let styleRegex = /\/\*[\s]*LIST SHARED STYLES BELOW[\s]*((?:(?:\w+)[\s,]*)*)\*\//g,
-            styleArray =
-              cssResult.match(styleRegex) &&
-              cssResult.match(styleRegex).length > 0
-                ? cssResult
-                    .match(styleRegex)[0]
-                    .replace(styleRegex, "$1")
-                    .match(/(\w+)[\s,]*/g)
-                : [];
-          sharedStyles =
-            styleArray && styleArray.length > 0
-              ? styleArray.map(style =>
-                  style.replace(
-                    /(\w+)[\s,]*/g,
-                    `
-        $1`
-                  )
-                )
-              : ``;
+
           cssResult = stripCssComments(cssResult).trim();
@@ -90,3 +72,9 @@ let litResult =
   static get styles() {
-    return  [${sharedStyles ? `${sharedStyles},` : ``}
+    return  [
+      ${
+        packageJson.wcfactory.sharedStyles &&
+        packageJson.wcfactory.sharedStyles.length > 0
+          ? `${packageJson.wcfactory.sharedStyles.join(",")},`
+          : ``
+      }
       css\`
@@ -93,0 +81,0 @@ ${cssResult}

package.json

@@ -17,5 +17,6 @@ {
       "hax": "src/simple-toast-hax.json"
-    }
+    },
+    "sharedStyles": []
   },
-  "version": "2.4.0",
+  "version": "2.4.1",
   "description": "A singular toast / message for conistency",
@@ -34,5 +35,5 @@ "repository": {
     "build": "../../node_modules/.bin/gulp && ../../node_modules/.bin/rollup -c && ../../node_modules/.bin/prettier --ignore-path ../../.prettierignore --write '**/*.{js,json}' && wca analyze \"**/*.js\" --format vscode --outFile vscode-html-custom-data.json",
-    "dev": "concurrently --kill-others \"yarn run watch\" \"yarn run serve\"",
+    "dev": "../../node_modules/.bin/concurrently --kill-others \"yarn run watch\" \"yarn run serve\"",
     "watch": "../../node_modules/.bin/gulp dev",
-    "serve": "polymer serve --npm --module-resolution=node --open",
+    "serve": "../../node_modules/.bin/es-dev-server -c ../../es-dev-server.config.js",
     "lighthouse": "../../node_modules/.bin/gulp lighthouse"
@@ -51,3 +52,3 @@ },
     "@lrnwebcomponents/deduping-fix": "^2.4.0",
-    "@lrnwebcomponents/storybook-utilities": "^2.4.0",
+    "@lrnwebcomponents/storybook-utilities": "^2.4.1",
     "@polymer/iron-component-page": "github:PolymerElements/iron-component-page",
@@ -72,3 +73,3 @@ "@polymer/iron-demo-helpers": "3.1.0",
   ],
-  "gitHead": "d3bc01d12a0d042ba1fdb4f0dda36cfa5824047f"
+  "gitHead": "27af689f6d96197fba00cc508a953cdd008f21b1"
 }

simple-toast.es6.js

@@ -38,2 +38,3 @@ /**
     return  [
+      
       css`
@@ -40,0 +41,0 @@ :host {

No alert changes

Worsened metrics

Total package byte prevSize

102568

decreased by-0.49%

Lines of code

2380

decreased by-0.54%

No dependency changes