@mapbox/cloudfriend - npm Package Compare versions

Comparing version 2.8.0 to 2.8.1

changelog.md

@@ -0,1 +1,5 @@
+# v2.8.1
+
+- Implement a list of AWS service namespaces where use of `AWS::URLSuffix` results in an invalid service URL in China regions.
+
 # v2.8.0
@@ -2,0 +6,0 @@

lib/shortcuts/service-role.js

@@ -61,4 +61,26 @@ 'use strict';
 
+    const avoidSuffix = [
+      'apigateway',
+      'autoscaling',
+      'cloudformation',
+      'codedeploy',
+      'ecs-tasks',
+      'elasticbeanstalk',
+      'iot',
+      'lambda',
+      'rds',
+      'redshift',
+      's3',
+      'sms',
+      'storagegateway',
+      'swf'
+    ];
+
+    const prefix = Service.replace(/\.amazonaws.com(\..*)?$/, '');
+
+
     Service = {
-      'Fn::Sub': `${Service.replace(/\.amazonaws.com(\..*)?$/, '')}.\${AWS::URLSuffix}`
+      'Fn::Sub': avoidSuffix.includes(prefix)
+        ? `${prefix}.amazonaws.com`
+        : `${prefix}.\${AWS::URLSuffix}`
     };
@@ -65,0 +87,0 @@

package.json

 {
   "name": "@mapbox/cloudfriend",
-  "version": "2.8.0",
+  "version": "2.8.1",
   "description": "Helper functions for assembling CloudFormation templates in JavaScript",
@@ -5,0 +5,0 @@ "main": "index.js",

test/fixtures/shortcuts/service-role-defaults.json

@@ -18,3 +18,3 @@ {
                 "Service": {
-                  "Fn::Sub": "lambda.${AWS::URLSuffix}"
+                  "Fn::Sub": "lambda.amazonaws.com"
                 }
@@ -21,0 +21,0 @@ }

test/fixtures/shortcuts/service-role-no-defaults.json

@@ -36,3 +36,3 @@ {
                 "Service": {
-                  "Fn::Sub": "lambda.${AWS::URLSuffix}"
+                  "Fn::Sub": "lambda.amazonaws.com"
                 }
@@ -39,0 +39,0 @@ }

test/shortcuts.test.js

@@ -346,7 +346,7 @@ 'use strict';
   template = cf.merge(role);
-  if (update) fixtures.update('service-role-suffix-replace', template);
+  if (update) fixtures.update('service-role-no-url-suffix', template);
   assert.deepEqual(
     noUndefined(template),
-    fixtures.get('service-role-suffix-replace'),
-    'expected resources generated, region-specific service suffix replaced'
+    fixtures.get('service-role-no-url-suffix'),
+    'expected resources generated, service for which AWS::URLSuffix is invalid'
   );
@@ -356,2 +356,28 @@
     LogicalName: 'MyRole',
+    Service: 'ec2'
+  });
+
+  template = cf.merge(role);
+  if (update) fixtures.update('service-role-url-suffix', template);
+  assert.deepEqual(
+    noUndefined(template),
+    fixtures.get('service-role-url-suffix'),
+    'expected resources generated, service for which AWS::URLSuffix is invalid'
+  );
+
+  role = new cf.shortcuts.ServiceRole({
+    LogicalName: 'MyRole',
+    Service: 'ec2.amazonaws.com'
+  });
+
+  template = cf.merge(role);
+  if (update) fixtures.update('service-role-url-suffix-with-replacement', template);
+  assert.deepEqual(
+    noUndefined(template),
+    fixtures.get('service-role-url-suffix-with-replacement'),
+    'expected resources generated, service for which AWS::URLSuffix is invalid specified with a suffix'
+  );
+
+  role = new cf.shortcuts.ServiceRole({
+    LogicalName: 'MyRole',
     Service: 'lambda.amazonaws.com',
@@ -358,0 +384,0 @@ Statement: [

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

New author

Supply chain risk

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

277529

increased by0.9%

Number of package files

61

increased by3.39%

Lines of code

7502

increased by1.28%

Number of medium supply chain risk alerts

1

decreased by-50%

No dependency changes