@marcoms/make-element - npm Package Compare versions

Comparing version 2.1.0 to 3.0.0

package.json

 {
     "name": "@marcoms/make-element",
-    "version": "2.1.0",
+    "version": "3.0.0",
     "description": "Create custom elements without boilerplate",
-    "main": "dist/index.js",
-    "module": "dist/index.module.js",
+    "main": "build/make-element.js",
     "repository": {},
@@ -16,3 +15,3 @@ "keywords": [
     "scripts": {
-        "build": "rollup -c rollup.config.js"
+        "build": "webpack"
     },
@@ -22,7 +21,6 @@ "author": "Marco Scannadinari <[e-mail]>",
     "devDependencies": {
-        "eslint": "^3.15.0",
-        "rollup": "^0.41.5",
-        "rollup-plugin-babili": "^1.1.1",
-        "rollup-plugin-json": "^2.1.0"
-    }
+        "babili-webpack-plugin": "^0.1.1",
+        "eslint": "^3.15.0"
+    },
+    "dependencies": {}
 }

src/index.js

@@ -1,3 +0,1 @@
-import {version} from '../package.json';
-
 function noop() {}
@@ -199,12 +197,2 @@
 
-			const cacheIds = (context) => {
-				this.$ = {};
-
-				// let's hope no-one has empty id attributes
-				const elsWithIds = context.querySelectorAll('[id]');
-				for (const el of elsWithIds) {
-					this.$[el.id] = el;
-				}
-			};
-
 			if (hasLocalTemplate) {
@@ -238,7 +226,14 @@ if (def.shadowDom) {
 			if (def.cacheIds !== false) {
+				this.$ = {};
+
+				let context = this;
 				if (def.shadowDom) {
-					cacheIds(this.shadowRoot);
-				} else {
-					cacheIds(this);
+					context = this.shadowRoot;
 				}
+
+				// let's hope no-one has empty id attributes
+				const elsWithIds = context.querySelectorAll('[id]');
+				for (const el of elsWithIds) {
+					this.$[el.id] = el;
+				}
 			}
@@ -280,5 +275,2 @@ }
 				const internalAttr = registeredAttrs[attrName];
-				const propName = internalAttr.prop;
-				const internalProp = registeredProps[propName];
-
 				internalAttr.val = val;
@@ -290,2 +282,5 @@
 
+					const propName = internalAttr.prop;
+					const internalProp = registeredProps[propName];
+
 					const propVal = internalProp.fromAttr(val);
@@ -318,9 +313,2 @@ this[propName] = propVal;
 
-const [versionMajor, versionMinor, versionPatch] = version.split('.');
-makeElement.version = {
-	major: Number.parseInt(versionMajor, 10),
-	minor: Number.parseInt(versionMinor, 10),
-	patch: Number.parseInt(versionPatch, 10),
-};
-
-export default makeElement;
+module.exports = makeElement;

No alert changes

Improved metrics

Dev dependency count

2

decreased by-50%

Lines of code

445

increased by36.5%

Worsened metrics

Total package byte prevSize

64093

decreased by-38.7%

No dependency changes