@masknet/compartment - npm Package Compare versions

Comparing version 0.3.2 to 0.3.3

dist/Module.js

@@ -205,3 +205,3 @@ import { all, ambiguous, empty, namespace, PromiseCapability, } from './utils/spec.js';
                 const namespaceObject = Module.#GetModuleNamespace(importedModule);
-                Object.defineProperty(env, i.LocalName, { value: namespaceObject });
+                Object.defineProperty(env, i.LocalName, { value: namespaceObject, enumerable: true });
             }
@@ -215,3 +215,3 @@ else {
                     const namespaceObject = Module.#GetModuleNamespace(resolution.module);
-                    Object.defineProperty(env, i.LocalName, { value: namespaceObject });
+                    Object.defineProperty(env, i.LocalName, { value: namespaceObject, enumerable: true });
                 }
@@ -223,2 +223,3 @@ else {
                         configurable: true,
+                        enumerable: true,
                     });
@@ -235,2 +236,3 @@ resolution.module.#ExportCallback.add(f);
                             configurable: true,
+                            enumerable: true,
                         });
@@ -250,2 +252,5 @@ }
                 },
+                // Note: export property should not be enumerable?
+                // but it will crash Chrome devtools.See: https://bugs.chromium.org/p/chromium/issues/detail?id=1358114
+                enumerable: true,
             });
@@ -252,0 +257,0 @@ }

package.json

 {
   "name": "@masknet/compartment",
-  "version": "0.3.2",
+  "version": "0.3.3",
   "type": "module",
@@ -16,2 +16,3 @@ "main": "./dist/index.js",
     "dist",
+    "!dist/.tsbuildinfo",
     "src"
@@ -18,0 +19,0 @@ ],

src/Module.ts

@@ -236,3 +236,3 @@ import type { ModuleSource } from './ModuleSource.js'
                 const namespaceObject = Module.#GetModuleNamespace(importedModule)
-                Object.defineProperty(env, i.LocalName, { value: namespaceObject })
+                Object.defineProperty(env, i.LocalName, { value: namespaceObject, enumerable: true })
             } else {
@@ -245,3 +245,3 @@ const resolution = importedModule.#ResolveExport(i.ImportName)
                     const namespaceObject = Module.#GetModuleNamespace(resolution.module)
-                    Object.defineProperty(env, i.LocalName, { value: namespaceObject })
+                    Object.defineProperty(env, i.LocalName, { value: namespaceObject, enumerable: true })
                 } else {
@@ -253,2 +253,3 @@ const { bindingName, module } = resolution
                             configurable: true,
+                            enumerable: true,
                         })
@@ -265,2 +266,3 @@ resolution.module.#ExportCallback.add(f)
                             configurable: true,
+                            enumerable: true,
                         })
@@ -280,2 +282,5 @@ }
                 },
+                // Note: export property should not be enumerable?
+                // but it will crash Chrome devtools.See: https://bugs.chromium.org/p/chromium/issues/detail?id=1358114
+                enumerable: true,
             })
@@ -282,0 +287,0 @@ }

No alert changes

Improved metrics

Lines of code

2533

increased by0.4%

Worsened metrics

Total package byte prevSize

145857

decreased by-9.51%

Number of package files

52

decreased by-1.89%

No dependency changes