@mediarithmics/plugins-nodejs-sdk - npm Package Compare versions

Comparing version 0.4.4 to 0.4.5

CHANGELOG.md

 # Changelog
 
+# 0.4.5 - 2018-06-21
+
+- Fix Email Renderer bug (wrong Id to store the InstanceContext)
+
 # 0.4.4 - 2018-06-20
@@ -4,0 +8,0 @@

lib/mediarithmics/plugins/email-renderer/base/EmailRendererBasePlugin.js

@@ -71,6 +71,6 @@ "use strict";
                 }
-                if (!this.pluginCache.get(emailRenderRequest.email_renderer_id)) {
-                    this.pluginCache.put(emailRenderRequest.email_renderer_id, this.instanceContextBuilder(emailRenderRequest.email_renderer_id), this.INSTANCE_CONTEXT_CACHE_EXPIRATION);
+                if (!this.pluginCache.get(emailRenderRequest.creative_id)) {
+                    this.pluginCache.put(emailRenderRequest.creative_id, this.instanceContextBuilder(emailRenderRequest.creative_id), this.INSTANCE_CONTEXT_CACHE_EXPIRATION);
                 }
-                const instanceContext = yield this.pluginCache.get(emailRenderRequest.email_renderer_id);
+                const instanceContext = yield this.pluginCache.get(emailRenderRequest.creative_id);
                 const response = yield this.onEmailContents(emailRenderRequest, instanceContext);
@@ -77,0 +77,0 @@ this.logger.debug(`Returning: ${JSON.stringify(response)}`);

package.json

 {
   "name": "@mediarithmics/plugins-nodejs-sdk",
-  "version": "0.4.4",
+  "version": "0.4.5",
   "description": "This is the mediarithmics nodejs to help plugin developers bootstrapping their plugin without having to deal with most of the plugin boilerplate",
@@ -5,0 +5,0 @@ "repository": "github:MEDIARITHMICS/plugins-nodejs-sdk",

src/mediarithmics/plugins/email-renderer/base/EmailRendererBasePlugin.ts

@@ -97,7 +97,7 @@ import * as express from "express";
 
-            if (!this.pluginCache.get(emailRenderRequest.email_renderer_id)) {
+            if (!this.pluginCache.get(emailRenderRequest.creative_id)) {
               this.pluginCache.put(
-                emailRenderRequest.email_renderer_id,
+                emailRenderRequest.creative_id,
                 this.instanceContextBuilder(
-                  emailRenderRequest.email_renderer_id
+                  emailRenderRequest.creative_id
                 ),
@@ -109,3 +109,3 @@ this.INSTANCE_CONTEXT_CACHE_EXPIRATION
             const instanceContext = await this.pluginCache.get(
-              emailRenderRequest.email_renderer_id
+              emailRenderRequest.creative_id
             );
@@ -112,0 +112,0 @@

No alert changes

Worsened metrics

Total package byte prevSize

409907

decreased by-1.29%

Number of package files

221

decreased by-0.45%

Lines of code

10122

decreased by-0.98%

No dependency changes