@metamask/eth-keyring-controller - npm Package Compare versions

Comparing version 14.0.0 to 14.0.1

CHANGELOG.md

@@ -9,2 +9,7 @@ # Changelog
 
+## [14.0.1]
+### Fixed
+- Fix `removeAccount` to await the account removal in order to account for Snaps keyrings ([#280](https://github.com/MetaMask/KeyringController/pull/280))
+- Bump `@metamask/eth-simple-keyring` from `^6.0.0` to `^6.0.1` ([#287](https://github.com/MetaMask/KeyringController/pull/287))
+
 ## [14.0.0]
@@ -109,3 +114,3 @@ ### Changed
 - Fix support for asynchronous `addAccounts` HD Keyring method ([#176](https://github.com/MetaMask/KeyringController/pull/176))
-  - This method was asynchronous, but was called synchronously. Currently the method does not do anything asychronous so this should have no functional impact, but this ensures any future errors or asynchronous steps added to that method work correctly in the future.
+  - This method was asynchronous, but was called synchronously. Currently the method does not do anything asynchronous so this should have no functional impact, but this ensures any future errors or asynchronous steps added to that method work correctly in the future.
 
@@ -169,3 +174,4 @@ ## [8.1.0]
 
-[Unreleased]: https://github.com/MetaMask/KeyringController/compare/v14.0.0...HEAD
+[Unreleased]: https://github.com/MetaMask/KeyringController/compare/v14.0.1...HEAD
+[14.0.1]: https://github.com/MetaMask/KeyringController/compare/v14.0.0...v14.0.1
 [14.0.0]: https://github.com/MetaMask/KeyringController/compare/v13.0.1...v14.0.0
@@ -172,0 +178,0 @@ [13.0.1]: https://github.com/MetaMask/KeyringController/compare/v13.0.0...v13.0.1

dist/KeyringController.js

@@ -262,3 +262,6 @@ "use strict";
         }
-        keyring.removeAccount(address);
+        // The `removeAccount` method of snaps keyring is async. We have to update
+        // the interface of the other keyrings to be async as well.
+        // eslint-disable-next-line @typescript-eslint/await-thenable
+        await keyring.removeAccount(address);
         this.emit('removedAccount', address);
@@ -265,0 +268,0 @@ const accounts = await keyring.getAccounts();

package.json

 {
   "name": "@metamask/eth-keyring-controller",
-  "version": "14.0.0",
+  "version": "14.0.1",
   "description": "A module for managing various keyrings of Ethereum accounts, encrypting them, and using them",
@@ -50,3 +50,3 @@ "keywords": [
     "@metamask/eth-sig-util": "^7.0.0",
-    "@metamask/eth-simple-keyring": "^6.0.0",
+    "@metamask/eth-simple-keyring": "^6.0.1",
     "@metamask/obs-store": "^8.1.0",
@@ -53,0 +53,0 @@ "@metamask/utils": "^8.1.0"

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

157179

increased by0.56%

Lines of code

1566

increased by0.19%

Dependency changes

• Updated@metamask/eth-simple-keyring@^6.0.1