@metamask/selected-network-controller - npm Package Compare versions

Comparing version 7.0.0 to 7.0.1

CHANGELOG.md

 # Changelog
+
 All notable changes to this project will be documented in this file.
@@ -9,4 +10,12 @@
 
+## [7.0.1]
+
+### Changed
+
+- Selected network controller should update all domains when perDomainNetwork feature flag is off ([#3834](https://github.com/MetaMask/controllers/pull/3834))
+
 ## [7.0.0]
+
 ### Changed
+
 - **BREAKING:** Bump `@metamask/network-controller` peer dependency to `^17.2.0` ([#3821](https://github.com/MetaMask/core/pull/3821))
@@ -19,3 +28,5 @@ - Bump `@metamask/swappable-obj-proxy` to `^2.2.0` ([#3784](https://github.com/MetaMask/core/pull/3784))
 ## [6.0.0]
+
 ### Changed
+
 - **BREAKING:** Bump `@metamask/network-controller` dependency and peer dependency from `^17.0.0` to `^17.1.0` ([#3695](https://github.com/MetaMask/core/pull/3695))
@@ -26,3 +37,5 @@ - Bump `@metamask/base-controller` to `^4.0.1` ([#3695](https://github.com/MetaMask/core/pull/3695))
 ## [5.0.0]
+
 ### Added
+
 - Add `SelectedNetworkMiddlewareJsonRpcRequest` type ([#1970](https://github.com/MetaMask/core/pull/1970)).
@@ -33,2 +46,3 @@ - Add `setPerDomainNetwork` method to reset proxies when flag toggled ([#3593](https://github.com/MetaMask/core/pull/3593)).
 ### Changed
+
 - **BREAKING:** Rename `SelectedNetworkControllerAction` to `SelectedNetworkControllerActions` and `SelectedNetworkControllerEvent` to `SelectedNetworkControllerEvents` for consistency with corresponding type exports from other controllers ([#1970](https://github.com/MetaMask/core/pull/1970)).
@@ -38,3 +52,5 @@ - **BREAKING:** `createSelectedNetworkMiddleware` return type is constrained to satisfy `JsonRpcMiddleware<JsonRpcParams, Json>`, and its `req` parameter is constrained to satisfy `SelectedNetworkMiddlewareJsonRpcRequest` ([#1970](https://github.com/MetaMask/core/pull/1970)).
 ## [4.0.0]
+
 ### Changed
+
 - **BREAKING:** Bump `@metamask/base-controller` to ^4.0.0 ([#2063](https://github.com/MetaMask/core/pull/2063))
@@ -45,14 +61,21 @@ - This is breaking because the type of the `messenger` has backward-incompatible changes. See the changelog for this package for more.
 ## [3.1.2]
+
 ### Changed
+
 - **BREAKING:** Bump dependency and peer dependency on `@metamask/network-controller` to ^16.0.0
 
 ## [3.1.1]
+
 ### Changed
+
 - Bump `@metamask/json-rpc-engine` from `^7.1.0` to `^7.2.0` ([#1895](https://github.com/MetaMask/core/pull/1895))
 
 ## [3.1.0]
+
 ### Added
+
 - Add `getProviderAndBlockTracker` method to get a proxy provider from `NetworkController` for a given origin/domain. ([#1806](https://github.com/MetaMask/core/pull/1806))
 
 ### Changed
+
 - No longer update `selectedNetworkClientId` when the `NetworkController` provider changes. ([#1806](https://github.com/MetaMask/core/pull/1806))
@@ -62,3 +85,5 @@ - Bump dependency and peer dependency on `@metamask/network-controller` to ^15.1.0
 ## [3.0.0]
+
 ### Changed
+
 - **BREAKING:** Bump dependency and peer dependency on `@metamask/network-controller` to ^14.0.0 ([#1747](https://github.com/MetaMask/core/pull/1747))
@@ -70,17 +95,25 @@ - **BREAKING:** Move from `json-rpc-engine` ^7.1.1 to `@metamask/json-rpc-engine` ^8.0.0 ([#1653](https://github.com/MetaMask/core/pull/1653))
 ### Fixed
+
 - `setNetworkClientIdForDomain()` will now ignore the passed in domain value and set the `networkClientId` for the metamask domain instead when the `state.perDomainNetwork` flag is false (default) ([#1757](https://github.com/MetaMask/core/pull/1757))
 
 ## [2.0.1]
+
 ### Changed
+
 - Update TypeScript to v4.8.x ([#1718](https://github.com/MetaMask/core/pull/1718))
 
 ## [2.0.0]
+
 ### Changed
+
 - **BREAKING**: Bump peer dependency on `@metamask/network-controller` to ^13.0.0 ([#1633](https://github.com/MetaMask/core/pull/1633))
 
 ## [1.0.0]
+
 ### Added
+
 - Initial Release ([#1643](https://github.com/MetaMask/core/pull/1643))
 
-[Unreleased]: https://github.com/MetaMask/core/compare/@metamask/selected-network-controller@7.0.0...HEAD
+[Unreleased]: https://github.com/MetaMask/core/compare/@metamask/selected-network-controller@7.0.1...HEAD
+[7.0.1]: https://github.com/MetaMask/core/compare/@metamask/selected-network-controller@7.0.0...@metamask/selected-network-controller@7.0.1
 [7.0.0]: https://github.com/MetaMask/core/compare/@metamask/selected-network-controller@6.0.0...@metamask/selected-network-controller@7.0.0
@@ -87,0 +120,0 @@ [6.0.0]: https://github.com/MetaMask/core/compare/@metamask/selected-network-controller@5.0.0...@metamask/selected-network-controller@6.0.0

dist/SelectedNetworkController.js

@@ -7,3 +7,3 @@ "use strict";
 };
-var _SelectedNetworkController_instances, _SelectedNetworkController_proxies, _SelectedNetworkController_registerMessageHandlers;
+var _SelectedNetworkController_instances, _SelectedNetworkController_proxies, _SelectedNetworkController_registerMessageHandlers, _SelectedNetworkController_setNetworkClientIdForDomain;
 Object.defineProperty(exports, "__esModule", { value: true });
@@ -57,22 +57,11 @@ exports.SelectedNetworkController = exports.SelectedNetworkControllerEventTypes = exports.SelectedNetworkControllerActionTypes = exports.controllerName = void 0;
     setNetworkClientIdForDomain(domain, networkClientId) {
-        const networkClient = this.messagingSystem.call('NetworkController:getNetworkClientById', networkClientId);
-        const networkProxy = __classPrivateFieldGet(this, _SelectedNetworkController_proxies, "f").get(domain);
-        if (networkProxy === undefined) {
-            __classPrivateFieldGet(this, _SelectedNetworkController_proxies, "f").set(domain, {
-                provider: (0, swappable_obj_proxy_1.createEventEmitterProxy)(networkClient.provider),
-                blockTracker: (0, swappable_obj_proxy_1.createEventEmitterProxy)(networkClient.blockTracker, {
-                    eventFilter: 'skipInternal',
-                }),
+        if (!this.state.perDomainNetwork) {
+            Object.entries(this.state.domains).forEach(([entryDomain, networkClientIdForDomain]) => {
+                if (networkClientIdForDomain !== networkClientId &&
+                    entryDomain !== domain) {
+                    __classPrivateFieldGet(this, _SelectedNetworkController_instances, "m", _SelectedNetworkController_setNetworkClientIdForDomain).call(this, entryDomain, networkClientId);
+                }
             });
         }
-        else {
-            networkProxy.provider.setTarget(networkClient.provider);
-            networkProxy.blockTracker.setTarget(networkClient.blockTracker);
-        }
-        this.update((state) => {
-            state.domains[domain] = networkClientId;
-            if (!state.perDomainNetwork) {
-                state.domains[METAMASK_DOMAIN] = networkClientId;
-            }
-        });
+        __classPrivateFieldGet(this, _SelectedNetworkController_instances, "m", _SelectedNetworkController_setNetworkClientIdForDomain).call(this, domain, networkClientId);
     }
@@ -120,3 +109,24 @@ getNetworkClientIdForDomain(domain) {
     this.messagingSystem.registerActionHandler(exports.SelectedNetworkControllerActionTypes.setNetworkClientIdForDomain, this.setNetworkClientIdForDomain.bind(this));
+}, _SelectedNetworkController_setNetworkClientIdForDomain = function _SelectedNetworkController_setNetworkClientIdForDomain(domain, networkClientId) {
+    const networkClient = this.messagingSystem.call('NetworkController:getNetworkClientById', networkClientId);
+    const networkProxy = __classPrivateFieldGet(this, _SelectedNetworkController_proxies, "f").get(domain);
+    if (networkProxy === undefined) {
+        __classPrivateFieldGet(this, _SelectedNetworkController_proxies, "f").set(domain, {
+            provider: (0, swappable_obj_proxy_1.createEventEmitterProxy)(networkClient.provider),
+            blockTracker: (0, swappable_obj_proxy_1.createEventEmitterProxy)(networkClient.blockTracker, {
+                eventFilter: 'skipInternal',
+            }),
+        });
+    }
+    else {
+        networkProxy.provider.setTarget(networkClient.provider);
+        networkProxy.blockTracker.setTarget(networkClient.blockTracker);
+    }
+    this.update((state) => {
+        state.domains[domain] = networkClientId;
+        if (!state.perDomainNetwork) {
+            state.domains[METAMASK_DOMAIN] = networkClientId;
+        }
+    });
 };
 //# sourceMappingURL=SelectedNetworkController.js.map

package.json

 {
   "name": "@metamask/selected-network-controller",
-  "version": "7.0.0",
+  "version": "7.0.1",
   "description": "Provides an interface to the currently selected networkClientId for a given domain",
@@ -5,0 +5,0 @@ "keywords": [

No alert changes

Improved metrics

Total package byte prevSize

44836

increased by4.98%

Lines of code

253

increased by4.12%

No dependency changes