@microsoft/ads-extension-telemetry - npm Package Compare versions

Comparing version 1.4.0 to 2.0.0

lib/telemetryReporter.d.ts

@@ -0,1 +1,2 @@
+import type * as azdataType from 'azdata';
 import { TimedAction } from './timedAction';
@@ -15,11 +16,2 @@ /**
 /**
- * Connection info properties to add into an event.
- */
-export interface TelemetryConnectionInfo {
-    authenticationType?: string;
-    providerName?: string;
-    serverType?: string;
-    engineType?: string;
-}
-/**
  * A telemetry event which can be sent at a later time.
@@ -46,3 +38,8 @@ */
      */
-    withConnectionInfo(connectionInfo: TelemetryConnectionInfo): TelemetryEvent;
+    withConnectionInfo(connectionInfo: azdataType.IConnectionProfile): TelemetryEvent;
+    /**
+     * Adds additional server-related information to this event.
+     * @param serverInfo The connection info to add. Only the fields in TelemetryConnectionInfo are included, all others are ignored.
+     */
+    withServerInfo(serverInfo: azdataType.ServerInfo): TelemetryEvent;
 }
@@ -49,0 +46,0 @@ export default class TelemetryReporter<V extends string = string, A extends string = string> {

lib/telemetryReporter.js

@@ -94,10 +94,20 @@ "use strict";
     withConnectionInfo(connectionInfo) {
+        // IMPORTANT - If making changes here the same changes should generally be made in the AdsTelemetryService version as well
         Object.assign(this.properties, {
             authenticationType: connectionInfo.authenticationType,
-            providerName: connectionInfo.providerName,
-            serverType: connectionInfo.serverType,
-            engineType: connectionInfo.engineType
+            providerName: connectionInfo.providerName
         });
         return this;
     }
+    withServerInfo(serverInfo) {
+        var _a, _b, _c;
+        // IMPORTANT - If making changes here the same changes should generally be made in the AdsTelemetryService version as well
+        Object.assign(this.properties, {
+            connectionType: (serverInfo === null || serverInfo === void 0 ? void 0 : serverInfo.isCloud) !== undefined ? (serverInfo.isCloud ? 'Azure' : 'Standalone') : '',
+            serverVersion: (_a = serverInfo === null || serverInfo === void 0 ? void 0 : serverInfo.serverVersion) !== null && _a !== void 0 ? _a : '',
+            serverEdition: (_b = serverInfo === null || serverInfo === void 0 ? void 0 : serverInfo.serverEdition) !== null && _b !== void 0 ? _b : '',
+            serverEngineEdition: (_c = serverInfo === null || serverInfo === void 0 ? void 0 : serverInfo.engineEditionId) !== null && _c !== void 0 ? _c : ''
+        });
+        return this;
+    }
 }
@@ -104,0 +114,0 @@ class TelemetryReporter {

package.json

 {
   "name": "@microsoft/ads-extension-telemetry",
   "description": "A module for first party Microsoft extensions to report consistent telemetry.",
-  "version": "1.4.0",
+  "version": "2.0.0",
   "author": {
@@ -24,3 +24,3 @@ "name": "Microsoft Corporation"
   "devDependencies": {
-    "@types/azdata": "^1.29.0",
+    "@types/azdata": "^1.41.0",
     "@types/node": "^8.0.24",
@@ -27,0 +27,0 @@ "standard-version": "^9.3.0",

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

37612

increased by2.88%

Lines of code

557

increased by1.27%

No dependency changes