@microsoft/atlas-js - npm Package Compare versions

Comparing version 1.5.2 to 1.5.3

dist/elements/form-behavior.d.ts

@@ -91,5 +91,5 @@ export declare const defaultMessageStrings: {
 export declare function setValidationMessage(element: HTMLValueElement, message: string): void;
-export declare function navigateAfterSubmit(href: string, navigationStep: NavigationSteps): void;
+export declare function navigateAfterSubmit(href: string | null, navigationStep: NavigationSteps): void;
 export declare function collectCustomElementsByName(form: HTMLFormElement): Element[];
 export {};
 //# sourceMappingURL=form-behavior.d.ts.map

dist/elements/form-behavior.js

@@ -103,5 +103,3 @@ import { generateElementId, kebabToCamelCase } from '../utilities/util';
     navigate(href) {
-        if (href) {
-            navigateAfterSubmit(href, this.getAttribute('navigation'));
-        }
+        navigateAfterSubmit(href, this.getAttribute('navigation'));
     }
@@ -309,3 +307,2 @@ scheduleCommit(event) {
             if (input.hasAttribute('data-skip-validation')) {
-                this.clearValidationErrors(input);
                 const validationErrorEvent = new CustomEvent('form-validating', {
@@ -312,0 +309,0 @@ detail: {

package.json

 {
 	"name": "@microsoft/atlas-js",
-	"version": "1.5.2",
+	"version": "1.5.3",
 	"public": true,
@@ -5,0 +5,0 @@ "description": "Scripts backing the Atlas Design System used by Microsoft's Developer Relations.",

src/elements/form-behavior.ts

@@ -129,5 +129,3 @@ import { generateElementId, kebabToCamelCase } from '../utilities/util';
 	navigate(href: string | null) {
-		if (href) {
-			navigateAfterSubmit(href, this.getAttribute('navigation') as NavigationSteps);
-		}
+		navigateAfterSubmit(href, this.getAttribute('navigation') as NavigationSteps);
 	}
@@ -389,3 +387,2 @@
 			if (input.hasAttribute('data-skip-validation')) {
-				this.clearValidationErrors(input);
 				const validationErrorEvent = new CustomEvent('form-validating', {
@@ -403,3 +400,2 @@ detail: {
 			const isCustomElement = !!customElements.find(el => el === input);
-
 			this.runBasicValidation(input, displayValidity, errors, errorList, isCustomElement);
@@ -692,3 +688,3 @@ const validationErrorEvent = new CustomEvent('form-validating', {
 
-export function navigateAfterSubmit(href: string, navigationStep: NavigationSteps) {
+export function navigateAfterSubmit(href: string | null, navigationStep: NavigationSteps) {
 	switch (navigationStep) {
@@ -695,0 +691,0 @@ case null:

No alert changes

Worsened metrics

Total package byte prevSize

62929

decreased by-0.19%

Lines of code

1601

decreased by-0.37%

No dependency changes