@microsoft/load-themed-styles - npm Package Compare versions

Comparing version 1.5.1 to 1.5.2

CHANGELOG.json

@@ -5,2 +5,14 @@ {
     {
+      "version": "1.5.2",
+      "tag": "@microsoft/load-themed-styles_v1.5.2",
+      "date": "Tue, 01 Aug 2017 01:03:49 GMT",
+      "comments": {
+        "patch": [
+          {
+            "comment": "Only warn for missing theme slots if DEBUG is true"
+          }
+        ]
+      }
+    },
+    {
       "version": "1.5.1",
@@ -7,0 +19,0 @@ "tag": "@microsoft/load-themed-styles_v1.5.1",

CHANGELOG.md

 # Change Log - @microsoft/load-themed-styles
 
-This log was last generated on Tue, 25 Jul 2017 20:03:31 GMT and should not be manually modified.
+This log was last generated on Tue, 01 Aug 2017 01:03:49 GMT and should not be manually modified.
 
+## 1.5.2
+Tue, 01 Aug 2017 01:03:49 GMT
+
+### Patches
+
+- Only warn for missing theme slots if DEBUG is true
+
 ## 1.5.1
@@ -6,0 +13,0 @@ Tue, 25 Jul 2017 20:03:31 GMT

lib-amd/index.js

@@ -199,5 +199,5 @@ /**
                 var defaultValue = currentValue.defaultValue || 'inherit';
-                // Warn to console if we hit an unthemed value even when themes are provided, unless "DEBUG" is false
+                // Warn to console if we hit an unthemed value even when themes are provided, but only if "DEBUG" is true.
                 // Allow the themedValue to be undefined to explicitly request the default value.
-                if (theme && !themedValue && console && !(themeSlot in theme) && (typeof DEBUG === 'undefined' || DEBUG)) {
+                if (theme && !themedValue && console && !(themeSlot in theme) && typeof DEBUG !== 'undefined' && DEBUG) {
                     console.warn("Theming value not provided for \"" + themeSlot + "\". Falling back to \"" + defaultValue + "\".");
@@ -204,0 +204,0 @@ }

lib/index.js

@@ -198,5 +198,5 @@ "use strict";
             var defaultValue = currentValue.defaultValue || 'inherit';
-            // Warn to console if we hit an unthemed value even when themes are provided, unless "DEBUG" is false
+            // Warn to console if we hit an unthemed value even when themes are provided, but only if "DEBUG" is true.
             // Allow the themedValue to be undefined to explicitly request the default value.
-            if (theme && !themedValue && console && !(themeSlot in theme) && (typeof DEBUG === 'undefined' || DEBUG)) {
+            if (theme && !themedValue && console && !(themeSlot in theme) && typeof DEBUG !== 'undefined' && DEBUG) {
                 console.warn("Theming value not provided for \"" + themeSlot + "\". Falling back to \"" + defaultValue + "\".");
@@ -203,0 +203,0 @@ }

package-deps.json

@@ -7,9 +7,9 @@ {
     "libraries/load-themed-styles/.vscode/tasks.json": "3567ff9ad0c5fefaa86e6986603360f58e88fcbf",
-    "libraries/load-themed-styles/CHANGELOG.json": "eda765912b8e4b73feea45b1f367d840d8108d23",
-    "libraries/load-themed-styles/CHANGELOG.md": "ac1f57063f7ea1247d03bad05db542d3927d82ad",
+    "libraries/load-themed-styles/CHANGELOG.json": "a5e3921e59802856ca401ce440ba5ead913780aa",
+    "libraries/load-themed-styles/CHANGELOG.md": "c058fc846832e6c62c409366a2e847a6f9de5083",
     "libraries/load-themed-styles/LICENSE": "0f3d654b877f682af760618b147fb6795728d9ba",
     "libraries/load-themed-styles/README.md": "ed0c394a7bffb55cac4c73330131b839683202f0",
     "libraries/load-themed-styles/gulpfile.js": "cb93beb5e7c4302a65ec8f1d98009ade6aa3bb3e",
-    "libraries/load-themed-styles/package.json": "e20d561816128733279a483cb79797d3802f88c3",
-    "libraries/load-themed-styles/src/index.ts": "9c6a84f5a91c1e798c7b93fec9f0f574e2a1b5af",
+    "libraries/load-themed-styles/package.json": "af312e0253f4134af4f4652d3102fca8a3c1d279",
+    "libraries/load-themed-styles/src/index.ts": "a60831db1992ebece88519aa2df82ca874bc1582",
     "libraries/load-themed-styles/src/tests/index.test.ts": "e574538d6c6bcbcc6fad30332a8a9742f5c3e81e",
@@ -23,21 +23,8 @@ "libraries/load-themed-styles/tsconfig.json": "f684b3ac2d0042eba5d74e319d8f5117f7927665",
     ".vscode/settings.json": "8f3de4698973d7ee6c92cc97eab2a3077d6dc7bb",
-    "README.md": "22ee21f5042b84f44f16145061feebdd90e4dfaa",
-    "common/changes/@microsoft/api-extractor/ianc-ts-2.4-upgrade_2017-07-24-18-50.json": "cb4ebbe08978c77d7a66804ce7211138f8daef6e",
-    "common/changes/@microsoft/gulp-core-build-karma/ianc-ts-2.4-upgrade_2017-07-24-18-50.json": "ae25e764d30627308ee77b6a26c6b37b296fd6f3",
-    "common/changes/@microsoft/gulp-core-build-mocha/ianc-ts-2.4-upgrade_2017-07-24-18-50.json": "60485a008fad04dae86fa3f4892778d743963e32",
-    "common/changes/@microsoft/gulp-core-build-sass/ianc-ts-2.4-upgrade_2017-07-24-18-50.json": "dcc16f46cfbcb702704d043378f941b27fce8f72",
-    "common/changes/@microsoft/gulp-core-build-serve/ianc-ts-2.4-upgrade_2017-07-24-18-50.json": "82a1074ce1e16b2d47cb2050b4be62d28ebd3b84",
-    "common/changes/@microsoft/gulp-core-build-typescript/ianc-ts-2.4-upgrade_2017-07-24-18-50.json": "d2af205fbee7f5e780602396649d08b2eb18ab35",
-    "common/changes/@microsoft/gulp-core-build-webpack/ianc-ts-2.4-upgrade_2017-07-24-18-50.json": "8f6e63039128bcf447a443ef4979d99a7c13463c",
-    "common/changes/@microsoft/gulp-core-build/ianc-ts-2.4-upgrade_2017-07-24-18-50.json": "7bdc63880111e1c23bc429c93b46d15d263cbae1",
-    "common/changes/@microsoft/load-themed-styles/ianc-ts-2.4-upgrade_2017-07-24-18-50.json": "1416ffc74a1cd5b99a064d7f763b392a5356e3f2",
-    "common/changes/@microsoft/loader-set-webpack-public-path/ianc-ts-2.4-upgrade_2017-07-24-18-50.json": "0fdd3190391415fca2191397ff126247d3105024",
-    "common/changes/@microsoft/node-library-build/ianc-ts-2.4-upgrade_2017-07-24-18-50.json": "4cea7a255ae369d08d4f8917b332931544595fdc",
-    "common/changes/@microsoft/stream-collator/ianc-ts-2.4-upgrade_2017-07-24-18-50.json": "c181c8cbcf563c3dd4d80fa1db7ad5121921fd8c",
-    "common/changes/@microsoft/ts-command-line/ianc-ts-2.4-upgrade_2017-07-24-18-50.json": "17897cd59764578aafa3b831c3fe4259a6d5833e",
-    "common/changes/@microsoft/web-library-build/ianc-ts-2.4-upgrade_2017-07-24-18-50.json": "aa041f263624d2bef5ae7398192c4e31eb1aafe8",
+    "README.md": "9f80ff74e335c27097427311a011a82043727ba3",
+    "common/changes/@microsoft/load-themed-styles/msilver-theme-slot-warning-debug-only_2017-07-28-23-44.json": "f500b4f131e7bd023ed514ea8d89080f4fc5a11d",
     "common/config/rush/.npmrc": "f6a02f2d9a7ba7a7d59198f0a4eb89cc481c01a6",
     "common/config/rush/browser-approved-packages.json": "607bec405725280ea6adbfe4c738dfb5016b6d8c",
-    "common/config/rush/nonbrowser-approved-packages.json": "6fbd1017c29692ac53be7280989e7057448503e6",
-    "common/config/rush/npm-shrinkwrap.json": "f85243fa905f46c75fc2621f608c32bf993bffdc",
+    "common/config/rush/nonbrowser-approved-packages.json": "def0b9ddd6d8bbbba6c26990d60d65e7b5f18104",
+    "common/config/rush/npm-shrinkwrap.json": "d46daeab5a4309a735922604ff54286123dbe264",
     "common/reviews/api/api-extractor.api.ts": "94a9224231be9976687277e310dcb13cd03e2bec",
@@ -49,17 +36,18 @@ "common/reviews/api/decorators.api.ts": "da3142830231162beb36d87461e23c42c25eed83",
     "common/reviews/api/gulp-core-build-serve.api.ts": "d55b52cba46f786d962a240f9d6e35c7d3e339b2",
-    "common/reviews/api/gulp-core-build-typescript.api.ts": "ceb662ad163fb5f702ed372bb4ed6eb7fdb9b984",
-    "common/reviews/api/gulp-core-build-webpack.api.ts": "8f344e12286f6601de59988b56004a576a54ccbe",
-    "common/reviews/api/gulp-core-build.api.ts": "ecda866bd5b2e1330bf0ca40ce54ad8d44c696b8",
+    "common/reviews/api/gulp-core-build-typescript.api.ts": "9278909ca625df6fc50962c3e6eea32329432bfa",
+    "common/reviews/api/gulp-core-build-webpack.api.ts": "1835af88186f27d36e2543ba7e20f7fece8ac249",
+    "common/reviews/api/gulp-core-build.api.ts": "dbb0036c603c31dced78277b4aebf8ace1baa0a8",
     "common/reviews/api/node-core-library.api.ts": "083ac6fc738c8a01b8225d5212f207765e65514e",
-    "common/reviews/api/node-library-build.api.ts": "6d8da4bd0571d04fcd685ff0e319b30eb25cea95",
+    "common/reviews/api/node-library-build.api.ts": "cf9006707c6b17e991a3caf004d061b80f472840",
     "common/reviews/api/package-deps-hash.api.ts": "848fd5d74ef5920b51288ba15c890e953299f4ae",
     "common/reviews/api/rush-lib.api.ts": "ea5144cec02fc5fc8ff95e906ae754a36679ee73",
+    "common/reviews/api/set-webpack-public-path-plugin.api.ts": "5aeb7af3cc752d3df7064c03e187cee305b1b4cd",
     "common/reviews/api/test-web-library-build.api.ts": "daa3ac892a9d22a6844be649d84a739be0c16210",
-    "common/reviews/api/web-library-build.api.ts": "5e45cc9b01ff63b7782c4bff6bd2df8561b3678e",
+    "common/reviews/api/web-library-build.api.ts": "b7771970d65564fa7df99c59fb8aaecfe9d07573",
     "common/scripts/InstallRushOnlyIfNeeded.js": "67ff1de8ea7156ae1e49c3b123820ea7d852efa5",
     "common/wiki-images/api-extractor-title.png": "2a13a21caa560dec94d07aec6758b112739dc0c0",
     "common/wiki-images/rush-logo.png": "a792c69862528476d4597fdffe07d8e4134c0a5a",
-    "rush.json": "661de6f80faae3f292531ecd55b26e4ffee89072"
+    "rush.json": "de2920e8fe8d38c4c39a20fed998fcd4df683e65"
   },
   "arguments": "gulp test --no-color --production"
 }

package.json

 {
   "name": "@microsoft/load-themed-styles",
-  "version": "1.5.1",
+  "version": "1.5.2",
   "description": "Loads themed styles.",
@@ -24,4 +24,4 @@ "license": "MIT",
     "gulp": "~3.9.1",
-    "@microsoft/node-library-build": "~3.2.0"
+    "@microsoft/node-library-build": "~3.2.2"
   }
 }

src/index.ts

@@ -279,5 +279,5 @@ /**
 
-      // Warn to console if we hit an unthemed value even when themes are provided, unless "DEBUG" is false
+      // Warn to console if we hit an unthemed value even when themes are provided, but only if "DEBUG" is true.
       // Allow the themedValue to be undefined to explicitly request the default value.
-      if (theme && !themedValue && console && !(themeSlot in theme) && (typeof DEBUG === 'undefined' || DEBUG)) {
+      if (theme && !themedValue && console && !(themeSlot in theme) && typeof DEBUG !== 'undefined' && DEBUG) {
         console.warn(`Theming value not provided for "${themeSlot}". Falling back to "${defaultValue}".`);
@@ -284,0 +284,0 @@ }

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Worsened metrics

Total package byte prevSize

119599

decreased by-0.95%

No dependency changes