@microsoft/rush-lib - npm Package Compare versions

Comparing version 3.0.18 to 3.0.19

CHANGELOG.json

@@ -5,2 +5,23 @@ {
     {
+      "version": "3.0.19",
+      "tag": "@microsoft/rush-lib_v3.0.19",
+      "date": "Fri, 06 Oct 2017 22:44:31 GMT",
+      "comments": {
+        "patch": [
+          {
+            "comment": "Enable strickNullChecks"
+          },
+          {
+            "comment": "Fix a bug in \"rush version\" that devdependency does not get bumped if there is no dependency. "
+          },
+          {
+            "comment": "Fix a bug in \"rush change\" so it handles rename properly. "
+          },
+          {
+            "comment": "Add npm tag support in \"rush publish\". "
+          }
+        ]
+      }
+    },
+    {
       "version": "3.0.18",
@@ -7,0 +28,0 @@ "tag": "@microsoft/rush-lib_v3.0.18",

CHANGELOG.md

 # Change Log - @microsoft/rush-lib
 
-This log was last generated on Tue, 26 Sep 2017 20:25:51 GMT and should not be manually modified.
+This log was last generated on Fri, 06 Oct 2017 22:50:11 GMT and should not be manually modified.
 
+## 3.0.19
+Fri, 06 Oct 2017 22:44:31 GMT
+
+### Patches
+
+- Enable strickNullChecks
+- Fix a bug in "rush version" that devdependency does not get bumped if there is no dependency. 
+- Fix a bug in "rush change" so it handles rename properly. 
+- Add npm tag support in "rush publish". 
+
 ## 3.0.18
@@ -6,0 +16,0 @@ Tue, 26 Sep 2017 13:51:05 GMT

lib/data/ApprovedPackagesConfiguration.d.ts

@@ -46,3 +46,3 @@ /**
     clear(): void;
-    getItemByName(packageName: string): ApprovedPackagesItem;
+    getItemByName(packageName: string): ApprovedPackagesItem | undefined;
     addOrUpdatePackage(packageName: string, reviewCategory: string): void;
@@ -49,0 +49,0 @@ /**

lib/data/ChangeFile.js

@@ -82,15 +82,18 @@ "use strict";
         const matches = dateString.match(dateParseRegex);
-        // formattedDate === "2016-10-19"
-        const formattedDate = matches[1];
-        let formattedTime;
-        if (useSeconds) {
-            // formattedTime === "22-47-49"
-            formattedTime = matches[2].replace(':', '-');
+        if (matches) {
+            // formattedDate === "2016-10-19"
+            const formattedDate = matches[1];
+            let formattedTime;
+            if (useSeconds) {
+                // formattedTime === "22-47-49"
+                formattedTime = matches[2].replace(':', '-');
+            }
+            else {
+                // formattedTime === "22-47"
+                const timeParts = matches[2].split(':');
+                formattedTime = `${timeParts[0]}-${timeParts[1]}`;
+            }
+            return `${formattedDate}-${formattedTime}`;
         }
-        else {
-            // formattedTime === "22-47"
-            const timeParts = matches[2].split(':');
-            formattedTime = `${timeParts[0]}-${timeParts[1]}`;
-        }
-        return `${formattedDate}-${formattedTime}`;
+        return undefined;
     }
@@ -97,0 +100,0 @@ _escapeFilename(filename, replacer = '-') {

lib/data/Changelog.d.ts

@@ -34,3 +34,3 @@ /**
      */
-    date: string;
+    date: string | undefined;
     /**
@@ -37,0 +37,0 @@ * Comments for the entry, where key respresents the ChangeType string (Example: major)

lib/data/ChangeManagement.d.ts

@@ -8,3 +8,3 @@ /**
     packageName: string;
-    email: string;
+    email: string | undefined;
 }
@@ -11,0 +11,0 @@ /**

lib/data/PinnedVersionsConfiguration.d.ts

@@ -22,3 +22,3 @@ /**
     set(dependency: string, version: string): this;
-    get(dependency: string): string;
+    get(dependency: string): string | undefined;
     has(dependency: string): boolean;
@@ -25,0 +25,0 @@ forEach(cb: (version: string, dependency: string) => void): this;

lib/data/PinnedVersionsConfiguration.js

@@ -29,5 +29,7 @@ "use strict";
         this._data = new Map();
-        Object.keys(pinnedVersionJson || {}).forEach((dep) => {
-            this.set(dep, pinnedVersionJson[dep]);
-        });
+        if (pinnedVersionJson) {
+            for (const dependency of Object.keys(pinnedVersionJson)) {
+                this.set(dependency, pinnedVersionJson[dependency]);
+            }
+        }
     }
@@ -34,0 +36,0 @@ /** Attempts to load pinned versions configuration from a given file */

lib/data/RushConfiguration.d.ts

@@ -265,3 +265,3 @@ import RushConfigurationProject, { IRushConfigurationProjectJson } from './RushConfigurationProject';
      */
-    getProjectByName(projectName: string): RushConfigurationProject;
+    getProjectByName(projectName: string): RushConfigurationProject | undefined;
     /**
@@ -273,3 +273,3 @@ * This is used e.g. by command-line interfaces such as "rush build --to example".
      */
-    findProjectByShorthandName(shorthandProjectName: string): RushConfigurationProject;
+    findProjectByShorthandName(shorthandProjectName: string): RushConfigurationProject | undefined;
     /**
@@ -276,0 +276,0 @@ * Looks up a project by its RushConfigurationProject.tempProjectName field.

lib/data/RushConfiguration.js

@@ -113,9 +113,11 @@ "use strict";
             const tempProjectName = tempNamesByProject.get(projectJson);
-            const project = new RushConfigurationProject_1.default(projectJson, this, tempProjectName);
-            this._projects.push(project);
-            if (this._projectsByName.get(project.packageName)) {
-                throw new Error(`The project name "${project.packageName}" was specified more than once`
-                    + ` in the rush.json configuration file.`);
+            if (tempProjectName) {
+                const project = new RushConfigurationProject_1.default(projectJson, this, tempProjectName);
+                this._projects.push(project);
+                if (this._projectsByName.get(project.packageName)) {
+                    throw new Error(`The project name "${project.packageName}" was specified more than once`
+                        + ` in the rush.json configuration file.`);
+                }
+                this._projectsByName.set(project.packageName, project);
             }
-            this._projectsByName.set(project.packageName, project);
         }
@@ -122,0 +124,0 @@ for (const project of this._projects) {

lib/data/RushConfigurationProject.d.ts

@@ -97,3 +97,3 @@ import IPackageJson from '../utilities/IPackageJson';
      */
-    readonly versionPolicyName: string;
+    readonly versionPolicyName: string | undefined;
 }

lib/data/VersionMismatchFinder.d.ts

@@ -11,4 +11,4 @@ import RushConfigurationProject from './RushConfigurationProject';
     getMismatches(): Array<string>;
-    getVersionsOfMismatch(mismatch: string): Array<string>;
-    getConsumersOfMismatch(mismatch: string, version: string): Array<string>;
+    getVersionsOfMismatch(mismatch: string): Array<string> | undefined;
+    getConsumersOfMismatch(mismatch: string, version: string): Array<string> | undefined;
     private _analyze();
@@ -15,0 +15,0 @@ private _addDependenciesToList(project, dependencyMap, exclude);

lib/data/VersionMismatchFinder.js

@@ -47,14 +47,17 @@ "use strict";
     _addDependenciesToList(project, dependencyMap, exclude) {
-        Object.keys(dependencyMap || {}).forEach((dependency) => {
-            if (!exclude || !exclude.has(dependency)) {
-                const version = dependencyMap[dependency];
-                if (!this._mismatches.has(dependency)) {
-                    this._mismatches.set(dependency, new Map());
+        if (dependencyMap) {
+            Object.keys(dependencyMap).forEach((dependency) => {
+                if (!exclude || !exclude.has(dependency)) {
+                    const version = dependencyMap[dependency];
+                    if (!this._mismatches.has(dependency)) {
+                        this._mismatches.set(dependency, new Map());
+                    }
+                    const dependencyVersions = this._mismatches.get(dependency);
+                    if (!dependencyVersions.has(version)) {
+                        dependencyVersions.set(version, []);
+                    }
+                    dependencyVersions.get(version).push(project);
                 }
-                if (!this._mismatches.get(dependency).has(version)) {
-                    this._mismatches.get(dependency).set(version, []);
-                }
-                this._mismatches.get(dependency).get(version).push(project);
-            }
-        });
+            });
+        }
     }
@@ -64,6 +67,8 @@ // tslint:disable-next-line:no-any
         const keys = [];
-        // tslint:disable-next-line:no-any
-        iterable.forEach((value, key) => {
-            keys.push(key);
-        });
+        if (iterable) {
+            // tslint:disable-next-line:no-any
+            iterable.forEach((value, key) => {
+                keys.push(key);
+            });
+        }
         return keys;
@@ -70,0 +75,0 @@ }

lib/data/VersionPolicy.d.ts

@@ -36,3 +36,3 @@ import * as semver from 'semver';
      */
-    static load(versionPolicyJson: IVersionPolicyJson): VersionPolicy;
+    static load(versionPolicyJson: IVersionPolicyJson): VersionPolicy | undefined;
     constructor(versionPolicyJson: IVersionPolicyJson);
@@ -39,0 +39,0 @@ /**

lib/data/VersionPolicy.js

@@ -191,3 +191,3 @@ "use strict";
             const version = new semver.SemVer(project.version);
-            if (version.major < this._lockedMajor) {
+            if (version.major < this.lockedMajor) {
                 const updatedProject = lodash_1.cloneDeep(project);
@@ -197,3 +197,3 @@ updatedProject.version = `${this._lockedMajor}.0.0`;
             }
-            else if (version.major > this._lockedMajor) {
+            else if (version.major > this.lockedMajor) {
                 const errorMessage = `Version ${project.version} in package ${project.name}`
@@ -200,0 +200,0 @@ + ` is higher than locked major version ${this._lockedMajor}.`;

lib/errorDetection/ErrorDetector.d.ts

@@ -14,3 +14,3 @@ import TaskError from './TaskError';
 export interface IErrorDetectionRule {
-    (line: string): TaskError;
+    (line: string): TaskError | undefined;
 }
@@ -21,3 +21,3 @@ /**
  */
-export declare function RegexErrorDetector(regex: RegExp, getError: (match: RegExpExecArray) => TaskError): IErrorDetectionRule;
+export declare function RegexErrorDetector(regex: RegExp, getError: (match: RegExpExecArray) => TaskError | undefined): IErrorDetectionRule;
 /**
@@ -24,0 +24,0 @@ * The error detector will find all errors in a chunk of text by running a number

lib/utilities/VersionControl.d.ts

@@ -5,3 +5,3 @@ /**
 export default class VersionControl {
-    static getChangedFolders(targetBranch?: string): string[];
+    static getChangedFolders(targetBranch?: string): Array<string | undefined> | undefined;
     static getChangedFiles(prefix?: string, targetBranch?: string): string[];
@@ -8,0 +8,0 @@ /**

lib/utilities/VersionControl.js

@@ -27,3 +27,3 @@ "use strict";
         const output = child_process
-            .execSync(`git diff ${branchName}... --name-only --diff-filter=A`)
+            .execSync(`git diff ${branchName}... --name-only --no-renames --diff-filter=A`)
             .toString();
@@ -34,3 +34,3 @@ const regex = prefix ? new RegExp(`^${prefix}`, 'i') : undefined;
                 const trimmedLine = s.trim();
-                if (trimmedLine.match(regex)) {
+                if (regex && trimmedLine.match(regex)) {
                     return trimmedLine;
@@ -37,0 +37,0 @@ }

package.json

 {
   "name": "@microsoft/rush-lib",
-  "version": "3.0.18",
+  "version": "3.0.19",
   "description": "A library for writing scripts that interact with the Rush tool",
@@ -19,3 +19,3 @@ "repository": {
   "dependencies": {
-    "@microsoft/node-core-library": "~0.3.0",
+    "@microsoft/node-core-library": "~0.3.3",
     "@microsoft/stream-collator": "~2.1.0",
@@ -34,3 +34,3 @@ "@types/fs-extra": "0.0.37",
   "devDependencies": {
-    "@microsoft/node-library-build": "~4.1.0",
+    "@microsoft/node-library-build": "~4.1.2",
     "chai": "~3.5.0",
@@ -37,0 +37,0 @@ "gulp": "~3.9.1",

No alert changes

Improved metrics

Total package byte prevSize

382051

increased by0.72%

Lines of code

4796

increased by0.69%

Dependency changes

• Updated@microsoft/node-core-library@~0.3.3