@ministryofjustice/fb-jwt-client-node - npm Package Compare versions

Comparing version 0.0.21-gamma to 0.0.22

lib/fb-jwt-client.js

@@ -274,6 +274,2 @@ const request = require('request-promise-native')
   handleRequestError (err) {
-    console.log('JWTCLIENT handleRequestError', err.name, this.ErrorClass.name)
-    if (err.error) {
-      console.log('err.error', err.error)
-    }
     // rethrow error if already client error
@@ -289,3 +285,7 @@ if (err.name === this.ErrorClass.name) {
       } else {
-        this.throwRequestError(statusCode)
+        let message
+        if (err.error) {
+          message = err.error.name || err.error.code || 'EUNSPECIFIED'
+        }
+        this.throwRequestError(statusCode, message)
       }
@@ -325,4 +325,3 @@ } else if (err.error) {
     message = message || code
-    console.log('throwRequestError - BLIMEY', code, message, new this.ErrorClass(message, {
-      message,
+    throw new this.ErrorClass({
       error: {
@@ -332,9 +331,2 @@ code,
       }
-    }))
-    throw new this.ErrorClass(message, {
-      message,
-      error: {
-        code,
-        message
-      }
     })
@@ -341,0 +333,0 @@ }

lib/fb-jwt-client.unit.spec.js

@@ -423,2 +423,63 @@ const test = require('tape')
 
+test('When making a request and both a status code and an error object containing a name are present', async t => {
+  t.plan(1)
+  const stubRequest = stub(request, 'get')
+  stubRequest.callsFake(options => {
+    let error = new Error()
+    error.statusCode = 400
+    error.error = {
+      name: 'e.error.name',
+      code: 400
+    }
+    return Promise.reject(error)
+  })
+
+  try {
+    await jwtClient.sendGet('/url', {})
+  } catch (e) {
+    t.equals(e.message, 'e.error.name', 'it should use the name specified in the error object as the message')
+  }
+  stubRequest.restore()
+})
+
+test('When making a request and both a status code and an error object with a code but no name are present', async t => {
+  t.plan(1)
+  const stubRequest = stub(request, 'get')
+  stubRequest.callsFake(options => {
+    let error = new Error()
+    error.statusCode = 400
+    error.error = {
+      code: 409
+    }
+    return Promise.reject(error)
+  })
+
+  try {
+    await jwtClient.sendGet('/url', {})
+  } catch (e) {
+    t.equals(e.message, 409, 'it should use the code specified in the error object as the message')
+  }
+  stubRequest.restore()
+})
+
+test('When making a request and both a status code and an error object with no name and no code are present', async t => {
+  t.plan(1)
+  const stubRequest = stub(request, 'get')
+  stubRequest.callsFake(options => {
+    let error = new Error()
+    error.statusCode = 400
+    error.error = {
+      foo: 409
+    }
+    return Promise.reject(error)
+  })
+
+  try {
+    await jwtClient.sendGet('/url', {})
+  } catch (e) {
+    t.equals(e.message, 'EUNSPECIFIED', 'it should use ‘EUNSPECIFIED‘ as the message')
+  }
+  stubRequest.restore()
+})
+
 // Rethrow errors
@@ -425,0 +486,0 @@

package.json

 {
   "name": "@ministryofjustice/fb-jwt-client-node",
-  "version": "0.0.21-gamma",
+  "version": "0.0.22",
   "description": "Form Builder JSON Web Token Client (Node)",
@@ -5,0 +5,0 @@ "main": "lib/fb-jwt-client.js",

New alerts

Deprecated

Maintenance

The maintainer of the package marked it as deprecated. This could indicate that a single version should not be used, or that the package is no longer maintained and any new vulnerabilities will not be fixed.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

36532

increased by4.13%

Lines of code

920

increased by5.38%

Worsened metrics

Number of medium maintenance alerts

1

increased byInfinity%

No dependency changes