@mozilla/nimbus-shared - npm Package Compare versions

Comparing version 1.4.0 to 1.5.0

CHANGELOG.md

 # Changelog
 
+## Version 1.5.0
+
+### Minor Changes
+
+- Make `featureConfig` required
+
 ## Version 1.4.0
@@ -4,0 +10,0 @@

dist/data.json

@@ -37,3 +37,3 @@ {
               "enabled": true,
-              "value": null
+              "value": {}
             }
@@ -47,3 +47,3 @@ },
               "enabled": true,
-              "value": null
+              "value": {}
             }
@@ -717,3 +717,3 @@ }
             "enabled": true,
-            "value": null
+            "value": {}
           }
@@ -727,3 +727,3 @@ },
             "enabled": true,
-            "value": null
+            "value": {}
           }
@@ -767,3 +767,3 @@ }
             "enabled": true,
-            "value": null
+            "value": {}
           }
@@ -777,3 +777,3 @@ },
             "enabled": true,
-            "value": null
+            "value": {}
           }
@@ -780,0 +780,0 @@ }

dist/data/ExperimentDesignPresets.js

@@ -12,7 +12,7 @@ "use strict";
             branches: [
-                { slug: "control", ratio: 1, feature: { featureId: "cfr", enabled: true, value: null } },
+                { slug: "control", ratio: 1, feature: { featureId: "cfr", enabled: true, value: {} } },
                 {
                     slug: "treatment",
                     ratio: 1,
-                    feature: { featureId: "cfr", enabled: true, value: null },
+                    feature: { featureId: "cfr", enabled: true, value: {} },
                 },
@@ -19,0 +19,0 @@ ],

dist/src/_generated/data.d.ts

@@ -36,3 +36,3 @@ export declare const data: {
                         enabled: boolean;
-                        value: null;
+                        value: {};
                     };
@@ -324,3 +324,3 @@ }[];
                     enabled: boolean;
-                    value: null;
+                    value: {};
                 };
@@ -360,3 +360,3 @@ }[];
                     enabled: boolean;
-                    value: null;
+                    value: {};
                 };
@@ -363,0 +363,0 @@ }[];

dist/src/_generated/data.js

@@ -19,7 +19,7 @@ "use strict";
                         "slug": "control", "ratio": 1, "feature": {
-                            "featureId": "cfr", "enabled": true, "value": null
+                            "featureId": "cfr", "enabled": true, "value": {}
                         }
                     }, {
                         "slug": "treatment", "ratio": 1, "feature": {
-                            "featureId": "cfr", "enabled": true, "value": null
+                            "featureId": "cfr", "enabled": true, "value": {}
                         }
@@ -397,7 +397,7 @@ }
                     "slug": "control", "ratio": 1, "feature": {
-                        "featureId": "bookmarkId", "enabled": true, "value": null
+                        "featureId": "bookmarkId", "enabled": true, "value": {}
                     }
                 }, {
                     "slug": "treatment-variation-b", "ratio": 1, "feature": {
-                        "featureId": "bookmarkId", "enabled": true, "value": null
+                        "featureId": "bookmarkId", "enabled": true, "value": {}
                     }
@@ -414,7 +414,7 @@ }
                     "slug": "control", "ratio": 1, "feature": {
-                        "featureId": "cfr", "enabled": true, "value": null
+                        "featureId": "cfr", "enabled": true, "value": {}
                     }
                 }, {
                     "slug": "treatment-variation-b", "ratio": 1, "feature": {
-                        "featureId": "cfr", "enabled": true, "value": null
+                        "featureId": "cfr", "enabled": true, "value": {}
                     }
@@ -421,0 +421,0 @@ }

dist/types/experiments.d.ts

@@ -126,3 +126,3 @@ /**
         [key: string]: unknown;
-    } | null;
+    };
 }
@@ -139,3 +139,3 @@ interface Branch {
     ratio: number;
-    feature?: FeatureConfig;
+    feature: FeatureConfig;
 }
@@ -142,0 +142,0 @@ interface Outcome {

package.json

 {
   "name": "@mozilla/nimbus-shared",
-  "version": "1.4.0",
+  "version": "1.5.0",
   "license": "MPL-2.0",
@@ -5,0 +5,0 @@ "engines": {

schemas/experiments/NimbusExperiment.json

@@ -143,11 +143,4 @@ {
                   "value": {
-                    "anyOf": [
-                      {
-                        "type": "object",
-                        "additionalProperties": {}
-                      },
-                      {
-                        "type": "null"
-                      }
-                    ],
+                    "type": "object",
+                    "additionalProperties": {},
                     "description": "Optional extra params for the feature (this should be validated against a schema)"
@@ -165,3 +158,4 @@ }
               "slug",
-              "ratio"
+              "ratio",
+              "feature"
             ]
@@ -168,0 +162,0 @@ },

src/_generated/data.ts

@@ -16,7 +16,7 @@ export const data = {
                         "slug": "control", "ratio": 1, "feature": {
-                            "featureId": "cfr", "enabled": true, "value": null
+                            "featureId": "cfr", "enabled": true, "value": {}
                         }
                     }, {
                         "slug": "treatment", "ratio": 1, "feature": {
-                            "featureId": "cfr", "enabled": true, "value": null
+                            "featureId": "cfr", "enabled": true, "value": {}
                         }
@@ -394,7 +394,7 @@ }
                     "slug": "control", "ratio": 1, "feature": {
-                        "featureId": "bookmarkId", "enabled": true, "value": null
+                        "featureId": "bookmarkId", "enabled": true, "value": {}
                     }
                 }, {
                     "slug": "treatment-variation-b", "ratio": 1, "feature": {
-                        "featureId": "bookmarkId", "enabled": true, "value": null
+                        "featureId": "bookmarkId", "enabled": true, "value": {}
                     }
@@ -411,7 +411,7 @@ }
                     "slug": "control", "ratio": 1, "feature": {
-                        "featureId": "cfr", "enabled": true, "value": null
+                        "featureId": "cfr", "enabled": true, "value": {}
                     }
                 }, {
                     "slug": "treatment-variation-b", "ratio": 1, "feature": {
-                        "featureId": "cfr", "enabled": true, "value": null
+                        "featureId": "cfr", "enabled": true, "value": {}
                     }
@@ -418,0 +418,0 @@ }

types/experiments.ts

@@ -154,3 +154,3 @@ /**
   /** Optional extra params for the feature (this should be validated against a schema) */
-  value: { [key: string]: unknown } | null;
+  value: { [key: string]: unknown };
 }
@@ -170,3 +170,3 @@
 
-  feature?: FeatureConfig;
+  feature: FeatureConfig;
 }
@@ -173,0 +173,0 @@

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Worsened metrics

Total package byte prevSize

598640

decreased by-0.18%

Lines of code

12445

decreased by-0.18%

No dependency changes