@netflix/x-element - npm Package Compare versions

Comparing version 1.0.0-rc.56 to 1.0.0-rc.57

package.json

@@ -5,3 +5,3 @@ {
   "description": "Custom Element base class.",
-  "version": "1.0.0-rc.56",
+  "version": "1.0.0-rc.57",
   "license": "SEE LICENSE IN LICENSE",
@@ -30,7 +30,7 @@ "repository": "https://github.com/Netflix/x-element",
   "devDependencies": {
-    "eslint": "^8.35.0",
+    "eslint": "^8.47.0",
     "http-server": "^14.1.1",
-    "puppeteer": "^19.7.5",
-    "tap-parser": "^12.0.1"
+    "puppeteer": "^21.0.3",
+    "tap-parser": "^13.0.1"
   }
 }

test/test-basic-properties.js

@@ -253,2 +253,15 @@ import XElement from '../x-element.js';
 
+it('numeric properties deserialize "" (empty) to "NaN"', () => {
+  const el = document.createElement('test-element');
+  el.setAttribute('numeric-property', '0');
+  document.body.append(el);
+  assert(el.numericProperty === 0, '"0" was coerced to 0');
+  el.setAttribute('numeric-property', '');
+  assert(Number.isNaN(el.numericProperty), '"" was coerced to NaN');
+  el.setAttribute('numeric-property', ' ');
+  assert(Number.isNaN(el.numericProperty), '" " was coerced to NaN');
+  el.setAttribute('numeric-property', '      ');
+  assert(Number.isNaN(el.numericProperty), '"      " was coerced to NaN');
+});
+
 it('cannot set to known properties', () => {
@@ -255,0 +268,0 @@ class BadTestElement extends XElement {

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

269964

increased by0.31%

Lines of code

6951

increased by0.26%

No dependency changes