@ngx-loading-bar/core - npm Package Compare versions

Comparing version 1.0.0-alpha.10 to 1.0.0-alpha.11

@ngx-loading-bar/core.es5.js

@@ -11,6 +11,5 @@ import { Component, Injectable, Input, NgModule } from '@angular/core';
     /**
-     * @param {?=} source$
      * @return {?}
      */
-    LoadingBarService.prototype.startLoading = function (source$) {
+    LoadingBarService.prototype.start = function () {
         this.pending.next({
@@ -20,7 +19,2 @@ started: this._pendingRequests === 0,
         });
-        if (source$) {
-            source$ = share$1.call(source$);
-            source$.subscribe(this.getLoadingObserver());
-            return source$;
-        }
     };
@@ -30,3 +24,3 @@ /**
      */
-    LoadingBarService.prototype.endLoading = function () {
+    LoadingBarService.prototype.complete = function () {
         if (this._pendingRequests === 0) {
@@ -41,10 +35,32 @@ return;
     /**
+     * @param {?=} source$
      * @return {?}
      */
+    LoadingBarService.prototype.startLoading = function (source$) {
+        console.warn("LoadingBarService: 'startLoading' is deprecated and will removed in the next version use 'start' instead.");
+        this.start();
+        if (source$) {
+            console.warn("LoadingBarService: passing 'source$' to 'startLoading' is deprecated and will removed in the next version.");
+            source$ = share$1.call(source$);
+            source$.subscribe(this.getLoadingObserver());
+            return source$;
+        }
+    };
+    /**
+     * @return {?}
+     */
+    LoadingBarService.prototype.endLoading = function () {
+        console.warn("LoadingBarService: 'endLoading' is deprecated and will removed in the next version use 'complete' instead.");
+        this.complete();
+    };
+    /**
+     * @return {?}
+     */
     LoadingBarService.prototype.getLoadingObserver = function () {
         var _this = this;
+        console.warn("LoadingBarService: 'getLoadingObserver' is deprecated and will removed in the next version.");
         return {
             next: function (x) { return x; },
-            error: function (err) { return _this.endLoading(); },
-            complete: function () { return _this.endLoading(); },
+            error: function (err) { return _this.complete(); },
+            complete: function () { return _this.complete(); },
         };
@@ -51,0 +67,0 @@ };

@ngx-loading-bar/core.js

@@ -12,6 +12,5 @@ import { Component, Injectable, Input, NgModule } from '@angular/core';
     /**
-     * @param {?=} source$
      * @return {?}
      */
-    startLoading(source$) {
+    start() {
         this.pending.next({
@@ -21,7 +20,2 @@ started: this._pendingRequests === 0,
         });
-        if (source$) {
-            source$ = share$1.call(source$);
-            source$.subscribe(this.getLoadingObserver());
-            return source$;
-        }
     }
@@ -31,3 +25,3 @@ /**
      */
-    endLoading() {
+    complete() {
         if (this._pendingRequests === 0) {
@@ -42,9 +36,31 @@ return;
     /**
+     * @param {?=} source$
      * @return {?}
      */
+    startLoading(source$) {
+        console.warn(`LoadingBarService: 'startLoading' is deprecated and will removed in the next version use 'start' instead.`);
+        this.start();
+        if (source$) {
+            console.warn(`LoadingBarService: passing 'source$' to 'startLoading' is deprecated and will removed in the next version.`);
+            source$ = share$1.call(source$);
+            source$.subscribe(this.getLoadingObserver());
+            return source$;
+        }
+    }
+    /**
+     * @return {?}
+     */
+    endLoading() {
+        console.warn(`LoadingBarService: 'endLoading' is deprecated and will removed in the next version use 'complete' instead.`);
+        this.complete();
+    }
+    /**
+     * @return {?}
+     */
     getLoadingObserver() {
+        console.warn(`LoadingBarService: 'getLoadingObserver' is deprecated and will removed in the next version.`);
         return {
             next: (x) => x,
-            error: (err) => this.endLoading(),
-            complete: () => this.endLoading(),
+            error: (err) => this.complete(),
+            complete: () => this.complete(),
         };
@@ -51,0 +67,0 @@ }

bundles/core.umd.js

@@ -13,6 +13,5 @@ (function (global, factory) {
     /**
-     * @param {?=} source$
      * @return {?}
      */
-    LoadingBarService.prototype.startLoading = function (source$) {
+    LoadingBarService.prototype.start = function () {
         this.pending.next({
@@ -22,7 +21,2 @@ started: this._pendingRequests === 0,
         });
-        if (source$) {
-            source$ = share.share.call(source$);
-            source$.subscribe(this.getLoadingObserver());
-            return source$;
-        }
     };
@@ -32,3 +26,3 @@ /**
      */
-    LoadingBarService.prototype.endLoading = function () {
+    LoadingBarService.prototype.complete = function () {
         if (this._pendingRequests === 0) {
@@ -43,10 +37,32 @@ return;
     /**
+     * @param {?=} source$
      * @return {?}
      */
+    LoadingBarService.prototype.startLoading = function (source$) {
+        console.warn("LoadingBarService: 'startLoading' is deprecated and will removed in the next version use 'start' instead.");
+        this.start();
+        if (source$) {
+            console.warn("LoadingBarService: passing 'source$' to 'startLoading' is deprecated and will removed in the next version.");
+            source$ = share.share.call(source$);
+            source$.subscribe(this.getLoadingObserver());
+            return source$;
+        }
+    };
+    /**
+     * @return {?}
+     */
+    LoadingBarService.prototype.endLoading = function () {
+        console.warn("LoadingBarService: 'endLoading' is deprecated and will removed in the next version use 'complete' instead.");
+        this.complete();
+    };
+    /**
+     * @return {?}
+     */
     LoadingBarService.prototype.getLoadingObserver = function () {
         var _this = this;
+        console.warn("LoadingBarService: 'getLoadingObserver' is deprecated and will removed in the next version.");
         return {
             next: function (x) { return x; },
-            error: function (err) { return _this.endLoading(); },
-            complete: function () { return _this.endLoading(); },
+            error: function (err) { return _this.complete(); },
+            complete: function () { return _this.complete(); },
         };
@@ -53,0 +69,0 @@ };

core.metadata.json

@@ -1,1 +0,1 @@
-{"__symbolic":"module","version":3,"metadata":{"LoadingBarModule":{"__symbolic":"class","decorators":[{"__symbolic":"call","expression":{"__symbolic":"reference","module":"@angular/core","name":"NgModule"},"arguments":[{"imports":[{"__symbolic":"reference","module":"@angular/common","name":"CommonModule"}],"declarations":[{"__symbolic":"reference","name":"LoadingBarComponent"}],"exports":[{"__symbolic":"reference","name":"LoadingBarComponent"}]}]}],"members":{},"statics":{"forRoot":{"__symbolic":"function","parameters":[],"value":{"ngModule":{"__symbolic":"reference","name":"LoadingBarModule"},"providers":[{"__symbolic":"reference","name":"LoadingBarService"}]}}}},"LoadingBarService":{"__symbolic":"class","decorators":[{"__symbolic":"call","expression":{"__symbolic":"reference","module":"@angular/core","name":"Injectable"}}],"members":{"startLoading":[{"__symbolic":"method"}],"endLoading":[{"__symbolic":"method"}],"getLoadingObserver":[{"__symbolic":"method"}],"ngOnDestroy":[{"__symbolic":"method"}]}},"LoadingBarComponent":{"__symbolic":"class","decorators":[{"__symbolic":"call","expression":{"__symbolic":"reference","module":"@angular/core","name":"Component"},"arguments":[{"selector":"ng-loading-bar, ngx-loading-bar","template":"\n    <ng-container *ngIf=\"started\">\n        <div id=\"loading-bar-spinner\" *ngIf=\"includeSpinner\"><div class=\"spinner-icon\"></div></div>\n        <div id=\"loading-bar\"><div class=\"bar\" [style.width]=\"progressWidth\"><div class=\"peg\"></div></div></div>\n    </ng-container>\n    "}]}],"members":{"includeSpinner":[{"__symbolic":"property","decorators":[{"__symbolic":"call","expression":{"__symbolic":"reference","module":"@angular/core","name":"Input"}}]}],"__ctor__":[{"__symbolic":"constructor","parameters":[{"__symbolic":"reference","name":"LoadingBarService"}]}],"start":[{"__symbolic":"method"}],"set":[{"__symbolic":"method"}],"complete":[{"__symbolic":"method"}],"inc":[{"__symbolic":"method"}]}}},"origins":{"LoadingBarModule":"./core.module","LoadingBarService":"./loading-bar.service","LoadingBarComponent":"./loading-bar.component"},"importAs":"@ngx-loading-bar/core"}
+{"__symbolic":"module","version":3,"metadata":{"LoadingBarModule":{"__symbolic":"class","decorators":[{"__symbolic":"call","expression":{"__symbolic":"reference","module":"@angular/core","name":"NgModule"},"arguments":[{"imports":[{"__symbolic":"reference","module":"@angular/common","name":"CommonModule"}],"declarations":[{"__symbolic":"reference","name":"LoadingBarComponent"}],"exports":[{"__symbolic":"reference","name":"LoadingBarComponent"}]}]}],"members":{},"statics":{"forRoot":{"__symbolic":"function","parameters":[],"value":{"ngModule":{"__symbolic":"reference","name":"LoadingBarModule"},"providers":[{"__symbolic":"reference","name":"LoadingBarService"}]}}}},"LoadingBarService":{"__symbolic":"class","decorators":[{"__symbolic":"call","expression":{"__symbolic":"reference","module":"@angular/core","name":"Injectable"}}],"members":{"start":[{"__symbolic":"method"}],"complete":[{"__symbolic":"method"}],"startLoading":[{"__symbolic":"method"}],"endLoading":[{"__symbolic":"method"}],"getLoadingObserver":[{"__symbolic":"method"}],"ngOnDestroy":[{"__symbolic":"method"}]}},"LoadingBarComponent":{"__symbolic":"class","decorators":[{"__symbolic":"call","expression":{"__symbolic":"reference","module":"@angular/core","name":"Component"},"arguments":[{"selector":"ng-loading-bar, ngx-loading-bar","template":"\n    <ng-container *ngIf=\"started\">\n        <div id=\"loading-bar-spinner\" *ngIf=\"includeSpinner\"><div class=\"spinner-icon\"></div></div>\n        <div id=\"loading-bar\"><div class=\"bar\" [style.width]=\"progressWidth\"><div class=\"peg\"></div></div></div>\n    </ng-container>\n    "}]}],"members":{"includeSpinner":[{"__symbolic":"property","decorators":[{"__symbolic":"call","expression":{"__symbolic":"reference","module":"@angular/core","name":"Input"}}]}],"__ctor__":[{"__symbolic":"constructor","parameters":[{"__symbolic":"reference","name":"LoadingBarService"}]}],"start":[{"__symbolic":"method"}],"set":[{"__symbolic":"method"}],"complete":[{"__symbolic":"method"}],"inc":[{"__symbolic":"method"}]}}},"origins":{"LoadingBarModule":"./core.module","LoadingBarService":"./loading-bar.service","LoadingBarComponent":"./loading-bar.component"},"importAs":"@ngx-loading-bar/core"}

loading-bar.service.d.ts

@@ -13,2 +13,4 @@ import { OnDestroy } from '@angular/core';
     private _pendingRequests;
+    start(): void;
+    complete(): void;
     startLoading(source$?: Observable<any>): Observable<any>;
@@ -15,0 +17,0 @@ endLoading(): void;

package.json

 {
   "name": "@ngx-loading-bar/core",
-  "version": "1.0.0-alpha.10",
+  "version": "1.0.0-alpha.11",
   "description": "",
@@ -5,0 +5,0 @@ "license": "MIT",

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

No README

Quality

Package does not have a README. This may indicate a failed publish or a low quality package.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

72314

increased by11.82%

Number of package files

15

increased by7.14%

Lines of code

821

increased by6.49%

Number of medium quality alerts

0

decreased by-100%

Number of lines in readme file

105

increased byInfinity%

No dependency changes