@ngx-loading-bar/core - npm Package Compare versions

Comparing version 1.0.0-alpha.18 to 1.0.0-rc.0

@ngx-loading-bar/core.es5.js

@@ -7,4 +7,3 @@ import { ChangeDetectionStrategy, Component, Injectable, Input, NgModule } from '@angular/core';
     function LoadingBarService() {
-        this._progress$ = new Subject$1();
-        this.progress$ = debounceTime$1.call(this._progress$);
+        this.progress$ = debounceTime$1.call(new Subject$1());
         this._pending = new Subject$1();
@@ -14,13 +13,2 @@ this._pendingRequests = 0;
     }
-    Object.defineProperty(LoadingBarService.prototype, "pending", {
-        /**
-         * @return {?}
-         */
-        get: function () {
-            console.warn("LoadingBarService: 'pending' is deprecated and will removed in the next version use 'progress$' instead which return a value between 0 and 100.");
-            return this._pending;
-        },
-        enumerable: true,
-        configurable: true
-    });
     /**
@@ -30,3 +18,3 @@ * @return {?}
     LoadingBarService.prototype.start = function () {
-        this._pending.next(++this._pendingRequests);
+        ++this._pendingRequests;
         if (this._value === 0) {
@@ -45,3 +33,3 @@ // Inserts the loading bar element into the dom, and sets it to 2%
         }
-        this._pending.next(--this._pendingRequests);
+        --this._pendingRequests;
         if (this._pendingRequests === 0 && this._value !== 100) {
@@ -59,3 +47,2 @@ if (this._value > 0) {
     LoadingBarService.prototype.ngOnDestroy = function () {
-        this._pending.complete();
         this.progress$.complete();
@@ -75,3 +62,3 @@ };
         this._value = n;
-        this._progress$.next(n);
+        this.progress$.next(n);
         // increment loadingbar to give the illusion that there is always
@@ -78,0 +65,0 @@ // progress but make sure to cancel the previous timeouts so we don't

@ngx-loading-bar/core.js

@@ -8,4 +8,3 @@ import { ChangeDetectionStrategy, Component, Injectable, Input, NgModule } from '@angular/core';
     constructor() {
-        this._progress$ = new Subject$1();
-        this.progress$ = debounceTime$1.call(this._progress$);
+        this.progress$ = debounceTime$1.call(new Subject$1());
         this._pending = new Subject$1();
@@ -18,11 +17,4 @@ this._pendingRequests = 0;
      */
-    get pending() {
-        console.warn(`LoadingBarService: 'pending' is deprecated and will removed in the next version use 'progress$' instead which return a value between 0 and 100.`);
-        return this._pending;
-    }
-    /**
-     * @return {?}
-     */
     start() {
-        this._pending.next(++this._pendingRequests);
+        ++this._pendingRequests;
         if (this._value === 0) {
@@ -40,3 +32,3 @@ // Inserts the loading bar element into the dom, and sets it to 2%
         }
-        this._pending.next(--this._pendingRequests);
+        --this._pendingRequests;
         if (this._pendingRequests === 0 && this._value !== 100) {
@@ -54,3 +46,2 @@ if (this._value > 0) {
     ngOnDestroy() {
-        this._pending.complete();
         this.progress$.complete();
@@ -69,3 +60,3 @@ }
         this._value = n;
-        this._progress$.next(n);
+        this.progress$.next(n);
         // increment loadingbar to give the illusion that there is always
@@ -72,0 +63,0 @@ // progress but make sure to cancel the previous timeouts so we don't

bundles/core.umd.js

@@ -9,4 +9,3 @@ (function (global, factory) {
     function LoadingBarService() {
-        this._progress$ = new Subject.Subject();
-        this.progress$ = debounceTime.debounceTime.call(this._progress$);
+        this.progress$ = debounceTime.debounceTime.call(new Subject.Subject());
         this._pending = new Subject.Subject();
@@ -16,13 +15,2 @@ this._pendingRequests = 0;
     }
-    Object.defineProperty(LoadingBarService.prototype, "pending", {
-        /**
-         * @return {?}
-         */
-        get: function () {
-            console.warn("LoadingBarService: 'pending' is deprecated and will removed in the next version use 'progress$' instead which return a value between 0 and 100.");
-            return this._pending;
-        },
-        enumerable: true,
-        configurable: true
-    });
     /**
@@ -32,3 +20,3 @@ * @return {?}
     LoadingBarService.prototype.start = function () {
-        this._pending.next(++this._pendingRequests);
+        ++this._pendingRequests;
         if (this._value === 0) {
@@ -47,3 +35,3 @@ // Inserts the loading bar element into the dom, and sets it to 2%
         }
-        this._pending.next(--this._pendingRequests);
+        --this._pendingRequests;
         if (this._pendingRequests === 0 && this._value !== 100) {
@@ -61,3 +49,2 @@ if (this._value > 0) {
     LoadingBarService.prototype.ngOnDestroy = function () {
-        this._pending.complete();
         this.progress$.complete();
@@ -77,3 +64,3 @@ };
         this._value = n;
-        this._progress$.next(n);
+        this.progress$.next(n);
         // increment loadingbar to give the illusion that there is always
@@ -80,0 +67,0 @@ // progress but make sure to cancel the previous timeouts so we don't

loading-bar.service.d.ts

 import { OnDestroy } from '@angular/core';
 import { Subject } from 'rxjs/Subject';
 export declare class LoadingBarService implements OnDestroy {
-    private _progress$;
-    readonly progress$: any;
+    readonly progress$: Subject<number>;
     private _pending;
@@ -10,3 +9,2 @@ private _pendingRequests;
     private _incTimeout;
-    readonly pending: Subject<number>;
     start(): void;
@@ -13,0 +11,0 @@ complete(): void;

package.json

 {
   "name": "@ngx-loading-bar/core",
-  "version": "1.0.0-alpha.18",
+  "version": "1.0.0-rc.0",
   "description": "Automatic page loading / progress bar for Angular",
@@ -5,0 +5,0 @@ "keywords": [

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Worsened metrics

Total package byte prevSize

52928

decreased by-6.34%

Lines of code

610

decreased by-5.72%

No dependency changes