@novalabsxyz/base-theme - npm Package Compare versions

Comparing version 1.0.7 to 1.0.8-alpha.0

build/index.d.ts

@@ -394,5 +394,5 @@ export { BaseThemeTypography, BaseThemePalette, BaseThemeBreakpoints, } from './baseThemeTypes';
             color: string;
+            lineHeight: number;
             fontSize: number;
             letterSpacing: number;
-            lineHeight: number;
         };
@@ -403,5 +403,5 @@ h2Medium: {
             color: string;
+            lineHeight: number;
             fontSize: number;
             letterSpacing: number;
-            lineHeight: number;
         };
@@ -412,5 +412,5 @@ h2Bold: {
             color: string;
+            lineHeight: number;
             fontSize: number;
             letterSpacing: number;
-            lineHeight: number;
         };
@@ -421,5 +421,5 @@ h3Light: {
             color: string;
+            lineHeight: number;
             fontSize: number;
             letterSpacing: number;
-            lineHeight: number;
         };
@@ -430,5 +430,5 @@ h3Medium: {
             color: string;
+            lineHeight: number;
             fontSize: number;
             letterSpacing: number;
-            lineHeight: number;
         };
@@ -439,5 +439,5 @@ h3Bold: {
             color: string;
+            lineHeight: number;
             fontSize: number;
             letterSpacing: number;
-            lineHeight: number;
         };
@@ -448,5 +448,5 @@ h4Light: {
             color: string;
+            lineHeight: number;
             fontSize: number;
             letterSpacing: number;
-            lineHeight: number;
         };
@@ -457,5 +457,5 @@ h4Medium: {
             color: string;
+            lineHeight: number;
             fontSize: number;
             letterSpacing: number;
-            lineHeight: number;
         };
@@ -466,5 +466,5 @@ h4Bold: {
             color: string;
+            lineHeight: number;
             fontSize: number;
             letterSpacing: number;
-            lineHeight: number;
         };
@@ -475,5 +475,5 @@ h5Light: {
             color: string;
+            lineHeight: number;
             fontSize: number;
             letterSpacing: number;
-            lineHeight: number;
         };
@@ -484,5 +484,5 @@ h5Medium: {
             color: string;
+            lineHeight: number;
             fontSize: number;
             letterSpacing: number;
-            lineHeight: number;
         };
@@ -493,5 +493,5 @@ h5Bold: {
             color: string;
+            lineHeight: number;
             fontSize: number;
             letterSpacing: number;
-            lineHeight: number;
         };
@@ -524,2 +524,3 @@ bodyLight: {
             color: string;
+            lineHeight: number;
             fontFamily: string;
@@ -530,6 +531,6 @@ fontSize: number;
             letterSpacing: number;
-            lineHeight: number;
         };
         h2: {
             color: string;
+            lineHeight: number;
             fontFamily: string;
@@ -539,6 +540,6 @@ fontSize: number;
             fontWeight: number;
-            lineHeight: number;
         };
         h3: {
             color: string;
+            lineHeight: number;
             fontFamily: string;
@@ -548,6 +549,6 @@ fontSize: number;
             fontWeight: number;
-            lineHeight: number;
         };
         h4: {
             color: string;
+            lineHeight: number;
             fontFamily: string;
@@ -557,6 +558,6 @@ fontSize: number;
             fontWeight: number;
-            lineHeight: number;
         };
         h5: {
             color: string;
+            lineHeight: number;
             fontFamily: string;
@@ -566,3 +567,2 @@ fontSize: number;
             fontWeight: number;
-            lineHeight: number;
         };
@@ -569,0 +569,0 @@ body: {

build/index.js

@@ -207,7 +207,17 @@ "use strict";
 let mobileVariants = {
-    h1: Object.assign(Object.assign({}, baseTextVariants.h1), { color: 'primaryText' }),
-    h2: Object.assign(Object.assign({}, baseTextVariants.h2), { color: 'primaryText' }),
-    h3: Object.assign(Object.assign({}, baseTextVariants.h3), { color: 'primaryText' }),
-    h4: Object.assign(Object.assign({}, baseTextVariants.h4), { color: 'secondaryText' }),
-    h5: Object.assign(Object.assign({}, baseTextVariants.h5), { color: 'primaryText' }),
+    h1: Object.assign(Object.assign({}, baseTextVariants.h1), { color: 'primaryText', 
+        // Need to compensate for glyphy clipping. https://github.com/facebook/react-native/issues/29507
+        lineHeight: baseTextVariants.h1.lineHeight * 1.27 }),
+    h2: Object.assign(Object.assign({}, baseTextVariants.h2), { color: 'primaryText', 
+        // Need to compensate for glyphy clipping. https://github.com/facebook/react-native/issues/29507
+        lineHeight: baseTextVariants.h2.lineHeight * 1.27 }),
+    h3: Object.assign(Object.assign({}, baseTextVariants.h3), { color: 'primaryText', 
+        // Need to compensate for glyphy clipping. https://github.com/facebook/react-native/issues/29507
+        lineHeight: baseTextVariants.h3.lineHeight * 1.27 }),
+    h4: Object.assign(Object.assign({}, baseTextVariants.h4), { color: 'secondaryText', 
+        // Need to compensate for glyphy clipping. https://github.com/facebook/react-native/issues/29507
+        lineHeight: baseTextVariants.h4.lineHeight * 1.27 }),
+    h5: Object.assign(Object.assign({}, baseTextVariants.h5), { color: 'primaryText', 
+        // Need to compensate for glyphy clipping. https://github.com/facebook/react-native/issues/29507
+        lineHeight: baseTextVariants.h5.lineHeight * 1.27 }),
     body: Object.assign(Object.assign({}, baseTextVariants.body), { color: 'secondaryText', fontSize: 16, letterSpacing: -0.48, lineHeight: 19.2 }),
@@ -214,0 +224,0 @@ legal: Object.assign(Object.assign({}, baseTextVariants.legal), { color: 'secondaryText' }),

package.json

 {
   "name": "@novalabsxyz/base-theme",
-  "version": "1.0.7",
+  "version": "1.0.8-alpha.0",
   "description": "BaseTheme for Novalabs",
@@ -19,3 +19,3 @@ "contributors": [
   },
-  "gitHead": "df76ecbbe3325240ac944b979e48d22cce797b1c"
+  "gitHead": "aa06d99c570632149657a28903bb0a3c4b58ac81"
 }

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

No v1

Quality

Package is not semver >=1. This means it is not stable and does not support ^ ranges.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

54547

increased by2.18%

Lines of code

1083

increased by0.93%

Worsened metrics

Number of low quality alerts

2

increased by100%

No dependency changes