@nteract/actions - npm Package Compare versions

Comparing version 2.3.0 to 2.4.0

__tests__/actions-spec.ts

@@ -194,4 +194,3 @@ import {
         contentRef,
-        selectNextKernel: false,
-        opts: { headers: { "Content-Type": "application/json" } }
+        selectNextKernel: false
       })
@@ -205,4 +204,3 @@ ).toEqual({
         contentRef,
-        selectNextKernel: false,
-        opts: { headers: { "Content-Type": "application/json" } }
+        selectNextKernel: false
       }
@@ -645,18 +643,2 @@ });
 
-  test("creates a SAVE action with opts", () => {
-    const contentRef = createContentRef();
-    expect(
-      actions.save({
-        contentRef,
-        opts: { headers: { "Content-Type": "application/json" } }
-      })
-    ).toEqual({
-      type: actionTypes.SAVE,
-      payload: {
-        contentRef,
-        opts: { headers: { "Content-Type": "application/json" } }
-      }
-    });
-  });
-
   test("creates a SAVE_AS action", () => {
@@ -663,0 +645,0 @@ const contentRef = createContentRef();

lib/actions/contents.d.ts

@@ -8,6 +8,5 @@ /**
 export declare const changeContentName: (payload: {
+    filepath: string;
     contentRef: string;
-    filepath: string;
     prevFilePath: string;
-    opts?: object | undefined;
 }) => actionTypes.ChangeContentName;
@@ -31,3 +30,2 @@ export declare const changeContentNameFulfilled: (payload: {
     contentRef: string;
-    opts?: object | undefined;
 }) => actionTypes.FetchContent;
@@ -50,3 +48,5 @@ export declare const fetchContentFulfilled: (payload: {
 }): actionTypes.ChangeFilenameAction;
-export declare function downloadContent(payload: actionTypes.DownloadContent["payload"]): actionTypes.DownloadContent;
+export declare function downloadContent(payload: {
+    contentRef: ContentRef;
+}): actionTypes.DownloadContent;
 export declare function downloadContentFailed(payload: {
@@ -58,3 +58,5 @@ contentRef: ContentRef;
 }): actionTypes.DownloadContentFulfilled;
-export declare function save(payload: actionTypes.Save["payload"]): actionTypes.Save;
+export declare function save(payload: {
+    contentRef: ContentRef;
+}): actionTypes.Save;
 export declare function saveAs(payload: {
@@ -61,0 +63,0 @@ filepath: string;

lib/actions/kernels.d.ts

@@ -25,4 +25,14 @@ /**
 }): actionTypes.LaunchKernelAction;
-export declare function changeKernelByName(payload: actionTypes.ChangeKernelByName["payload"]): actionTypes.ChangeKernelByName;
-export declare function launchKernelByName(payload: actionTypes.LaunchKernelByNameAction["payload"]): actionTypes.LaunchKernelByNameAction;
+export declare function changeKernelByName(payload: {
+    kernelSpecName: any;
+    oldKernelRef?: KernelRef | null;
+    contentRef: ContentRef;
+}): actionTypes.ChangeKernelByName;
+export declare function launchKernelByName(payload: {
+    kernelSpecName: any;
+    cwd: string;
+    kernelRef: KernelRef;
+    selectNextKernel: boolean;
+    contentRef: ContentRef;
+}): actionTypes.LaunchKernelByNameAction;
 export declare function kernelRawStdout(payload: {
@@ -36,3 +46,6 @@ text: string;
 }): actionTypes.KernelRawStderr;
-export declare function killKernel(payload: actionTypes.KillKernelAction["payload"]): actionTypes.KillKernelAction;
+export declare function killKernel(payload: {
+    restarting: boolean;
+    kernelRef?: KernelRef | null;
+}): actionTypes.KillKernelAction;
 export declare function killKernelFailed(payload: {
@@ -45,3 +58,5 @@ error: Error;
 }): actionTypes.KillKernelSuccessful;
-export declare function interruptKernel(payload: actionTypes.InterruptKernel["payload"]): actionTypes.InterruptKernel;
+export declare function interruptKernel(payload: {
+    kernelRef?: KernelRef | null;
+}): actionTypes.InterruptKernel;
 export declare function interruptKernelSuccessful(payload: {
@@ -48,0 +63,0 @@ kernelRef?: KernelRef | null;

lib/actions/kernelspecs.d.ts

@@ -9,3 +9,2 @@ /**
     hostRef: string;
-    opts?: object | undefined;
 }) => actionTypes.FetchKernelspecs;
@@ -12,0 +11,0 @@ export declare const fetchKernelspecsFulfilled: (payload: {

lib/actionTypes/contents.d.ts

@@ -12,3 +12,2 @@ /**
         prevFilePath: string;
-        opts?: object;
     };
@@ -44,3 +43,2 @@ }
         contentRef: ContentRef;
-        opts?: object;
     };
@@ -76,3 +74,2 @@ }
         contentRef: ContentRef;
-        opts?: object;
     };
@@ -99,3 +96,2 @@ }
         contentRef: ContentRef;
-        opts?: object;
     };
@@ -102,0 +98,0 @@ }

lib/actionTypes/kernels.d.ts

@@ -75,3 +75,2 @@ /**
         kernelRef?: KernelRef | null;
-        opts?: object;
     };
@@ -101,3 +100,2 @@ }
         kernelRef?: KernelRef | null;
-        opts?: object;
     };
@@ -167,3 +165,2 @@ }
         contentRef: ContentRef;
-        opts?: object;
     };
@@ -180,3 +177,2 @@ }
         contentRef: ContentRef;
-        opts?: object;
     };
@@ -183,0 +179,0 @@ }

lib/actionTypes/kernelspecs.d.ts

@@ -11,3 +11,2 @@ /**
         hostRef: HostRef;
-        opts?: object;
     };
@@ -14,0 +13,0 @@ }

package.json

 {
   "name": "@nteract/actions",
-  "version": "2.3.0",
+  "version": "2.4.0",
   "description": "A collection of actions",
@@ -17,8 +17,8 @@ "main": "lib/index.js",
     "@nteract/commutable": "^7.1.0",
-    "@nteract/messaging": "^6.0.3",
-    "@nteract/types": "^4.0.3",
+    "@nteract/messaging": "^6.0.4",
+    "@nteract/types": "^4.1.0",
     "immutable": "^4.0.0-rc.12",
-    "rx-jupyter": "^5.0.4"
+    "rx-jupyter": "^5.1.0"
   },
-  "gitHead": "8f86648c6e4523f1dd5dd532e9c8f2c1105d6827"
+  "gitHead": "f63a01c4067b05541ebddd3932345d7102ea3e5b"
 }

src/actions/contents.ts

@@ -10,5 +10,7 @@ /**
 
-export const changeContentName = (
-  payload: actionTypes.ChangeContentName["payload"]
-): actionTypes.ChangeContentName => ({
+export const changeContentName = (payload: {
+  filepath: string;
+  contentRef: ContentRef;
+  prevFilePath: string;
+}): actionTypes.ChangeContentName => ({
   type: actionTypes.CHANGE_CONTENT_NAME,
@@ -76,5 +78,5 @@ payload
 
-export function downloadContent(
-  payload: actionTypes.DownloadContent["payload"]
-): actionTypes.DownloadContent {
+export function downloadContent(payload: {
+  contentRef: ContentRef;
+}): actionTypes.DownloadContent {
   return {
@@ -104,3 +106,3 @@ type: actionTypes.DOWNLOAD_CONTENT,
 
-export function save(payload: actionTypes.Save["payload"]): actionTypes.Save {
+export function save(payload: { contentRef: ContentRef }): actionTypes.Save {
   return {
@@ -107,0 +109,0 @@ type: actionTypes.SAVE,

src/actions/kernels.ts

@@ -52,5 +52,7 @@ /**
 
-export function changeKernelByName(
-  payload: actionTypes.ChangeKernelByName["payload"]
-): actionTypes.ChangeKernelByName {
+export function changeKernelByName(payload: {
+  kernelSpecName: any;
+  oldKernelRef?: KernelRef | null;
+  contentRef: ContentRef;
+}): actionTypes.ChangeKernelByName {
   return {
@@ -62,5 +64,9 @@ type: actionTypes.CHANGE_KERNEL_BY_NAME,
 
-export function launchKernelByName(
-  payload: actionTypes.LaunchKernelByNameAction["payload"]
-): actionTypes.LaunchKernelByNameAction {
+export function launchKernelByName(payload: {
+  kernelSpecName: any;
+  cwd: string;
+  kernelRef: KernelRef;
+  selectNextKernel: boolean;
+  contentRef: ContentRef;
+}): actionTypes.LaunchKernelByNameAction {
   return {
@@ -92,5 +98,6 @@ type: actionTypes.LAUNCH_KERNEL_BY_NAME,
 
-export function killKernel(
-  payload: actionTypes.KillKernelAction["payload"]
-): actionTypes.KillKernelAction {
+export function killKernel(payload: {
+  restarting: boolean;
+  kernelRef?: KernelRef | null;
+}): actionTypes.KillKernelAction {
   return {
@@ -122,5 +129,5 @@ type: actionTypes.KILL_KERNEL,
 
-export function interruptKernel(
-  payload: actionTypes.InterruptKernel["payload"]
-): actionTypes.InterruptKernel {
+export function interruptKernel(payload: {
+  kernelRef?: KernelRef | null;
+}): actionTypes.InterruptKernel {
   return {
@@ -127,0 +134,0 @@ type: actionTypes.INTERRUPT_KERNEL,

src/actions/kernelspecs.ts

@@ -13,5 +13,6 @@ /**
 
-export const fetchKernelspecs = (
-  payload: actionTypes.FetchKernelspecs["payload"]
-): actionTypes.FetchKernelspecs => ({
+export const fetchKernelspecs = (payload: {
+  kernelspecsRef: KernelspecsRef;
+  hostRef: HostRef;
+}): actionTypes.FetchKernelspecs => ({
   type: actionTypes.FETCH_KERNELSPECS,
@@ -18,0 +19,0 @@ payload

src/actionTypes/contents.ts

@@ -13,3 +13,2 @@ /**
     prevFilePath: string;
-    opts?: object;
   };
@@ -49,3 +48,2 @@ }
     contentRef: ContentRef;
-    opts?: object;
   };
@@ -84,3 +82,2 @@ }
     contentRef: ContentRef;
-    opts?: object;
   };
@@ -106,3 +103,2 @@ }
     contentRef: ContentRef;
-    opts?: object;
   };
@@ -109,0 +105,0 @@ }

src/actionTypes/kernels.ts

@@ -91,3 +91,2 @@ /**
     kernelRef?: KernelRef | null;
-    opts?: object;
   };
@@ -120,3 +119,2 @@ }
     kernelRef?: KernelRef | null;
-    opts?: object;
   };
@@ -193,3 +191,2 @@ }
     contentRef: ContentRef;
-    opts?: object;
   };
@@ -207,3 +204,2 @@ }
     contentRef: ContentRef;
-    opts?: object;
   };
@@ -210,0 +206,0 @@ }

src/actionTypes/kernelspecs.ts

@@ -18,3 +18,2 @@ /**
     hostRef: HostRef;
-    opts?: object;
   };
@@ -21,0 +20,0 @@ }

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Worsened metrics

Total package byte prevSize

171446

decreased by-0.4%

Lines of code

4969

decreased by-0.18%

Dependency changes

• Updated@nteract/messaging@^6.0.4

• Updated@nteract/types@^4.1.0

• Updatedrx-jupyter@^5.1.0