@nteract/types - npm Package Compare versions

Comparing version 1.2.0 to 1.3.0

lib/core/records.js

@@ -73,11 +73,14 @@ "use strict";
 
+var version = require("../../package.json").version;
 var makeAppRecord = exports.makeAppRecord = (0, _immutable.Record)({
   kernel: null,
   host: null,
-  githubToken: null, // Electron specific (ish...)
-  notificationSystem: null, // Should be available for all I assume
-  isSaving: false, // All -- ?
-  lastSaved: null, // All
-  configLastSaved: null, // ?
-  error: null // All
+  githubToken: null,
+  notificationSystem: null,
+  isSaving: false,
+  lastSaved: null,
+  configLastSaved: null,
+  error: null,
+  // set the default version to @nteract/core's version
+  version: "@nteract/core@" + version
 });
@@ -84,0 +87,0 @@

package.json

 {
   "name": "@nteract/types",
-  "version": "1.2.0",
+  "version": "1.3.0",
   "description": "collection of types for nteract components",
@@ -5,0 +5,0 @@ "scripts": {

src/core/records.js

@@ -11,2 +11,4 @@ /* @flow */
 
+const version = require("../../package.json").version;
+
 import { List, Map, Record, Set } from "immutable";
@@ -18,2 +20,6 @@
 
+export type HostRecord = RecordOf<
+  DesktopHostRecordProps | JupyterHostRecordProps
+>;
+
 export {
@@ -149,8 +155,5 @@ makeLocalKernelRecord,
 
-// Parts of AppRecord should become
-// ElectronAppRecord
-// Basically, anything that's only for desktop should have its own record & reducers
 type AppRecordProps = {
   kernel: ?RecordOf<RemoteKernelProps | LocalKernelProps>,
-  host: ?RecordOf<DesktopHostRecordProps | JupyterHostRecordProps>,
+  host: ?HostRecord,
   githubToken: ?string,
@@ -161,3 +164,5 @@ notificationSystem: ?Object,
   configLastSaved: ?Date,
-  error: any
+  error: any,
+  // The version number should be provided by an app on boot
+  version: string
 };
@@ -168,8 +173,10 @@
   host: null,
-  githubToken: null, // Electron specific (ish...)
-  notificationSystem: null, // Should be available for all I assume
-  isSaving: false, // All -- ?
-  lastSaved: null, // All
-  configLastSaved: null, // ?
-  error: null // All
+  githubToken: null,
+  notificationSystem: null,
+  isSaving: false,
+  lastSaved: null,
+  configLastSaved: null,
+  error: null,
+  // set the default version to @nteract/core's version
+  version: `@nteract/core@${version}`
 });
@@ -176,0 +183,0 @@

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

25356

increased by35.65%

Number of package files

27

increased by3.85%

Lines of code

584

increased by1.39%

No dependency changes