@okta/configuration-validation - npm Package Compare versions

Comparing version 0.4.1 to 0.4.2

CHANGELOG.md

@@ -0,1 +1,7 @@
+# 0.4.2
+
+### Bug Fixes
+
+- [#754] `autoRenew: false` at the top of a config (not in tokenManager) now actually passes into tokenManager.  The previous behavior caused problems with libraries (such as @okta/okta-auth-js) that tried to assign defaults of `true` to any params not explicitly set, as they would not see any explictly `false` setting.  
+
 # 0.4.1
@@ -2,0 +8,0 @@

dist/lib.js

@@ -67,5 +67,5 @@ 'use strict';
   var tokenManager = config.tokenManager;
-  var autoRenew = config.autoRenew || config.auto_renew;
+  var autoRenew = config.autoRenew !== undefined ? config.autoRenew : config.auto_renew; // Only check legacy property if necessary
   var storage = config.storage;
-  if (storage || autoRenew) {
+  if (storage !== undefined || autoRenew !== undefined) {
     // Properties already defined within the "tokenManager" section will not be overwritten
@@ -72,0 +72,0 @@ tokenManager = merge({

package.json

 {
   "name": "@okta/configuration-validation",
-  "version": "0.4.1",
+  "version": "0.4.2",
   "description": "Configuration validation support for Okta JavaScript SDKs",
@@ -45,3 +45,7 @@ "main": "./dist/lib.js",
     "testEnvironment": "jsdom"
+  },
+  "okta": {
+    "commitSha": "e4f0aaf8b8b574e6a32d307c5f33732415479dde",
+    "fullVersion": "0.4.2-beta.ge4f0aaf-20200428225810-e4f0aaf"
   }
 }

README.md

@@ -8,7 +8,3 @@ # Okta Configuration Validation
 ```bash
-# npm
 npm install --save @okta/configuration-validation
-
-# yarn
-yarn add @okta/configuration-validation
 ```
@@ -67,1 +63,10 @@
 ```
+
+## Contributing
+We welcome contributions to all of our open-source packages. Please see the [contribution guide](https://github.com/okta/okta-oidc-js/blob/master/CONTRIBUTING.md) to understand how to structure a contribution.
+
+### Installing dependencies for contributions
+We use [yarn](https://yarnpkg.com) for dependency management when developing this package:
+```
+yarn install
+```

src/lib.js

@@ -50,5 +50,5 @@ /*!
   let tokenManager = config.tokenManager;
-  const autoRenew = config.autoRenew || config.auto_renew;
+  const autoRenew = ( config.autoRenew !== undefined ? config.autoRenew : config.auto_renew); // Only check legacy property if necessary
   const storage = config.storage;
-  if (storage || autoRenew) {
+  if (storage !== undefined || autoRenew !== undefined ) {
     // Properties already defined within the "tokenManager" section will not be overwritten
@@ -55,0 +55,0 @@ tokenManager = merge({

No alert changes

Improved metrics

Total package byte prevSize

28521

increased by3.75%

Number of lines in readme file

70

increased by6.06%

No dependency changes