@orbiting/backend-modules-mail - npm Package Compare versions

Comparing version 0.1.2 to 0.1.3

CHANGELOG.md

@@ -1,6 +0,16 @@
-<a name="0.1.2"></a>
-## 0.1.2 (2018-01-14)
+<a name="0.1.3"></a>
+## 0.1.3 (2018-01-14)
 
 
 
+<a name="0.1.3"></a>
+## 0.1.3 (2018-01-14)
+
+
+### Bug Fixes
+
+* **updateUserOnMailchimp:** ensure hasMembership for DAILY and WEEKLY ([87623e6](https://github.com/orbiting/backend-modules/commit/87623e6))
+
+
+
 <a name="0.1.2"></a>
@@ -7,0 +17,0 @@ ## 0.1.2 (2018-01-14)

lib/updateUserOnMailchimp.js

@@ -34,3 +34,4 @@ const fetch = require('isomorphic-unfetch')
     const hasMembership = await pgdb.public.memberships.findFirst({
-      userId: userId
+      userId: userId,
+      active: true
     })
@@ -49,4 +50,4 @@ const membershipTypeBenefactor = await pgdb.public.membershipTypes.findOne({
            // Autosubscribe all newsletters when new user just paid.
-           [MAILCHIMP_INTEREST_NEWSLETTER_DAILY]: true,
-           [MAILCHIMP_INTEREST_NEWSLETTER_WEEKLY]: true,
+           [MAILCHIMP_INTEREST_NEWSLETTER_DAILY]: !!hasMembership,
+           [MAILCHIMP_INTEREST_NEWSLETTER_WEEKLY]: !!hasMembership,
            [MAILCHIMP_INTEREST_NEWSLETTER_PROJECTR]: true
@@ -62,4 +63,4 @@ }
                // Autosubscribe paid newsletters when user just paid.
-               [MAILCHIMP_INTEREST_NEWSLETTER_DAILY]: true,
-               [MAILCHIMP_INTEREST_NEWSLETTER_WEEKLY]: true
+               [MAILCHIMP_INTEREST_NEWSLETTER_DAILY]: !!hasMembership,
+               [MAILCHIMP_INTEREST_NEWSLETTER_WEEKLY]: !!hasMembership
              }
@@ -66,0 +67,0 @@ : !hasMembership

package.json

 {
   "name": "@orbiting/backend-modules-mail",
-  "version": "0.1.2",
+  "version": "0.1.3",
   "description": "simple mails with mandrill, manage subscriptions on mailchimp",
@@ -5,0 +5,0 @@ "main": "index.js",

No alert changes

Improved metrics

Total package byte prevSize

9702

increased by2.86%

Lines of code

243

increased by0.41%

No dependency changes