@posva/vuefire-core - npm Package Compare versions

Comparing version 2.3.2 to 2.3.3

CHANGELOG.md

@@ -6,2 +6,13 @@ # Change Log
 
+## [2.3.3](https://github.com/vuejs/vuefire/compare/@posva/vuefire-core@2.3.2...@posva/vuefire-core@2.3.3) (2020-07-31)
+
+
+### Bug Fixes
+
+* **core:** drop raw refs when updating docs ([3d0b326](https://github.com/vuejs/vuefire/commit/3d0b326e2855f0cdab160281262b1edc8be8606c)), closes [#831](https://github.com/vuejs/vuefire/issues/831)
+
+
+
+
+
 ## [2.3.2](https://github.com/vuejs/vuefire/compare/@posva/vuefire-core@2.3.1...@posva/vuefire-core@2.3.2) (2020-07-06)
@@ -8,0 +19,0 @@

dist/vuefire-core.cjs.js

 /*!
-  * @posva/vuefire-core v2.3.2
+  * @posva/vuefire-core v2.3.3
   * (c) 2020 Eduardo San Martin Morote
@@ -223,3 +223,10 @@ * @license MIT
                 // TODO: better typing since this isObject shouldn't be necessary but it doesn't work
-                data[key] = typeof oldDoc === 'object' && key in oldDoc ? oldDoc[key] : ref.path;
+                data[key] =
+                    typeof oldDoc === 'object' &&
+                        key in oldDoc &&
+                        // only copy refs if they were refs before
+                        // https://github.com/vuejs/vuefire/issues/831
+                        typeof oldDoc[key] != 'string'
+                        ? oldDoc[key]
+                        : ref.path;
                 // TODO: handle subpathes?
@@ -226,0 +233,0 @@ refs[path + key] = ref;

dist/vuefire-core.esm.js

 /*!
-  * @posva/vuefire-core v2.3.2
+  * @posva/vuefire-core v2.3.3
   * (c) 2020 Eduardo San Martin Morote
@@ -219,3 +219,10 @@ * @license MIT
                 // TODO: better typing since this isObject shouldn't be necessary but it doesn't work
-                data[key] = typeof oldDoc === 'object' && key in oldDoc ? oldDoc[key] : ref.path;
+                data[key] =
+                    typeof oldDoc === 'object' &&
+                        key in oldDoc &&
+                        // only copy refs if they were refs before
+                        // https://github.com/vuejs/vuefire/issues/831
+                        typeof oldDoc[key] != 'string'
+                        ? oldDoc[key]
+                        : ref.path;
                 // TODO: handle subpathes?
@@ -222,0 +229,0 @@ refs[path + key] = ref;

package.json

 {
   "name": "@posva/vuefire-core",
-  "version": "2.3.2",
+  "version": "2.3.3",
   "description": "Shared code for vue + Firebase apps used by vuefire and vuexfire",
@@ -45,3 +45,3 @@ "author": "Eduardo San Martin Morote <[e-mail]>",
   },
-  "gitHead": "ab3194d7782a3028b496bbcfa5ee45edb632c154"
+  "gitHead": "4d504da28daaf7b3f8b9ec17f84007c54d8fee1c"
 }

src/firestore/utils.ts

@@ -67,3 +67,10 @@ import { firestore } from 'firebase'
         // TODO: better typing since this isObject shouldn't be necessary but it doesn't work
-        data[key] = typeof oldDoc === 'object' && key in oldDoc ? oldDoc[key] : ref.path
+        data[key] =
+          typeof oldDoc === 'object' &&
+          key in oldDoc &&
+          // only copy refs if they were refs before
+          // https://github.com/vuejs/vuefire/issues/831
+          typeof oldDoc[key] != 'string'
+            ? oldDoc[key]
+            : ref.path
         // TODO: handle subpathes?
@@ -70,0 +77,0 @@ refs[path + key] = ref

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

69624

increased by1.65%

Lines of code

1659

increased by1.28%

No dependency changes