@qawolf/web - npm Package Compare versions

Comparing version 0.5.8 to 0.5.10

lib/find.js

@@ -47,2 +47,5 @@ "use strict";
         }
+        if (["a", "button", "input"].indexOf(ancestor.tagName.toLowerCase()) > -1) {
+            return ancestor;
+        }
         if (!element_1.isClickable(ancestor.parentElement, window.getComputedStyle(ancestor.parentElement))) {
@@ -49,0 +52,0 @@ console.log("found clickable ancestor", xpath_1.getXpath(ancestor));

lib/match.js

@@ -13,3 +13,4 @@ "use strict";
     "placeholder",
-    "src"
+    "src",
+    "title"
 ];
@@ -16,0 +17,0 @@ exports.compareArrays = (base, compare) => {

lib/qawolf.web.js

@@ -284,3 +284,4 @@ var qawolf = (function (exports) {
       "placeholder",
-      "src"
+      "src",
+      "title"
   ];
@@ -503,3 +504,8 @@ var compareArrays = function (base, compare) {
           }
-          // short-circuit when parent is not clickable
+          // short-circuit when we encounter a common clickable element type
+          // there may be a parent that is still clickable but does something else
+          if (["a", "button", "input"].indexOf(ancestor.tagName.toLowerCase()) > -1) {
+              return ancestor;
+          }
+          // stop at the top clickable ancestor
           if (!isClickable(ancestor.parentElement, window.getComputedStyle(ancestor.parentElement))) {
@@ -506,0 +512,0 @@ console.log("found clickable ancestor", getXpath(ancestor));

package.json

 {
   "name": "@qawolf/web",
   "description": "qawolf web library",
-  "version": "0.5.8",
+  "version": "0.5.10",
   "license": "BSD-3.0",
@@ -33,3 +33,3 @@ "main": "./lib/index.js",
   },
-  "gitHead": "7f90e207884baeb510f318b5489226a554bc076a"
+  "gitHead": "6c6f200a508e6ab8e01005878beba110b5021573"
 }

src/find.ts

@@ -71,3 +71,9 @@ import { Action, Locator } from "@qawolf/types";
 
-    // short-circuit when parent is not clickable
+    // short-circuit when we encounter a common clickable element type
+    // there may be a parent that is still clickable but does something else
+    if (["a", "button", "input"].indexOf(ancestor.tagName.toLowerCase()) > -1) {
+      return ancestor;
+    }
+
+    // stop at the top clickable ancestor
     if (
@@ -74,0 +80,0 @@ !isClickable(

src/match.ts

@@ -34,3 +34,4 @@ import { ElementDescriptor } from "@qawolf/types";
   "placeholder",
-  "src"
+  "src",
+  "title"
 ];
@@ -37,0 +38,0 @@

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

139701

increased by0.61%

Lines of code

2684

increased by0.6%

No dependency changes