@react-aria/dnd - npm Package Compare versions

Comparing version 3.6.2-nightly.4704 to 3.6.2-nightly.4709

dist/ListDropTargetDelegate.main.js

@@ -45,5 +45,9 @@
         for (let item of elements)if (item instanceof HTMLElement) elementMap.set(item.dataset.key, item);
+        // TODO: assume that only item type items are valid drop targets. This is to prevent a crash when dragging over the loader
+        // row since it doesn't have a data-key set on it. Will eventually need to handle the case with drag and drop and loaders located between rows aka tree.
+        // Can see https://github.com/adobe/react-spectrum/pull/4210/files#diff-21e555e0c597a28215e36137f5be076a65a1e1456c92cd0fdd60f866929aae2a for additional logic
+        // that may need to happen then
         let items = [
             ...this.collection
-        ];
+        ].filter((item)=>item.type === 'item');
         let low = 0;
@@ -50,0 +54,0 @@ let high = items.length;

dist/ListDropTargetDelegate.module.js

@@ -39,5 +39,9 @@ class $3ca85212bf8898e4$export$fbd65d14c79e28cc {
         for (let item of elements)if (item instanceof HTMLElement) elementMap.set(item.dataset.key, item);
+        // TODO: assume that only item type items are valid drop targets. This is to prevent a crash when dragging over the loader
+        // row since it doesn't have a data-key set on it. Will eventually need to handle the case with drag and drop and loaders located between rows aka tree.
+        // Can see https://github.com/adobe/react-spectrum/pull/4210/files#diff-21e555e0c597a28215e36137f5be076a65a1e1456c92cd0fdd60f866929aae2a for additional logic
+        // that may need to happen then
         let items = [
             ...this.collection
-        ];
+        ].filter((item)=>item.type === 'item');
         let low = 0;
@@ -44,0 +48,0 @@ let high = items.length;

package.json

 {
   "name": "@react-aria/dnd",
-  "version": "3.6.2-nightly.4704+546ffa41f",
+  "version": "3.6.2-nightly.4709+4fc70174a",
   "description": "Spectrum UI components in React",
@@ -25,11 +25,11 @@ "license": "Apache-2.0",
   "dependencies": {
-    "@internationalized/string": "3.2.4-nightly.4704+546ffa41f",
-    "@react-aria/i18n": "3.0.0-nightly.2992+546ffa41f",
-    "@react-aria/interactions": "3.0.0-nightly.2992+546ffa41f",
-    "@react-aria/live-announcer": "3.0.0-nightly.2992+546ffa41f",
-    "@react-aria/overlays": "3.0.0-nightly.2992+546ffa41f",
-    "@react-aria/utils": "3.0.0-nightly.2992+546ffa41f",
-    "@react-stately/dnd": "3.3.2-nightly.4704+546ffa41f",
-    "@react-types/button": "3.9.5-nightly.4704+546ffa41f",
-    "@react-types/shared": "3.0.0-nightly.2992+546ffa41f",
+    "@internationalized/string": "3.2.4-nightly.4709+4fc70174a",
+    "@react-aria/i18n": "3.0.0-nightly.2997+4fc70174a",
+    "@react-aria/interactions": "3.0.0-nightly.2997+4fc70174a",
+    "@react-aria/live-announcer": "3.0.0-nightly.2997+4fc70174a",
+    "@react-aria/overlays": "3.0.0-nightly.2997+4fc70174a",
+    "@react-aria/utils": "3.0.0-nightly.2997+4fc70174a",
+    "@react-stately/dnd": "3.3.2-nightly.4709+4fc70174a",
+    "@react-types/button": "3.9.5-nightly.4709+4fc70174a",
+    "@react-types/shared": "3.0.0-nightly.2997+4fc70174a",
     "@swc/helpers": "^0.5.0"
@@ -44,3 +44,3 @@ },
   },
-  "gitHead": "546ffa41f7d1d3a566950a14d8f46cf726891220"
+  "gitHead": "4fc70174ac35a5ebf06379f5cafaf943519a1eac"
 }

src/ListDropTargetDelegate.ts

@@ -98,3 +98,7 @@ import {Direction, DropTarget, DropTargetDelegate, Node, Orientation, RefObject} from '@react-types/shared';
 
-    let items = [...this.collection];
+    // TODO: assume that only item type items are valid drop targets. This is to prevent a crash when dragging over the loader
+    // row since it doesn't have a data-key set on it. Will eventually need to handle the case with drag and drop and loaders located between rows aka tree.
+    // Can see https://github.com/adobe/react-spectrum/pull/4210/files#diff-21e555e0c597a28215e36137f5be076a65a1e1456c92cd0fdd60f866929aae2a for additional logic
+    // that may need to happen then
+    let items = [...this.collection].filter(item => item.type === 'item');
     let low = 0;
@@ -101,0 +105,0 @@ let high = items.length;

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Manifest confusion

Supply chain risk

This package has inconsistent metadata. This could be malicious or caused by an error when publishing the package.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Manifest confusion

Supply chain risk

This package has inconsistent metadata. This could be malicious or caused by an error when publishing the package.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

1715107

increased by0.2%

Lines of code

16005

increased by0.1%

Dependency changes

• Updated@internationalized/string@3.2.4-nightly.4709+4fc70174a

• Updated@react-aria/i18n@3.0.0-nightly.2997+4fc70174a

• Updated@react-aria/interactions@3.0.0-nightly.2997+4fc70174a

• Updated@react-aria/live-announcer@3.0.0-nightly.2997+4fc70174a

• Updated@react-aria/overlays@3.0.0-nightly.2997+4fc70174a

• Updated@react-aria/utils@3.0.0-nightly.2997+4fc70174a

• Updated@react-stately/dnd@3.3.2-nightly.4709+4fc70174a

• Updated@react-types/button@3.9.5-nightly.4709+4fc70174a

• Updated@react-types/shared@3.0.0-nightly.2997+4fc70174a