@react-native-windows/cli - npm Package Compare versions

Comparing version 0.0.0-canary.63 to 0.0.0-canary.64

CHANGELOG.json

@@ -5,3 +5,18 @@ {
     {
-      "date": "Tue, 23 Feb 2021 05:06:00 GMT",
+      "date": "Fri, 12 Mar 2021 05:07:08 GMT",
+      "tag": "@react-native-windows/cli_v0.0.0-canary.64",
+      "version": "0.0.0-canary.64",
+      "comments": {
+        "prerelease": [
+          {
+            "comment": "Include Hermes NuGet Package By Default",
+            "author": "[e-mail]",
+            "commit": "89ceb6d7c2e76bd43b8c2264a2b5243dab1f6e51",
+            "package": "@react-native-windows/cli"
+          }
+        ]
+      }
+    },
+    {
+      "date": "Tue, 23 Feb 2021 05:06:42 GMT",
       "tag": "@react-native-windows/cli_v0.0.0-canary.63",
@@ -8,0 +23,0 @@ "version": "0.0.0-canary.63",

CHANGELOG.md

 # Change Log - @react-native-windows/cli
 
-This log was last generated on Tue, 23 Feb 2021 05:06:00 GMT and should not be manually modified.
+This log was last generated on Fri, 12 Mar 2021 05:07:08 GMT and should not be manually modified.
 
 <!-- Start content -->
 
+## 0.0.0-canary.64
+
+Fri, 12 Mar 2021 05:07:08 GMT
+
+### Changes
+
+- Include Hermes NuGet Package By Default ([e-mail])
+
 ## 0.0.0-canary.63
 
-Tue, 23 Feb 2021 05:06:00 GMT
+Tue, 23 Feb 2021 05:06:42 GMT
 
@@ -11,0 +19,0 @@ ### Changes

lib-commonjs/e2etest/projectConfig.test.js

@@ -103,3 +103,3 @@ "use strict";
 });
-test('useWinUI3=true in react-native.config.js, useWinUI3=false in ExperimentalFeatures.props', async (done) => {
+test('useWinUI3=true in react-native.config.js, useWinUI3=false in ExperimentalFeatures.props', async () => {
     const folder = path.resolve('src/e2etest/projects/WithWinUI3');
@@ -118,4 +118,3 @@ const rnc = require(path.join(folder, 'react-native.config.js'));
     expect(experimentalFeatures.replace(/\r/g, '')).toMatchSnapshot();
-    done();
 });
 //# sourceMappingURL=projectConfig.test.js.map

lib-commonjs/e2etest/projectConfig.utils.js

@@ -19,3 +19,3 @@ "use strict";
     if (fs.existsSync(windowsDir)) {
-        await fs.promises.rm(windowsDir, { recursive: true });
+        await fs.promises.rmdir(windowsDir, { recursive: true });
     }
@@ -22,0 +22,0 @@ await tryMkdir(windowsDir);

lib-commonjs/generator-windows/index.js

@@ -52,2 +52,7 @@ "use strict";
 }
+function resolveRnwPath(subpath) {
+    return require.resolve(path.join('react-native-windows', subpath), {
+        paths: [process.cwd()],
+    });
+}
 // Existing high cyclomatic complexity
@@ -96,3 +101,3 @@ // eslint-disable-next-line complexity
     const projectGuid = uuid.v4();
-    const rnwVersion = require('react-native-windows/package.json').version;
+    const rnwVersion = require(resolveRnwPath('package.json')).version;
     const nugetVersion = options.nuGetTestVersion || rnwVersion;
@@ -108,6 +113,8 @@ const packageGuid = uuid.v4();
     const xamlNamespaceCpp = toCppNamespace(xamlNamespace);
-    const winuiPropsPath = require.resolve('react-native-windows/PropertySheets/WinUI.props', { paths: [process.cwd()] });
+    const winuiPropsPath = resolveRnwPath('PropertySheets/WinUI.props');
     const winuiProps = configUtils_1.readProjectFile(winuiPropsPath);
     const winui3Version = configUtils_1.findPropertyValue(winuiProps, 'WinUI3Version', winuiPropsPath);
     const winui2xVersion = configUtils_1.findPropertyValue(winuiProps, 'WinUI2xVersion', winuiPropsPath);
+    const jsEnginePropsPath = resolveRnwPath('PropertySheets/JSengine.props');
+    const hermesVersion = configUtils_1.findPropertyValue(configUtils_1.readProjectFile(jsEnginePropsPath), 'HermesVersion', jsEnginePropsPath);
     const csNugetPackages = [
@@ -127,2 +134,8 @@ {
         },
+        {
+            id: 'ReactNative.Hermes.Windows',
+            version: hermesVersion,
+            hasProps: false,
+            hasTargets: true,
+        },
     ];
@@ -147,10 +160,2 @@ if (options.experimentalNuGetDependency) {
     }
-    if (options.useHermes) {
-        cppNugetPackages.push({
-            id: 'ReactNative.Hermes.Windows',
-            version: '0.7.2',
-            hasProps: false,
-            hasTargets: true,
-        });
-    }
     const packagesConfigCppNugetPackages = [
@@ -157,0 +162,0 @@ ...cppNugetPackages,

package.json

 {
   "name": "@react-native-windows/cli",
-  "version": "0.0.0-canary.63",
+  "version": "0.0.0-canary.64",
   "license": "MIT",
@@ -5,0 +5,0 @@ "main": "lib-commonjs/index.js",

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Dynamic require

Supply chain risk

Dynamic require can indicate the package is performing dangerous or unsafe dynamic code execution.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

419332

increased by0.25%

Lines of code

5814

increased by0.33%

Worsened metrics

Number of low supply chain risk alerts

41

increased by5.13%

No dependency changes