@rnx-kit/config - npm Package Compare versions

Comparing version 0.4.18 to 0.4.19

CHANGELOG.json

@@ -5,3 +5,18 @@ {
     {
-      "date": "Fri, 05 Nov 2021 19:23:52 GMT",
+      "date": "Mon, 08 Nov 2021 10:20:06 GMT",
+      "tag": "@rnx-kit/config_v0.4.19",
+      "version": "0.4.19",
+      "comments": {
+        "patch": [
+          {
+            "author": "[e-mail]",
+            "package": "@rnx-kit/config",
+            "commit": "3b0b310ba9394c145fd1570043c0649f1f9200e7",
+            "comment": "Default value for `projectRoot` overrides value in Metro config"
+          }
+        ]
+      }
+    },
+    {
+      "date": "Fri, 05 Nov 2021 19:24:49 GMT",
       "tag": "@rnx-kit/config_v0.4.18",
@@ -8,0 +23,0 @@ "version": "0.4.18",

CHANGELOG.md

 # Change Log - @rnx-kit/config
 
-This log was last generated on Fri, 05 Nov 2021 19:23:52 GMT and should not be manually modified.
+This log was last generated on Mon, 08 Nov 2021 10:20:06 GMT and should not be manually modified.
 
 <!-- Start content -->
 
+## 0.4.19
+
+Mon, 08 Nov 2021 10:20:06 GMT
+
+### Patches
+
+- Default value for `projectRoot` overrides value in Metro config ([e-mail])
+
 ## 0.4.18
 
-Fri, 05 Nov 2021 19:23:52 GMT
+Fri, 05 Nov 2021 19:24:49 GMT
 
@@ -11,0 +19,0 @@ ### Patches

coverage/coverage-final.json

 {"/home/runner/work/rnx-kit/rnx-kit/packages/config/src/getBundleDefinition.ts": {"path":"/home/runner/work/rnx-kit/rnx-kit/packages/config/src/getBundleDefinition.ts","statementMap":{"0":{"start":{"line":26,"column":54},"end":{"line":35,"column":3}},"1":{"start":{"line":36,"column":2},"end":{"line":38,"column":3}},"2":{"start":{"line":37,"column":4},"end":{"line":37,"column":29}},"3":{"start":{"line":40,"column":18},"end":{"line":40,"column":35}},"4":{"start":{"line":41,"column":2},"end":{"line":44,"column":3}},"5":{"start":{"line":42,"column":19},"end":{"line":42,"column":57}},"6":{"start":{"line":42,"column":39},"end":{"line":42,"column":50}},"7":{"start":{"line":43,"column":4},"end":{"line":43,"column":47}},"8":{"start":{"line":46,"column":2},"end":{"line":46,"column":49}},"9":{"start":{"line":60,"column":25},"end":{"line":60,"column":71}},"10":{"start":{"line":61,"column":2},"end":{"line":61,"column":68}}},"fnMap":{"0":{"name":"getBundleDefinition","decl":{"start":{"line":22,"column":16},"end":{"line":22,"column":35}},"loc":{"start":{"line":25,"column":42},"end":{"line":47,"column":1}},"line":25},"1":{"name":"(anonymous_1)","decl":{"start":{"line":42,"column":32},"end":{"line":42,"column":33}},"loc":{"start":{"line":42,"column":39},"end":{"line":42,"column":50}},"line":42},"2":{"name":"getBundlePlatformDefinition","decl":{"start":{"line":56,"column":16},"end":{"line":56,"column":43}},"loc":{"start":{"line":59,"column":42},"end":{"line":62,"column":1}},"line":59}},"branchMap":{"0":{"loc":{"start":{"line":36,"column":2},"end":{"line":38,"column":3}},"type":"if","locations":[{"start":{"line":36,"column":2},"end":{"line":38,"column":3}},{"start":{"line":36,"column":2},"end":{"line":38,"column":3}}],"line":36},"1":{"loc":{"start":{"line":41,"column":2},"end":{"line":44,"column":3}},"type":"if","locations":[{"start":{"line":41,"column":2},"end":{"line":44,"column":3}},{"start":{"line":41,"column":2},"end":{"line":44,"column":3}}],"line":41},"2":{"loc":{"start":{"line":42,"column":19},"end":{"line":42,"column":57}},"type":"binary-expr","locations":[{"start":{"line":42,"column":19},"end":{"line":42,"column":51}},{"start":{"line":42,"column":55},"end":{"line":42,"column":57}}],"line":42},"3":{"loc":{"start":{"line":60,"column":25},"end":{"line":60,"column":71}},"type":"binary-expr","locations":[{"start":{"line":60,"column":25},"end":{"line":60,"column":41}},{"start":{"line":60,"column":45},"end":{"line":60,"column":71}}],"line":60},"4":{"loc":{"start":{"line":61,"column":9},"end":{"line":61,"column":67}},"type":"cond-expr","locations":[{"start":{"line":61,"column":26},"end":{"line":61,"column":58}},{"start":{"line":61,"column":61},"end":{"line":61,"column":67}}],"line":61}},"s":{"0":4,"1":4,"2":1,"3":3,"4":3,"5":2,"6":4,"7":2,"8":1,"9":3,"10":3},"f":{"0":4,"1":4,"2":3},"b":{"0":[1,3],"1":[2,1],"2":[2,1],"3":[3,2],"4":[1,2]},"_coverageSchema":"1a1c01bbd47fc00a2c39e90264f33305004495a9","hash":"834c31e1e0897bfa5fcc9174c03780b722231a75"}
 ,"/home/runner/work/rnx-kit/rnx-kit/packages/config/src/getKitCapabilities.ts": {"path":"/home/runner/work/rnx-kit/rnx-kit/packages/config/src/getKitCapabilities.ts","statementMap":{"0":{"start":{"line":23,"column":2},"end":{"line":29,"column":3}},"1":{"start":{"line":28,"column":4},"end":{"line":28,"column":76}},"2":{"start":{"line":31,"column":2},"end":{"line":33,"column":3}},"3":{"start":{"line":32,"column":4},"end":{"line":32,"column":72}},"4":{"start":{"line":36,"column":4},"end":{"line":36,"column":67}},"5":{"start":{"line":38,"column":2},"end":{"line":45,"column":3}},"6":{"start":{"line":42,"column":4},"end":{"line":44,"column":6}},"7":{"start":{"line":47,"column":2},"end":{"line":53,"column":4}}},"fnMap":{"0":{"name":"getKitCapabilities","decl":{"start":{"line":16,"column":16},"end":{"line":16,"column":34}},"loc":{"start":{"line":22,"column":31},"end":{"line":54,"column":1}},"line":22}},"branchMap":{"0":{"loc":{"start":{"line":17,"column":2},"end":{"line":17,"column":19}},"type":"default-arg","locations":[{"start":{"line":17,"column":17},"end":{"line":17,"column":19}}],"line":17},"1":{"loc":{"start":{"line":18,"column":2},"end":{"line":18,"column":21}},"type":"default-arg","locations":[{"start":{"line":18,"column":12},"end":{"line":18,"column":21}}],"line":18},"2":{"loc":{"start":{"line":23,"column":2},"end":{"line":29,"column":3}},"type":"if","locations":[{"start":{"line":23,"column":2},"end":{"line":29,"column":3}},{"start":{"line":23,"column":2},"end":{"line":29,"column":3}}],"line":23},"3":{"loc":{"start":{"line":24,"column":4},"end":{"line":26,"column":45}},"type":"binary-expr","locations":[{"start":{"line":24,"column":4},"end":{"line":24,"column":23}},{"start":{"line":25,"column":5},"end":{"line":25,"column":38}},{"start":{"line":26,"column":6},"end":{"line":26,"column":44}}],"line":24},"4":{"loc":{"start":{"line":31,"column":2},"end":{"line":33,"column":3}},"type":"if","locations":[{"start":{"line":31,"column":2},"end":{"line":33,"column":3}},{"start":{"line":31,"column":2},"end":{"line":33,"column":3}}],"line":31},"5":{"loc":{"start":{"line":31,"column":6},"end":{"line":31,"column":40}},"type":"binary-expr","locations":[{"start":{"line":31,"column":6},"end":{"line":31,"column":23}},{"start":{"line":31,"column":27},"end":{"line":31,"column":40}}],"line":31},"6":{"loc":{"start":{"line":36,"column":4},"end":{"line":36,"column":67}},"type":"binary-expr","locations":[{"start":{"line":36,"column":4},"end":{"line":36,"column":17}},{"start":{"line":36,"column":21},"end":{"line":36,"column":67}}],"line":36},"7":{"loc":{"start":{"line":38,"column":2},"end":{"line":45,"column":3}},"type":"if","locations":[{"start":{"line":38,"column":2},"end":{"line":45,"column":3}},{"start":{"line":38,"column":2},"end":{"line":45,"column":3}}],"line":38},"8":{"loc":{"start":{"line":39,"column":4},"end":{"line":40,"column":61}},"type":"binary-expr","locations":[{"start":{"line":39,"column":4},"end":{"line":39,"column":26}},{"start":{"line":40,"column":4},"end":{"line":40,"column":61}}],"line":39}},"s":{"0":21,"1":2,"2":19,"3":1,"4":19,"5":19,"6":3,"7":16},"f":{"0":21},"b":{"0":[19],"1":[18],"2":[2,19],"3":[21,19,9],"4":[1,18],"5":[19,2],"6":[19,11],"7":[3,16],"8":[19,19]},"_coverageSchema":"1a1c01bbd47fc00a2c39e90264f33305004495a9","hash":"4144bd52c18e92431a331fe9d149c7663a149de4"}
 ,"/home/runner/work/rnx-kit/rnx-kit/packages/config/src/getKitConfig.ts": {"path":"/home/runner/work/rnx-kit/rnx-kit/packages/config/src/getKitConfig.ts","statementMap":{"0":{"start":{"line":24,"column":14},"end":{"line":26,"column":34}},"1":{"start":{"line":29,"column":23},"end":{"line":29,"column":67}},"2":{"start":{"line":30,"column":17},"end":{"line":30,"column":41}},"3":{"start":{"line":31,"column":2},"end":{"line":31,"column":32}}},"fnMap":{"0":{"name":"getKitConfig","decl":{"start":{"line":20,"column":16},"end":{"line":20,"column":28}},"loc":{"start":{"line":22,"column":20},"end":{"line":32,"column":1}},"line":22}},"branchMap":{"0":{"loc":{"start":{"line":21,"column":2},"end":{"line":21,"column":35}},"type":"default-arg","locations":[{"start":{"line":21,"column":33},"end":{"line":21,"column":35}}],"line":21},"1":{"loc":{"start":{"line":24,"column":14},"end":{"line":26,"column":34}},"type":"cond-expr","locations":[{"start":{"line":25,"column":6},"end":{"line":25,"column":69}},{"start":{"line":26,"column":6},"end":{"line":26,"column":34}}],"line":24},"2":{"loc":{"start":{"line":26,"column":6},"end":{"line":26,"column":34}},"type":"binary-expr","locations":[{"start":{"line":26,"column":6},"end":{"line":26,"column":17}},{"start":{"line":26,"column":21},"end":{"line":26,"column":34}}],"line":26},"3":{"loc":{"start":{"line":31,"column":9},"end":{"line":31,"column":31}},"type":"binary-expr","locations":[{"start":{"line":31,"column":9},"end":{"line":31,"column":23}},{"start":{"line":31,"column":27},"end":{"line":31,"column":31}}],"line":31}},"s":{"0":4,"1":4,"2":4,"3":4},"f":{"0":4},"b":{"0":[3],"1":[0,4],"2":[4,3],"3":[4,1]},"_coverageSchema":"1a1c01bbd47fc00a2c39e90264f33305004495a9","hash":"f57db9dc1e666ea22e39aadff1a98a1d3f1f957f"}
-,"/home/runner/work/rnx-kit/rnx-kit/packages/config/src/getServerConfig.ts": {"path":"/home/runner/work/rnx-kit/rnx-kit/packages/config/src/getServerConfig.ts","statementMap":{"0":{"start":{"line":16,"column":54},"end":{"line":22,"column":3}},"1":{"start":{"line":24,"column":2},"end":{"line":24,"column":56}}},"fnMap":{"0":{"name":"getServerConfig","decl":{"start":{"line":13,"column":16},"end":{"line":13,"column":31}},"loc":{"start":{"line":15,"column":32},"end":{"line":25,"column":1}},"line":15}},"branchMap":{"0":{"loc":{"start":{"line":24,"column":33},"end":{"line":24,"column":52}},"type":"binary-expr","locations":[{"start":{"line":24,"column":33},"end":{"line":24,"column":46}},{"start":{"line":24,"column":50},"end":{"line":24,"column":52}}],"line":24}},"s":{"0":3,"1":3},"f":{"0":3},"b":{"0":[3,1]},"_coverageSchema":"1a1c01bbd47fc00a2c39e90264f33305004495a9","hash":"dbfa8430e1865d330070af36db9c928935775046"}
+,"/home/runner/work/rnx-kit/rnx-kit/packages/config/src/getServerConfig.ts": {"path":"/home/runner/work/rnx-kit/rnx-kit/packages/config/src/getServerConfig.ts","statementMap":{"0":{"start":{"line":16,"column":54},"end":{"line":21,"column":3}},"1":{"start":{"line":23,"column":2},"end":{"line":23,"column":56}}},"fnMap":{"0":{"name":"getServerConfig","decl":{"start":{"line":13,"column":16},"end":{"line":13,"column":31}},"loc":{"start":{"line":15,"column":32},"end":{"line":24,"column":1}},"line":15}},"branchMap":{"0":{"loc":{"start":{"line":23,"column":33},"end":{"line":23,"column":52}},"type":"binary-expr","locations":[{"start":{"line":23,"column":33},"end":{"line":23,"column":46}},{"start":{"line":23,"column":50},"end":{"line":23,"column":52}}],"line":23}},"s":{"0":3,"1":3},"f":{"0":3},"b":{"0":[3,1]},"_coverageSchema":"1a1c01bbd47fc00a2c39e90264f33305004495a9","hash":"14530990dc3526d9973a45f1a485b7de0a2dcb79"}
 }

lib/getServerConfig.js

@@ -13,3 +13,2 @@ "use strict";
     const defaultConfig = {
-        projectRoot: "src",
         detectCyclicDependencies: true,
@@ -16,0 +15,0 @@ detectDuplicateDependencies: true,

lib/serverConfig.d.ts

 import type { BundlerRuntimeParameters } from "./bundleConfig";
-export declare type ServerRequiredParameters = BundlerRuntimeParameters & {
+export declare type ServerRequiredParameters = BundlerRuntimeParameters;
+export declare type ServerParameters = Partial<ServerRequiredParameters> & {
     /**
@@ -8,7 +9,7 @@ * Path to the root of your react-native experience project. The bundle server uses
      *
-     * @default "src"
+     * Note that `projectRoot` should also contain your Babel config, otherwise
+     * Metro won't be able to find it. For details, see
+     * https://github.com/microsoft/rnx-kit/issues/706.
      */
-    projectRoot: string;
-};
-export declare type ServerParameters = Partial<ServerRequiredParameters> & {
+    projectRoot?: string;
     /**
@@ -15,0 +16,0 @@ * Additional asset plugins to be used by the Metro Babel transformer. Comma-separated

package.json

 {
   "name": "@rnx-kit/config",
-  "version": "0.4.18",
+  "version": "0.4.19",
   "description": "Define and query information about a kit package",
@@ -5,0 +5,0 @@ "license": "MIT",

src/getServerConfig.ts

@@ -17,3 +17,2 @@ import type { KitConfig } from "./kitConfig";
   const defaultConfig: ServerWithRequiredParameters = {
-    projectRoot: "src",
     detectCyclicDependencies: true,
@@ -20,0 +19,0 @@ detectDuplicateDependencies: true,

src/serverConfig.ts

 import type { BundlerRuntimeParameters } from "./bundleConfig";
 
-export type ServerRequiredParameters = BundlerRuntimeParameters & {
+export type ServerRequiredParameters = BundlerRuntimeParameters;
+
+export type ServerParameters = Partial<ServerRequiredParameters> & {
   /**
@@ -9,8 +11,8 @@ * Path to the root of your react-native experience project. The bundle server uses
    *
-   * @default "src"
+   * Note that `projectRoot` should also contain your Babel config, otherwise
+   * Metro won't be able to find it. For details, see
+   * https://github.com/microsoft/rnx-kit/issues/706.
    */
-  projectRoot: string;
-};
+  projectRoot?: string;
 
-export type ServerParameters = Partial<ServerRequiredParameters> & {
   /**
@@ -17,0 +19,0 @@ * Additional asset plugins to be used by the Metro Babel transformer. Comma-separated

test/getServerConfig.test.ts

@@ -26,3 +26,2 @@ import "jest-extended";
   expect(c).toContainAllKeys([
-    "projectRoot",
     "detectCyclicDependencies",
@@ -33,3 +32,3 @@ "detectDuplicateDependencies",
   ]);
-  expect(c.projectRoot).toEqual("src");
+  expect(c.projectRoot).toBeUndefined();
   expect(c.detectCyclicDependencies).toBeTrue();
@@ -36,0 +35,0 @@ expect(c.detectDuplicateDependencies).toBeTrue();

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

180009

increased by0.42%

Lines of code

2699

increased by0.52%

No dependency changes