@rushstack/heft - npm Package Compare versions

Comparing version 0.38.2 to 0.39.0

CHANGELOG.md

 # Change Log - @rushstack/heft
 
-This log was last generated on Wed, 22 Sep 2021 00:09:32 GMT and should not be manually modified.
+This log was last generated on Wed, 22 Sep 2021 03:27:12 GMT and should not be manually modified.
 
+## 0.39.0
+Wed, 22 Sep 2021 03:27:12 GMT
+
+### Minor changes
+
+- Add "encounteredErrors" boolean to IMetricsData.
+
+### Patches
+
+- Fix typo in temp folder path.
+
 ## 0.38.2
@@ -6,0 +17,0 @@ Wed, 22 Sep 2021 00:09:32 GMT

dist/heft.d.ts

@@ -444,2 +444,6 @@ import { AsyncParallelHook } from 'tapable';
     /**
+     * Whether or not the command ran into errors
+     */
+    encounteredError?: boolean;
+    /**
      * The amount of time the command took to execute, in milliseconds.
@@ -479,2 +483,3 @@ */
     taskTotalExecutionMs: number;
+    encounteredError?: boolean;
 }
@@ -481,0 +486,0 @@

lib/cli/actions/HeftActionBase.d.ts

 import { CommandLineAction, CommandLineFlagParameter, ICommandLineActionOptions, ICommandLineFlagDefinition, ICommandLineChoiceDefinition, CommandLineChoiceParameter, CommandLineIntegerParameter, ICommandLineIntegerDefinition, CommandLineStringParameter, ICommandLineStringDefinition, CommandLineStringListParameter, ICommandLineStringListDefinition } from '@rushstack/ts-command-line';
 import { Terminal } from '@rushstack/node-core-library';
-import { MetricsCollector } from '../../metrics/MetricsCollector';
+import { IPerformanceData, MetricsCollector } from '../../metrics/MetricsCollector';
 import { HeftConfiguration } from '../../configuration/HeftConfiguration';
@@ -36,3 +36,3 @@ import { BuildStage } from '../../stages/BuildStage';
     setStartTime(): void;
-    recordMetrics(): void;
+    recordMetrics(performanceData?: Partial<IPerformanceData>): void;
     onExecute(): Promise<void>;
@@ -39,0 +39,0 @@ protected abstract actionExecuteAsync(): Promise<void>;

lib/cli/actions/HeftActionBase.js

@@ -50,4 +50,4 @@ "use strict";
     }
-    recordMetrics() {
-        this.metricsCollector.record(this.actionName, undefined, this.getParameterStringMap());
+    recordMetrics(performanceData) {
+        this.metricsCollector.record(this.actionName, performanceData, this.getParameterStringMap());
     }
@@ -71,3 +71,2 @@ async onExecute() {
         finally {
-            this.recordMetrics();
             const warningStrings = this.loggingManager.getWarningStrings();
@@ -77,2 +76,3 @@ const errorStrings = this.loggingManager.getErrorStrings();
             encounteredError = encounteredError || errorStrings.length > 0;
+            this.recordMetrics({ encounteredError });
             this.terminal.writeLine(node_core_library_1.Colors.bold((encounteredError ? node_core_library_1.Colors.red : encounteredWarnings ? node_core_library_1.Colors.yellow : node_core_library_1.Colors.green)(`-------------------- Finished (${Math.round(perf_hooks_1.performance.now()) / 1000}s) --------------------`)));
@@ -79,0 +79,0 @@ if (warningStrings.length > 0) {

lib/metrics/MetricsCollector.d.ts

@@ -11,2 +11,6 @@ import { AsyncParallelHook, SyncHook } from 'tapable';
     /**
+     * Whether or not the command ran into errors
+     */
+    encounteredError?: boolean;
+    /**
      * The amount of time the command took to execute, in milliseconds.
@@ -64,2 +68,3 @@ */
     taskTotalExecutionMs: number;
+    encounteredError?: boolean;
 }
@@ -66,0 +71,0 @@ /**

lib/metrics/MetricsCollector.js

@@ -89,2 +89,3 @@ "use strict";
             command: command,
+            encounteredError: filledPerformanceData.encounteredError,
             taskTotalExecutionMs: filledPerformanceData.taskTotalExecutionMs,
@@ -91,0 +92,0 @@ machineOs: process.platform,

lib/plugins/TypeScriptPlugin/TypeScriptPlugin.js

@@ -126,3 +126,3 @@ "use strict";
             buildFolder: heftConfiguration.buildFolder,
-            buildMetadataFolder: node_core_library_1.Path.convertToSlashes(`${heftConfiguration.buildFolder}/temp}`),
+            buildMetadataFolder: node_core_library_1.Path.convertToSlashes(`${heftConfiguration.buildFolder}/temp`),
             typeScriptToolPath: toolPackageResolution.typeScriptPackagePath,
@@ -129,0 +129,0 @@ tslintToolPath: toolPackageResolution.tslintPackagePath,

package.json

 {
 	"name": "@rushstack/heft",
-	"version": "0.38.2",
+	"version": "0.39.0",
 	"description": "Build all your JavaScript projects the same way: A way that works.",
@@ -5,0 +5,0 @@ "keywords": [

No alert changes

Improved metrics

Total package byte prevSize

1134471

increased by0.13%

Lines of code

11881

increased by0.24%

No dependency changes