@sap-devx/feature-toggle-node - npm Package Compare versions

Comparing version 1.0.2 to 1.0.3

lib/api.js

 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
+exports.isFeatureEnabled = void 0;
 const clientManager = require("./unleash_client_manager");
@@ -7,2 +8,3 @@ const contextManager = require("./context_manager");
 async function isFeatureEnabled(extensionName, featureToggleName) {
+    logger_1.log(`Checking if Extension Name: "${extensionName}", Feature Toggle Name: "${featureToggleName}" is enabled`);
     const ftName = `${extensionName}.${featureToggleName}`;
@@ -9,0 +11,0 @@ try {

lib/appstudio_context.js

 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
+exports.createContextObject = void 0;
 const utils_1 = require("./utils");
@@ -4,0 +5,0 @@ const USER_NAME = "USER_NAME";

lib/appstudio_strategy.js

 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
+exports.AppStudioMultiStrategy = void 0;
 const unleash_client_1 = require("unleash-client");
@@ -4,0 +5,0 @@ // The name of the str in the server

lib/context_manager.js

 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
+exports.getContext = exports.getContextFromMap = void 0;
 const appstudio_context_1 = require("./appstudio_context");
@@ -4,0 +5,0 @@ // Map of context.

lib/logger.js

 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
+exports.log = exports.SHOW_LOG_ENV = void 0;
 exports.SHOW_LOG_ENV = "SHOW_LOG";
@@ -4,0 +5,0 @@ function log(logMessage) {

lib/server_arguments.js

 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
+exports.getServerArgs = exports.ENV_REFRESH_INTERVAL_NAME = exports.ENV_FT_SERVER_ENDPOINT_NAME = void 0;
 const logger_1 = require("./logger");
 const utils_1 = require("./utils");
-// eslint-disable-next-line @typescript-eslint/no-var-requires
-const parseDuration = require("parse-duration");
+const parse_duration_1 = require("parse-duration");
 exports.ENV_FT_SERVER_ENDPOINT_NAME = "FT_SERVER_ENDPOINT";
 exports.ENV_REFRESH_INTERVAL_NAME = "FT_CLIENT_REFRESH_INTERVAL";
-const DEFAULT_REFRESH_INTERVAL = "10s"; //10 sec
+const DEFAULT_REFRESH_INTERVAL = 10000; //10 sec
 // get featureToggle server url and client refresh interval from environment variables
@@ -17,16 +17,17 @@ function getServerArgs() {
     //get refresh interval
-    let interval = process.env[exports.ENV_REFRESH_INTERVAL_NAME];
+    const intervalEnv = process.env[exports.ENV_REFRESH_INTERVAL_NAME];
+    let interval;
     // do not parse undefined, empty...
-    if (interval) {
-        interval = parseDuration(interval);
+    if (intervalEnv) {
+        interval = parse_duration_1.default(intervalEnv);
     }
     // parse parseDuration result
     if (!interval) {
-        interval = parseDuration(DEFAULT_REFRESH_INTERVAL);
-        logger_1.log(`[INFO] client refresh interval not set or in incorrect pattern, using the default interval: ${DEFAULT_REFRESH_INTERVAL}`);
+        interval = DEFAULT_REFRESH_INTERVAL;
+        logger_1.log(`[ERROR] client refresh interval not set or in incorrect pattern, using the default interval: ${DEFAULT_REFRESH_INTERVAL}`);
     }
     logger_1.log(`client refresh interval is: ${interval}`);
-    return { ftServerEndPoint: endpoint, ftServerInterval: Number(interval) };
+    return { ftServerEndPoint: endpoint, ftServerInterval: interval };
 }
 exports.getServerArgs = getServerArgs;
 //# sourceMappingURL=server_arguments.js.map

lib/unleash_client_manager.js

 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
+exports.getUnleashClient = exports.getUnleashClientFromMap = void 0;
 const ServerArgs = require("./server_arguments");
@@ -4,0 +5,0 @@ const unleash_client_wrapper_1 = require("./unleash_client_wrapper");

lib/unleash_client_wrapper.js

 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
+exports.initializeUnleashClient = void 0;
 const unleash_client_1 = require("unleash-client");
@@ -4,0 +5,0 @@ const logger_1 = require("./logger");

lib/utils.js

 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
+exports.getEnv = void 0;
 const logger_1 = require("./logger");
@@ -4,0 +5,0 @@ function getEnv(envName, errorMessage) {

package.json

 {
   "name": "@sap-devx/feature-toggle-node",
-  "version": "1.0.2",
+  "version": "1.0.3",
   "description": "",
@@ -37,4 +37,4 @@ "main": "lib/api.js",
     "@types/sinon": "^9.0.0",
-    "@typescript-eslint/eslint-plugin": "2.30.0",
-    "@typescript-eslint/parser": "2.30.0",
+    "@typescript-eslint/eslint-plugin": "2.34.0",
+    "@typescript-eslint/parser": "2.34.0",
     "chai": "^4.2.0",
@@ -51,4 +51,4 @@ "eslint": "6.8.0",
     "source-map-support": "0.5.19",
-    "ts-node": "8.9.1",
-    "typescript": "3.8.3"
+    "ts-node": "8.10.2",
+    "typescript": "3.9.3"
   },
@@ -85,5 +85,5 @@ "mocha": {
     "await-to-js": "^2.1.1",
-    "parse-duration": "^0.3.0",
-    "unleash-client": "^3.3.3"
+    "parse-duration": "^0.4.4",
+    "unleash-client": "^3.3.5"
   }
 }

src/api.ts

@@ -8,2 +8,4 @@ import { Context } from "unleash-client/lib/context";
 export async function isFeatureEnabled(extensionName: string, featureToggleName: string): Promise<boolean> {
+  log(`Checking if Extension Name: "${extensionName}", Feature Toggle Name: "${featureToggleName}" is enabled`);
+
   const ftName = `${extensionName}.${featureToggleName}`;
@@ -10,0 +12,0 @@ try {

src/server_arguments.ts

 import { log } from "./logger";
 import { getEnv } from "./utils";
-// eslint-disable-next-line @typescript-eslint/no-var-requires
-const parseDuration = require("parse-duration");
+import parseDuration from "parse-duration";
 
 export const ENV_FT_SERVER_ENDPOINT_NAME = "FT_SERVER_ENDPOINT";
 export const ENV_REFRESH_INTERVAL_NAME = "FT_CLIENT_REFRESH_INTERVAL";
-const DEFAULT_REFRESH_INTERVAL = "10s"; //10 sec
+const DEFAULT_REFRESH_INTERVAL = 10000; //10 sec
 
@@ -23,14 +22,15 @@ export interface ServerArgs {
   //get refresh interval
-  let interval = process.env[ENV_REFRESH_INTERVAL_NAME];
+  const intervalEnv = process.env[ENV_REFRESH_INTERVAL_NAME];
+  let interval;
   // do not parse undefined, empty...
-  if (interval) {
-    interval = parseDuration(interval);
+  if (intervalEnv) {
+    interval = parseDuration(intervalEnv);
   }
   // parse parseDuration result
   if (!interval) {
-    interval = parseDuration(DEFAULT_REFRESH_INTERVAL);
-    log(`[INFO] client refresh interval not set or in incorrect pattern, using the default interval: ${DEFAULT_REFRESH_INTERVAL}`);
+    interval = DEFAULT_REFRESH_INTERVAL;
+    log(`[ERROR] client refresh interval not set or in incorrect pattern, using the default interval: ${DEFAULT_REFRESH_INTERVAL}`);
   }
   log(`client refresh interval is: ${interval}`);
-  return { ftServerEndPoint: endpoint, ftServerInterval: Number(interval) };
+  return { ftServerEndPoint: endpoint, ftServerInterval: interval };
 }

No alert changes

Improved metrics

Total package byte prevSize

54819

increased by1.11%

Lines of code

641

increased by1.75%

Dependency changes

• + Addedparse-duration@0.4.4(transitive)

• - Removedparse-duration@0.3.3(transitive)

• Updatedparse-duration@^0.4.4

• Updatedunleash-client@^3.3.5