@sap/swa-for-sapbas-vsx - npm Package Compare versions

Comparing version 1.1.1 to 1.1.2

package.json

 {
   "name": "@sap/swa-for-sapbas-vsx",
-  "version": "1.1.1",
+  "version": "1.1.2",
   "author": "SAP SE",
@@ -5,0 +5,0 @@ "description": "Javascript module for SWA tracking to be consumed by VsCode extensions",

src/index.js

@@ -124,4 +124,8 @@ 'use strict';
     _isAnalyticsEnabled() {
-        // Should consider if this is the correct way or if we can check this without accessing vscode each time
-        let enabled = require('vscode').workspace.getConfiguration().get(this.vsxPackageName + "." + ANALYTICS_ENABLED_SETTING_NAME);
+        let enabled = undefined;
+        try {
+            enabled = require('vscode').workspace.getConfiguration().get(this.vsxPackageName + "." + ANALYTICS_ENABLED_SETTING_NAME);
+        } catch {
+            // Ignore and continue with flow.
+        }
         if (enabled === undefined) {
@@ -128,0 +132,0 @@ if (this._getProcessEnv("SWA_USER_ANON") === "literalFalse")

test/test.js

 const swa = require("../src/index.js");
 const assert = require("assert");
 
-const swaObj = new swa.SWATracker("testId");
+const swaObj = new swa.SWATracker("testPublisher","testPackageName");
 describe("Check _prepareCustomEvents", () => {
@@ -27,2 +27,5 @@ it("validate custom_params", () => {
     });
+    it("validate tracking disabled on nodejs run", () => {
+        return assert(!swaObj._isAnalyticsEnabled(), "Analytics not disabled")
+    })
 });

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

36462

increased by2.05%

Number of package files

14

increased by7.69%

Lines of code

214

increased by14.44%

No dependency changes