@sb1/ffe-accordion-react - npm Package Compare versions

Comparing version 8.0.1 to 8.0.2

CHANGELOG.md

@@ -6,2 +6,13 @@ # Change Log
 
+## [8.0.2](https://github.com/SpareBank1/designsystem/compare/@sb1/ffe-accordion-react@8.0.1...@sb1/ffe-accordion-react@8.0.2) (2020-08-12)
+
+
+### Bug Fixes
+
+* **ffe-accordion-react:** a11y fixes ([837abf4](https://github.com/SpareBank1/designsystem/commit/837abf475adb0f248f26da85b8ec2ebb38bb6f77))
+
+
+
+
+
 ## [8.0.1](https://github.com/SpareBank1/designsystem/compare/@sb1/ffe-accordion-react@8.0.0...@sb1/ffe-accordion-react@8.0.1) (2020-08-04)
@@ -8,0 +19,0 @@

es/Accordion.js

@@ -60,3 +60,3 @@ function _typeof(obj) { "@babel/helpers - typeof"; if (typeof Symbol === "function" && typeof Symbol.iterator === "symbol") { _typeof = function _typeof(obj) { return typeof obj; }; } else { _typeof = function _typeof(obj) { return obj && typeof Symbol === "function" && obj.constructor === Symbol && obj !== Symbol.prototype ? "symbol" : typeof obj; }; } return _typeof(obj); }
 
-      return /*#__PURE__*/React.createElement("ul", _extends({}, rest, {
+      return /*#__PURE__*/React.createElement("div", _extends({}, rest, {
         "aria-multiselectable": "true",
@@ -68,5 +68,6 @@ className: classNames({
         role: "tablist"
-      }), React.Children.map(children, function (ele) {
+      }), React.Children.map(children, function (ele, index) {
         return /*#__PURE__*/React.cloneElement(ele, {
-          uuid: _this2.id
+          uuid: _this2.id,
+          index: index
         });
@@ -73,0 +74,0 @@ }));

es/Accordion.spec.js

@@ -10,5 +10,5 @@ import { AccordionItem, WhiteAccordion } from '.';
 describe('<Accordion />', function () {
-  it('renders an unorderered list', function () {
+  it('renders a tablist', function () {
     var wrapper = getWrapper();
-    expect(wrapper.is('ul')).toBe(true);
+    expect(wrapper.find('[role="tablist"]').exists()).toBe(true);
   });
@@ -15,0 +15,0 @@ it('provides the same uuid property to each child', function () {

es/AccordionItem.js

@@ -105,3 +105,3 @@ function _typeof(obj) { "@babel/helpers - typeof"; if (typeof Symbol === "function" && typeof Symbol.iterator === "symbol") { _typeof = function _typeof(obj) { return typeof obj; }; } else { _typeof = function _typeof(obj) { return obj && typeof Symbol === "function" && obj.constructor === Symbol && obj !== Symbol.prototype ? "symbol" : typeof obj; }; } return _typeof(obj); }
       var open = this.getOpen();
-      return /*#__PURE__*/React.createElement("li", {
+      return /*#__PURE__*/React.createElement("div", {
         className: classNames({
@@ -108,0 +108,0 @@ 'ffe-accordion-item': true,

es/BlueAccordion.spec.js

@@ -12,4 +12,4 @@ import { AccordionItem, BlueAccordion } from '.';
     var wrapper = getWrapper();
-    expect(wrapper.find('ul.ffe-accordion.ffe-accordion--blue').length).toBe(1);
+    expect(wrapper.find('.ffe-accordion.ffe-accordion--blue').length).toBe(1);
   });
 });

lib/Accordion.js

@@ -76,3 +76,3 @@ "use strict";
 
-      return /*#__PURE__*/_react.default.createElement("ul", _extends({}, rest, {
+      return /*#__PURE__*/_react.default.createElement("div", _extends({}, rest, {
         "aria-multiselectable": "true",
@@ -84,5 +84,6 @@ className: (0, _classnames.default)({
         role: "tablist"
-      }), _react.default.Children.map(children, function (ele) {
+      }), _react.default.Children.map(children, function (ele, index) {
         return /*#__PURE__*/_react.default.cloneElement(ele, {
-          uuid: _this2.id
+          uuid: _this2.id,
+          index: index
         });
@@ -89,0 +90,0 @@ }));

lib/Accordion.spec.js

@@ -16,5 +16,5 @@ "use strict";
 describe('<Accordion />', function () {
-  it('renders an unorderered list', function () {
+  it('renders a tablist', function () {
     var wrapper = getWrapper();
-    expect(wrapper.is('ul')).toBe(true);
+    expect(wrapper.find('[role="tablist"]').exists()).toBe(true);
   });
@@ -21,0 +21,0 @@ it('provides the same uuid property to each child', function () {

lib/AccordionItem.js

@@ -122,3 +122,3 @@ "use strict";
       var open = this.getOpen();
-      return /*#__PURE__*/_react.default.createElement("li", {
+      return /*#__PURE__*/_react.default.createElement("div", {
         className: (0, _classnames.default)({
@@ -125,0 +125,0 @@ 'ffe-accordion-item': true,

lib/BlueAccordion.spec.js

@@ -18,4 +18,4 @@ "use strict";
     var wrapper = getWrapper();
-    expect(wrapper.find('ul.ffe-accordion.ffe-accordion--blue').length).toBe(1);
+    expect(wrapper.find('.ffe-accordion.ffe-accordion--blue').length).toBe(1);
   });
 });

package.json

 {
   "name": "@sb1/ffe-accordion-react",
-  "version": "8.0.1",
+  "version": "8.0.2",
   "license": "MIT",
@@ -52,3 +52,3 @@ "author": "SpareBank 1",
   },
-  "gitHead": "d7f6331ac51a6ecec0fedd41145d8948e414becd"
+  "gitHead": "12e214aebdd2b59940a6babf3740eb10d6210bb6"
 }

No alert changes

Improved metrics

Total package byte prevSize

73461

increased by0.54%

Lines of code

841

increased by0.24%

No dependency changes