@semantic-ui/component - npm Package Compare versions

Comparing version 0.0.31 to 0.0.32

package.json

@@ -15,8 +15,8 @@ {
   "dependencies": {
-    "@semantic-ui/query": "^0.0.31",
-    "@semantic-ui/reactivity": "^0.0.31",
-    "@semantic-ui/templating": "^0.0.31",
-    "@semantic-ui/utils": "^0.0.31"
+    "@semantic-ui/query": "^0.0.32",
+    "@semantic-ui/reactivity": "^0.0.32",
+    "@semantic-ui/templating": "^0.0.32",
+    "@semantic-ui/utils": "^0.0.32"
   },
-  "version": "0.0.31"
+  "version": "0.0.32"
 }

src/create-component.js

@@ -39,3 +39,2 @@ import { unsafeCSS } from 'lit';
   renderingEngine,
-  beforeRendered = noop,
 } = {}) => {
@@ -42,0 +41,0 @@

src/engines/lit/renderer.js

@@ -331,6 +331,6 @@ import { html } from 'lit';
   getLiteralValue(token) {
-    // check if this is a string literal
-    const stringMatches = token.match(LitRenderer.STRING_REGEXP);
-    if (stringMatches && stringMatches.length > 0) {
-      return stringMatches[1];
+
+    // Check if this is a string literal (single or double quotes)
+    if (token.length > 1 && (token[0] === "'" || token[0] === '"') && token[0] === token[token.length - 1]) {
+      return token.slice(1, -1).replace(/\\(['"])/g, '$1');
     }
@@ -337,0 +337,0 @@

src/helpers/adjust-property-from-attribute.js

@@ -1,2 +0,2 @@
-import { get, each, unique, firstMatch, inArray, isString } from '@semantic-ui/utils';
+import { get, each, unique, firstMatch, inArray, isString, kebabToCamel, camelToKebab } from '@semantic-ui/utils';
 
@@ -43,4 +43,4 @@ /*
 
-  // This is used to search for potential values that should
-  // to the canonical way. This is because we support swapping ordering and spaces for dashes
+  // This is used to search for potential values that should match to the canonical value.
+  // This is because we support swapping ordering and spaces for dashes
 
@@ -51,3 +51,2 @@ // note "optionAttributeValue" is the value of the option attribute i.e. "somevalue" here
   const checkSpecForAllowedValue = ({attribute, optionValue, optionAttributeValue }) => {
-
     // "arrow down" -> arrow-down
@@ -91,2 +90,6 @@ optionValue = tokenizeSpaces(optionValue);
   const setProperty = (property, value) => {
+
+    // convert <div icon-after> to => el.iconAfter
+    property = kebabToCamel(property);
+
     if(value !== undefined) {
@@ -99,2 +102,6 @@ el[property] = value;
   const removeProperty = (property) => {
+
+    // convert <div icon-after> to => el.iconAfter
+    property = kebabToCamel(property);
+
     el[property] = undefined;
@@ -117,4 +124,4 @@ };
 
-      if(attributeValue === '') {
-        // boolean attribute
+      // boolean attribute
+      if(componentSpec.propertyTypes[attribute] == Boolean && inArray(attributeValue, ['', true])) {
         attributeValue = true;
@@ -121,0 +128,0 @@ setProperty(attribute, attributeValue);

src/web-component.js

 import { LitElement } from 'lit';
-import { each, isFunction, isNumber, isString, isPlainObject, keys, unique, isServer, inArray, get, isBoolean, isArray } from '@semantic-ui/utils';
+import { each, isFunction, kebabToCamel, keys, unique, isServer, inArray, get } from '@semantic-ui/utils';
 import { $ } from '@semantic-ui/query';
@@ -282,2 +282,5 @@ import { scopeStyles } from './helpers/scope-styles.js';
       }
+
+      property = kebabToCamel(property);
+
       const elementProp = this[property];
@@ -294,3 +297,3 @@ const setting = elementProp  // check element setting
       if (componentSpec && settings[elementProp] !== undefined) {
-        settings[elementProp] = true;
+        settings[property] = true;
       }
@@ -322,5 +325,2 @@ });
         });
-        if(property == 'activeFile') {
-          console.log('getting setting', settings, property, get(settings, property));
-        }
         return get(settings, property);
@@ -327,0 +327,0 @@ },

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

53456

increased by0.32%

Dependency changes

• + Added@semantic-ui/query@0.0.32(transitive)

• + Added@semantic-ui/reactivity@0.0.32(transitive)

• + Added@semantic-ui/templating@0.0.32(transitive)

• + Added@semantic-ui/utils@0.0.32(transitive)

• - Removed@semantic-ui/query@0.0.31(transitive)

• - Removed@semantic-ui/reactivity@0.0.31(transitive)

• - Removed@semantic-ui/templating@0.0.31(transitive)

• - Removed@semantic-ui/utils@0.0.31(transitive)

• Updated@semantic-ui/query@^0.0.32

• Updated@semantic-ui/reactivity@^0.0.32

• Updated@semantic-ui/templating@^0.0.32

• Updated@semantic-ui/utils@^0.0.32