@servicetitan/ko-bridge - npm Package Compare versions

Comparing version 19.2.0 to 19.3.0

dist/ko-observable-to-mobx.js

@@ -13,5 +13,7 @@ "use strict";
     let value;
+    let lastKoObservable;
     function firstAccessInit() {
-        if (!value) {
+        if (lastKoObservable !== lazyKoObservable()) {
             value = convertKoObservableToMobx(lazyKoObservable());
+            lastKoObservable = lazyKoObservable();
         }
@@ -18,0 +20,0 @@ }

package.json

 {
     "name": "@servicetitan/ko-bridge",
-    "version": "19.2.0",
+    "version": "19.3.0",
     "description": "",
@@ -38,3 +38,3 @@ "homepage": "https://docs.st.dev/docs/frontend/ko-bridge",
     },
-    "gitHead": "62c48deffc4ed9aba58325fbad1b256ecbfae553"
+    "gitHead": "c2541cf4d4dc01064f7d327370a90f7b4d107a0e"
 }

src/__tests__/ko-observable-to-mobx.test.ts

@@ -155,1 +155,20 @@ import { autorun } from 'mobx';
 });
+
+test('Reassign ko.observable after `value` is read', () => {
+    let koObservable = ko.observable(true);
+
+    class Store {
+        @koObservableToMobx(() => koObservable)
+        declare value: string;
+    }
+
+    const instance = new Store();
+
+    expect(instance.value).toBe(true);
+
+    koObservable = ko.observable(true);
+
+    koObservable(false);
+
+    expect(instance.value).toBe(false);
+});

src/ko-observable-to-mobx.ts

@@ -11,6 +11,8 @@ import { computed, createAtom, IComputedValue } from 'mobx';
     let value: IComputedValue<T>;
+    let lastKoObservable: KnockoutObservable<T> | undefined;
 
     function firstAccessInit() {
-        if (!value) {
+        if (lastKoObservable !== lazyKoObservable()) {
             value = convertKoObservableToMobx(lazyKoObservable());
+            lastKoObservable = lazyKoObservable();
         }
@@ -17,0 +19,0 @@ }

No alert changes

Improved metrics

Total package byte prevSize

36398

increased by2.03%

Lines of code

733

increased by2.23%

No dependency changes