@shapediver/viewer.shared.node-tree - npm Package Compare versions

Comparing version 2.9.1 to 2.9.2

dist/implementation/AbstractTreeNode.d.ts

@@ -54,4 +54,4 @@ import { mat4 } from 'gl-matrix';
     getData(id: string): U | undefined;
-    getNodesByName(node: T, name: string): T[];
-    getNodesByNameWithRegex(node: T, regex: RegExp): T[];
+    getNodesByName(name: string): T[];
+    getNodesByNameWithRegex(regex: RegExp): T[];
     getPath(): string;
@@ -58,0 +58,0 @@ getTransformation(id: string): ITransformation | undefined;

dist/implementation/AbstractTreeNode.js

@@ -229,7 +229,7 @@ "use strict";
     }
-    getNodesByName(node, name) {
+    getNodesByName(name) {
         let nodes = [];
-        if (name === node.name)
-            nodes.push(node);
-        node.traverse((n) => {
+        if (name === this.name)
+            nodes.push(this);
+        this.traverse((n) => {
             if (name === n.name)
@@ -241,7 +241,7 @@ nodes.push(n);
     ;
-    getNodesByNameWithRegex(node, regex) {
+    getNodesByNameWithRegex(regex) {
         let nodes = [];
-        if (regex.test(node.name))
-            nodes.push(node);
-        node.traverse((n) => {
+        if (regex.test(this.name))
+            nodes.push(this);
+        this.traverse((n) => {
             if (regex.test(n.name))
@@ -248,0 +248,0 @@ nodes.push(n);

dist/interfaces/ITreeNode.d.ts

@@ -132,12 +132,10 @@ import { mat4 } from 'gl-matrix';
      * Test this node and all it's descendents for nodes with the specified name and return them in an array.
-     * @param node
      * @param name
      */
-    getNodesByName(node: T, name: string): T[];
+    getNodesByName(name: string): T[];
     /**
      * Test this nodes name and all it's descendents name for nodes for the specified regex and return them in an array.
-     * @param node
      * @param regex
      */
-    getNodesByNameWithRegex(node: T, regex: RegExp): T[];
+    getNodesByNameWithRegex(regex: RegExp): T[];
     /**
@@ -144,0 +142,0 @@ * Return the path to this node.

package.json

 {
   "name": "@shapediver/viewer.shared.node-tree",
-  "version": "2.9.1",
+  "version": "2.9.2",
   "description": "",
@@ -42,4 +42,4 @@ "keywords": [],
   "dependencies": {
-    "@shapediver/viewer.shared.math": "2.9.1",
-    "@shapediver/viewer.shared.services": "2.9.1",
+    "@shapediver/viewer.shared.math": "2.9.2",
+    "@shapediver/viewer.shared.services": "2.9.2",
     "@types/three": "0.149.0",
@@ -49,3 +49,3 @@ "gl-matrix": "3.3.0",
   },
-  "gitHead": "c7b6d22d492066831588ca0e9ce66844b921dc6f"
+  "gitHead": "0d3496367603fcd4ac22df8c0bf8f4a3505dda01"
 }

src/implementation/AbstractTreeNode.ts

@@ -280,6 +280,6 @@ import { mat4 } from 'gl-matrix'
 
-  public getNodesByName(node: T, name: string): T[] {
+  public getNodesByName(name: string): T[] {
     let nodes: T[] = [];
-    if (name === node.name) nodes.push(node);
-    node.traverse((n) => {
+    if (name === this.name) nodes.push(<T><unknown>this);
+    this.traverse((n) => {
       if (name === n.name) nodes.push(n);
@@ -290,6 +290,6 @@ });
 
-  public getNodesByNameWithRegex(node: T, regex: RegExp): T[] {
+  public getNodesByNameWithRegex(regex: RegExp): T[] {
     let nodes: T[] = [];
-    if (regex.test(node.name)) nodes.push(node);
-    node.traverse((n) => {
+    if (regex.test(this.name)) nodes.push(<T><unknown>this);
+    this.traverse((n) => {
       if (regex.test(n.name)) nodes.push(n);
@@ -296,0 +296,0 @@ });

src/interfaces/ITreeNode.ts

@@ -144,12 +144,10 @@ import { mat4 } from 'gl-matrix'
      * Test this node and all it's descendents for nodes with the specified name and return them in an array.
-     * @param node 
      * @param name 
      */
-    getNodesByName(node: T, name: string): T[]
+    getNodesByName(name: string): T[]
     /**
      * Test this nodes name and all it's descendents name for nodes for the specified regex and return them in an array.
-     * @param node 
      * @param regex 
      */
-    getNodesByNameWithRegex(node: T, regex: RegExp): T[]
+    getNodesByNameWithRegex(regex: RegExp): T[]
     /**
@@ -156,0 +154,0 @@ * Return the path to this node.

No alert changes

Worsened metrics

Total package byte prevSize

107541

decreased by-0.23%

Lines of code

1835

decreased by-0.22%

Dependency changes

• + Added@shapediver/viewer.shared.build-data@2.9.2(transitive)

• + Added@shapediver/viewer.shared.math@2.9.2(transitive)

• + Added@shapediver/viewer.shared.services@2.9.2(transitive)

• - Removed@shapediver/viewer.shared.build-data@2.9.1(transitive)

• - Removed@shapediver/viewer.shared.math@2.9.1(transitive)

• - Removed@shapediver/viewer.shared.services@2.9.1(transitive)

• Updated@shapediver/viewer.shared.math@2.9.2

• Updated@shapediver/viewer.shared.services@2.9.2